[PATCH] bpf: Fix sparse warnings in kprobe_multi_resolve_syms

[PATCH] bpf: Fix sparse warnings in kprobe_multi_resolve_syms

[Jiri Olsa]

Adding missing __user tags to fix sparse warnings:

kernel/trace/bpf_trace.c:2370:34: warning: incorrect type in argument 2 (different address spaces)
kernel/trace/bpf_trace.c:2370:34:    expected void const [noderef] __user *from
kernel/trace/bpf_trace.c:2370:34:    got void const *usyms
kernel/trace/bpf_trace.c:2376:51: warning: incorrect type in argument 2 (different address spaces)
kernel/trace/bpf_trace.c:2376:51:    expected char const [noderef] __user *src
kernel/trace/bpf_trace.c:2376:51:    got char const *
kernel/trace/bpf_trace.c:2443:49: warning: incorrect type in argument 1 (different address spaces)
kernel/trace/bpf_trace.c:2443:49:    expected void const *usyms
kernel/trace/bpf_trace.c:2443:49:    got void [noderef] __user *[assigned] usyms

Reported-by: Alexei Starovoitov <ast@kernel.org>
Fixes: 0dcac2725406 ("bpf: Add multi kprobe link")
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 kernel/trace/bpf_trace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
index 7fa2ebc07f60..d8553f46caa2 100644
--- a/kernel/trace/bpf_trace.c
+++ b/kernel/trace/bpf_trace.c
@@ -2349,11 +2349,11 @@ kprobe_multi_link_handler(struct fprobe *fp, unsigned long entry_ip,
 }
 
 static int
-kprobe_multi_resolve_syms(const void *usyms, u32 cnt,
+kprobe_multi_resolve_syms(const void __user *usyms, u32 cnt,
 			  unsigned long *addrs)
 {
 	unsigned long addr, size;
-	const char **syms;
+	const char __user **syms;
 	int err = -ENOMEM;
 	unsigned int i;
 	char *func;
-- 
2.35.1

Re: [PATCH] bpf: Fix sparse warnings in kprobe_multi_resolve_syms

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Wed, 30 Mar 2022 13:05:10 +0200 you wrote:
> Adding missing __user tags to fix sparse warnings:
> 
> kernel/trace/bpf_trace.c:2370:34: warning: incorrect type in argument 2 (different address spaces)
> kernel/trace/bpf_trace.c:2370:34:    expected void const [noderef] __user *from
> kernel/trace/bpf_trace.c:2370:34:    got void const *usyms
> kernel/trace/bpf_trace.c:2376:51: warning: incorrect type in argument 2 (different address spaces)
> kernel/trace/bpf_trace.c:2376:51:    expected char const [noderef] __user *src
> kernel/trace/bpf_trace.c:2376:51:    got char const *
> kernel/trace/bpf_trace.c:2443:49: warning: incorrect type in argument 1 (different address spaces)
> kernel/trace/bpf_trace.c:2443:49:    expected void const *usyms
> kernel/trace/bpf_trace.c:2443:49:    got void [noderef] __user *[assigned] usyms
> 
> [...]

Here is the summary with links:
  - bpf: Fix sparse warnings in kprobe_multi_resolve_syms
    https://git.kernel.org/bpf/bpf/c/d31e0386a2f1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html