bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCHv2 bpf] selftests/bpf: Fix kprobe_multi_test/attach_override test
@ 2023-09-13 11:47 Jiri Olsa
  2023-09-13 18:43 ` Andrii Nakryiko
  2023-09-13 18:50 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 4+ messages in thread
From: Jiri Olsa @ 2023-09-13 11:47 UTC (permalink / raw)
  To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko
  Cc: bpf, Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
	KP Singh, Stanislav Fomichev, Hao Luo

We need to deny the attach_override test for arm64, denying the
whole kprobe_multi_test suite. Also making attach_override static.

Fixes: 7182e56411b9 ("selftests/bpf: Add kprobe_multi override test")
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/testing/selftests/bpf/DENYLIST.aarch64             | 9 +--------
 .../testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
 2 files changed, 2 insertions(+), 9 deletions(-)

v2 changes:
  - rebased on latest bpf/master, used just kprobe_multi_test suite name
    in DENYLIST.aarch64 to cover all kprobe_multi tests

diff --git a/tools/testing/selftests/bpf/DENYLIST.aarch64 b/tools/testing/selftests/bpf/DENYLIST.aarch64
index 7f768d335698..b733ce16c0f8 100644
--- a/tools/testing/selftests/bpf/DENYLIST.aarch64
+++ b/tools/testing/selftests/bpf/DENYLIST.aarch64
@@ -1,14 +1,7 @@
 bpf_cookie/multi_kprobe_attach_api               # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
 bpf_cookie/multi_kprobe_link_api                 # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
 fexit_sleep                                      # The test never returns. The remaining tests cannot start.
-kprobe_multi_bench_attach                        # bpf_program__attach_kprobe_multi_opts unexpected error: -95
-kprobe_multi_test/attach_api_addrs               # bpf_program__attach_kprobe_multi_opts unexpected error: -95
-kprobe_multi_test/attach_api_pattern             # bpf_program__attach_kprobe_multi_opts unexpected error: -95
-kprobe_multi_test/attach_api_syms                # bpf_program__attach_kprobe_multi_opts unexpected error: -95
-kprobe_multi_test/bench_attach                   # bpf_program__attach_kprobe_multi_opts unexpected error: -95
-kprobe_multi_test/link_api_addrs                 # link_fd unexpected link_fd: actual -95 < expected 0
-kprobe_multi_test/link_api_syms                  # link_fd unexpected link_fd: actual -95 < expected 0
-kprobe_multi_test/skel_api                       # libbpf: failed to load BPF skeleton 'kprobe_multi': -3
+kprobe_multi_test                                # needs CONFIG_FPROBE
 module_attach                                    # prog 'kprobe_multi': failed to auto-attach: -95
 fentry_test/fentry_many_args                     # fentry_many_args:FAIL:fentry_many_args_attach unexpected error: -524
 fexit_test/fexit_many_args                       # fexit_many_args:FAIL:fexit_many_args_attach unexpected error: -524
diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
index e05477b210a5..4041cfa670eb 100644
--- a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
+++ b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
@@ -454,7 +454,7 @@ static void test_kprobe_multi_bench_attach(bool kernel)
 	}
 }
 
-void test_attach_override(void)
+static void test_attach_override(void)
 {
 	struct kprobe_multi_override *skel = NULL;
 	struct bpf_link *link = NULL;
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCHv2 bpf] selftests/bpf: Fix kprobe_multi_test/attach_override test
  2023-09-13 11:47 [PATCHv2 bpf] selftests/bpf: Fix kprobe_multi_test/attach_override test Jiri Olsa
@ 2023-09-13 18:43 ` Andrii Nakryiko
  2023-09-14  6:31   ` Jiri Olsa
  2023-09-13 18:50 ` patchwork-bot+netdevbpf
  1 sibling, 1 reply; 4+ messages in thread
From: Andrii Nakryiko @ 2023-09-13 18:43 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, bpf,
	Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
	KP Singh, Stanislav Fomichev, Hao Luo

On Wed, Sep 13, 2023 at 4:47 AM Jiri Olsa <jolsa@kernel.org> wrote:
>
> We need to deny the attach_override test for arm64, denying the
> whole kprobe_multi_test suite. Also making attach_override static.
>
> Fixes: 7182e56411b9 ("selftests/bpf: Add kprobe_multi override test")
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/testing/selftests/bpf/DENYLIST.aarch64             | 9 +--------
>  .../testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
>  2 files changed, 2 insertions(+), 9 deletions(-)
>
> v2 changes:
>   - rebased on latest bpf/master, used just kprobe_multi_test suite name
>     in DENYLIST.aarch64 to cover all kprobe_multi tests
>
> diff --git a/tools/testing/selftests/bpf/DENYLIST.aarch64 b/tools/testing/selftests/bpf/DENYLIST.aarch64
> index 7f768d335698..b733ce16c0f8 100644
> --- a/tools/testing/selftests/bpf/DENYLIST.aarch64
> +++ b/tools/testing/selftests/bpf/DENYLIST.aarch64
> @@ -1,14 +1,7 @@
>  bpf_cookie/multi_kprobe_attach_api               # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
>  bpf_cookie/multi_kprobe_link_api                 # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
>  fexit_sleep                                      # The test never returns. The remaining tests cannot start.
> -kprobe_multi_bench_attach                        # bpf_program__attach_kprobe_multi_opts unexpected error: -95

did you drop kprobe_multi_bench_attach from DENYLIST intentionally?
I'll leave it in DENYLIST.aarch64 for now when applying

> -kprobe_multi_test/attach_api_addrs               # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> -kprobe_multi_test/attach_api_pattern             # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> -kprobe_multi_test/attach_api_syms                # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> -kprobe_multi_test/bench_attach                   # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> -kprobe_multi_test/link_api_addrs                 # link_fd unexpected link_fd: actual -95 < expected 0
> -kprobe_multi_test/link_api_syms                  # link_fd unexpected link_fd: actual -95 < expected 0
> -kprobe_multi_test/skel_api                       # libbpf: failed to load BPF skeleton 'kprobe_multi': -3
> +kprobe_multi_test                                # needs CONFIG_FPROBE
>  module_attach                                    # prog 'kprobe_multi': failed to auto-attach: -95
>  fentry_test/fentry_many_args                     # fentry_many_args:FAIL:fentry_many_args_attach unexpected error: -524
>  fexit_test/fexit_many_args                       # fexit_many_args:FAIL:fexit_many_args_attach unexpected error: -524
> diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> index e05477b210a5..4041cfa670eb 100644
> --- a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> +++ b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> @@ -454,7 +454,7 @@ static void test_kprobe_multi_bench_attach(bool kernel)
>         }
>  }
>
> -void test_attach_override(void)
> +static void test_attach_override(void)
>  {
>         struct kprobe_multi_override *skel = NULL;
>         struct bpf_link *link = NULL;
> --
> 2.41.0
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCHv2 bpf] selftests/bpf: Fix kprobe_multi_test/attach_override test
  2023-09-13 11:47 [PATCHv2 bpf] selftests/bpf: Fix kprobe_multi_test/attach_override test Jiri Olsa
  2023-09-13 18:43 ` Andrii Nakryiko
@ 2023-09-13 18:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-09-13 18:50 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: ast, daniel, andrii, bpf, kafai, songliubraving, yhs,
	john.fastabend, kpsingh, sdf, haoluo

Hello:

This patch was applied to bpf/bpf.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Wed, 13 Sep 2023 13:47:11 +0200 you wrote:
> We need to deny the attach_override test for arm64, denying the
> whole kprobe_multi_test suite. Also making attach_override static.
> 
> Fixes: 7182e56411b9 ("selftests/bpf: Add kprobe_multi override test")
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/testing/selftests/bpf/DENYLIST.aarch64             | 9 +--------
>  .../testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
>  2 files changed, 2 insertions(+), 9 deletions(-)
> 
> [...]

Here is the summary with links:
  - [PATCHv2,bpf] selftests/bpf: Fix kprobe_multi_test/attach_override test
    https://git.kernel.org/bpf/bpf/c/8a19edd4fa6f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCHv2 bpf] selftests/bpf: Fix kprobe_multi_test/attach_override test
  2023-09-13 18:43 ` Andrii Nakryiko
@ 2023-09-14  6:31   ` Jiri Olsa
  0 siblings, 0 replies; 4+ messages in thread
From: Jiri Olsa @ 2023-09-14  6:31 UTC (permalink / raw)
  To: Andrii Nakryiko
  Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, bpf,
	Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
	KP Singh, Stanislav Fomichev, Hao Luo

On Wed, Sep 13, 2023 at 11:43:47AM -0700, Andrii Nakryiko wrote:
> On Wed, Sep 13, 2023 at 4:47 AM Jiri Olsa <jolsa@kernel.org> wrote:
> >
> > We need to deny the attach_override test for arm64, denying the
> > whole kprobe_multi_test suite. Also making attach_override static.
> >
> > Fixes: 7182e56411b9 ("selftests/bpf: Add kprobe_multi override test")
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> >  tools/testing/selftests/bpf/DENYLIST.aarch64             | 9 +--------
> >  .../testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
> >  2 files changed, 2 insertions(+), 9 deletions(-)
> >
> > v2 changes:
> >   - rebased on latest bpf/master, used just kprobe_multi_test suite name
> >     in DENYLIST.aarch64 to cover all kprobe_multi tests
> >
> > diff --git a/tools/testing/selftests/bpf/DENYLIST.aarch64 b/tools/testing/selftests/bpf/DENYLIST.aarch64
> > index 7f768d335698..b733ce16c0f8 100644
> > --- a/tools/testing/selftests/bpf/DENYLIST.aarch64
> > +++ b/tools/testing/selftests/bpf/DENYLIST.aarch64
> > @@ -1,14 +1,7 @@
> >  bpf_cookie/multi_kprobe_attach_api               # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
> >  bpf_cookie/multi_kprobe_link_api                 # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
> >  fexit_sleep                                      # The test never returns. The remaining tests cannot start.
> > -kprobe_multi_bench_attach                        # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> 
> did you drop kprobe_multi_bench_attach from DENYLIST intentionally?
> I'll leave it in DENYLIST.aarch64 for now when applying

ugh, no it should stay.. thanks a lot

jirka

> 
> > -kprobe_multi_test/attach_api_addrs               # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> > -kprobe_multi_test/attach_api_pattern             # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> > -kprobe_multi_test/attach_api_syms                # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> > -kprobe_multi_test/bench_attach                   # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> > -kprobe_multi_test/link_api_addrs                 # link_fd unexpected link_fd: actual -95 < expected 0
> > -kprobe_multi_test/link_api_syms                  # link_fd unexpected link_fd: actual -95 < expected 0
> > -kprobe_multi_test/skel_api                       # libbpf: failed to load BPF skeleton 'kprobe_multi': -3
> > +kprobe_multi_test                                # needs CONFIG_FPROBE
> >  module_attach                                    # prog 'kprobe_multi': failed to auto-attach: -95
> >  fentry_test/fentry_many_args                     # fentry_many_args:FAIL:fentry_many_args_attach unexpected error: -524
> >  fexit_test/fexit_many_args                       # fexit_many_args:FAIL:fexit_many_args_attach unexpected error: -524
> > diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > index e05477b210a5..4041cfa670eb 100644
> > --- a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > @@ -454,7 +454,7 @@ static void test_kprobe_multi_bench_attach(bool kernel)
> >         }
> >  }
> >
> > -void test_attach_override(void)
> > +static void test_attach_override(void)
> >  {
> >         struct kprobe_multi_override *skel = NULL;
> >         struct bpf_link *link = NULL;
> > --
> > 2.41.0
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-14  6:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-13 11:47 [PATCHv2 bpf] selftests/bpf: Fix kprobe_multi_test/attach_override test Jiri Olsa
2023-09-13 18:43 ` Andrii Nakryiko
2023-09-14  6:31   ` Jiri Olsa
2023-09-13 18:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).