From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Y Song <ys114321@gmail.com>, Alexei Starovoitov <ast@kernel.org>
Cc: Farid Zakaria <farid.m.zakaria@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH 1/1] bpf: introduce new helper udp_flow_src_port
Date: Mon, 5 Aug 2019 17:10:36 -0700 [thread overview]
Message-ID: <20190805171036.5a5bf790@cakuba.netronome.com> (raw)
In-Reply-To: <CAH3MdRXTEN-Ra+61QA37hM2mkHx99K5NM7f+H6d8Em-bxvaenw@mail.gmail.com>
On Sat, 3 Aug 2019 23:52:16 -0700, Y Song wrote:
> > include/uapi/linux/bpf.h | 21 +++++++--
> > net/core/filter.c | 20 ++++++++
> > tools/include/uapi/linux/bpf.h | 21 +++++++--
> > tools/testing/selftests/bpf/bpf_helpers.h | 2 +
> > .../bpf/prog_tests/udp_flow_src_port.c | 28 +++++++++++
> > .../bpf/progs/test_udp_flow_src_port_kern.c | 47 +++++++++++++++++++
> > 6 files changed, 131 insertions(+), 8 deletions(-)
> > create mode 100644 tools/testing/selftests/bpf/prog_tests/udp_flow_src_port.c
> > create mode 100644 tools/testing/selftests/bpf/progs/test_udp_flow_src_port_kern.c
>
> First, for each review, backport and sync with libbpf repo, in the future,
> could you break the patch to two patches?
> 1. kernel changes (net/core/filter.c, include/uapi/linux/bpf.h)
> 2. tools/include/uapi/linux/bpf.h
> 3. tools/testing/ changes
A lot of people get caught off by this, could explain why this is
necessary?
git can deal with this scenario without missing a step, format-patch
takes paths:
$ git show --oneline -s
1002f3e955d7 (HEAD) bpf: introduce new helper udp_flow_src_port
$ git format-patch HEAD~ -- tools/include/uapi/linux/bpf.h
0001-bpf-introduce-new-helper-udp_flow_src_port.patch
$ grep -B1 changed 0001-bpf-introduce-new-helper-udp_flow_src_port.patch
tools/include/uapi/linux/bpf.h | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
$ cd ../libbpf
$ git am -p2 ../linux/0001-bpf-introduce-new-helper-udp_flow_src_port.patch
Applying: bpf: introduce new helper udp_flow_src_port
error: patch failed: include/uapi/linux/bpf.h:2853
error: include/uapi/linux/bpf.h: patch does not apply
...
Well, the patch doesn't apply to libbpf right now, but git finds the
right paths and all that.
IMO it'd be good to not have this artificial process obstacle and all
the "sync headers" commits in the tree.
next prev parent reply other threads:[~2019-08-06 0:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-03 4:43 [PATCH 0/1] bpf: introduce new helper udp_flow_src_port Farid Zakaria
2019-08-03 4:43 ` [PATCH 1/1] " Farid Zakaria
2019-08-04 6:52 ` Y Song
[not found] ` <CACCo2jmcYAfY8zHJiT7NCb-Ct7Wguk9XHRc8QmZa7V3eJy0WTg@mail.gmail.com>
2019-08-04 20:43 ` Farid Zakaria
2019-08-04 23:04 ` Y Song
2019-08-06 0:10 ` Jakub Kicinski [this message]
2019-08-08 18:48 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805171036.5a5bf790@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=farid.m.zakaria@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ys114321@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).