From: Stanislav Fomichev <sdf@fomichev.me>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Stanislav Fomichev <sdf@google.com>,
Network Development <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andriin@fb.com>
Subject: Re: [PATCH bpf-next 1/4] selftests/bpf: test_progs: change formatting of the condenced output
Date: Wed, 14 Aug 2019 10:07:48 -0700 [thread overview]
Message-ID: <20190814170748.GK2820@mini-arch> (raw)
In-Reply-To: <CAADnVQJk=qSLR1A=1poPY85wNqiye3dMvXZOZ+1OFZSA78VARg@mail.gmail.com>
On 08/14, Alexei Starovoitov wrote:
> On Wed, Aug 14, 2019 at 9:47 AM Stanislav Fomichev <sdf@google.com> wrote:
> >
> > This makes it visually simpler to follow the output.
> > Also, highlight with red color failures when outputting to tty.
> >
> > Before:
> > #1 attach_probe:FAIL
> > #2 bpf_obj_id:OK
> > #3/1 bpf_verif_scale:loop3.o:OK
> > #3/2 bpf_verif_scale:test_verif_scale1.o:OK
> > #3/3 bpf_verif_scale:test_verif_scale2.o:OK
> > #3/4 bpf_verif_scale:test_verif_scale3.o:OK
> > #3/5 bpf_verif_scale:pyperf50.o:OK
> > #3/6 bpf_verif_scale:pyperf100.o:OK
> > #3/7 bpf_verif_scale:pyperf180.o:OK
> > #3/8 bpf_verif_scale:pyperf600.o:OK
> > #3/9 bpf_verif_scale:pyperf600_nounroll.o:OK
> > #3/10 bpf_verif_scale:loop1.o:OK
> > #3/11 bpf_verif_scale:loop2.o:OK
> > #3/12 bpf_verif_scale:loop4.o:OK
> > #3/13 bpf_verif_scale:loop5.o:OK
> > #3/14 bpf_verif_scale:strobemeta.o:OK
> > #3/15 bpf_verif_scale:strobemeta_nounroll1.o:OK
> > #3/16 bpf_verif_scale:strobemeta_nounroll2.o:OK
> > #3/17 bpf_verif_scale:test_sysctl_loop1.o:OK
> > #3/18 bpf_verif_scale:test_sysctl_loop2.o:OK
> > #3/19 bpf_verif_scale:test_xdp_loop.o:OK
> > #3/20 bpf_verif_scale:test_seg6_loop.o:OK
> > #3 bpf_verif_scale:OK
> > #4 flow_dissector:OK
> >
> > After:
> > # 1 FAIL attach_probe
> > # 2 OK bpf_obj_id
> > # 3/1 OK bpf_verif_scale:loop3.o
> > # 3/2 OK bpf_verif_scale:test_verif_scale1.o
> > # 3/3 OK bpf_verif_scale:test_verif_scale2.o
> > # 3/4 OK bpf_verif_scale:test_verif_scale3.o
> > # 3/5 OK bpf_verif_scale:pyperf50.o
> > # 3/6 OK bpf_verif_scale:pyperf100.o
> > # 3/7 OK bpf_verif_scale:pyperf180.o
> > # 3/8 OK bpf_verif_scale:pyperf600.o
> > # 3/9 OK bpf_verif_scale:pyperf600_nounroll.o
> > # 3/10 OK bpf_verif_scale:loop1.o
> > # 3/11 OK bpf_verif_scale:loop2.o
> > # 3/12 OK bpf_verif_scale:loop4.o
> > # 3/13 OK bpf_verif_scale:loop5.o
> > # 3/14 OK bpf_verif_scale:strobemeta.o
> > # 3/15 OK bpf_verif_scale:strobemeta_nounroll1.o
> > # 3/16 OK bpf_verif_scale:strobemeta_nounroll2.o
> > # 3/17 OK bpf_verif_scale:test_sysctl_loop1.o
> > # 3/18 OK bpf_verif_scale:test_sysctl_loop2.o
> > # 3/19 OK bpf_verif_scale:test_xdp_loop.o
> > # 3/20 OK bpf_verif_scale:test_seg6_loop.o
> > # 3 OK bpf_verif_scale
> > # 4 OK flow_dissector
>
> sorry this is nack.
> I prefer consistency with test_verifier output.
No problem, let me know how you feel about the other patches
in the series, can drop this one.
next prev parent reply other threads:[~2019-08-14 17:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 16:47 [PATCH bpf-next 0/4] selftests/bpf: test_progs: misc fixes Stanislav Fomichev
2019-08-14 16:47 ` [PATCH bpf-next 1/4] selftests/bpf: test_progs: change formatting of the condenced output Stanislav Fomichev
2019-08-14 17:00 ` Alexei Starovoitov
2019-08-14 17:07 ` Stanislav Fomichev [this message]
2019-08-14 16:47 ` [PATCH bpf-next 2/4] selftests/bpf: test_progs: test__skip Stanislav Fomichev
2019-08-14 19:22 ` Andrii Nakryiko
2019-08-14 19:30 ` Andrii Nakryiko
2019-08-14 19:53 ` Stanislav Fomichev
2019-08-14 20:01 ` Andrii Nakryiko
2019-08-16 5:16 ` Alexei Starovoitov
2019-08-16 5:23 ` Andrii Nakryiko
2019-08-14 16:47 ` [PATCH bpf-next 3/4] selftests/bpf: test_progs: remove global fail/success counts Stanislav Fomichev
2019-08-14 19:47 ` Andrii Nakryiko
2019-08-14 20:07 ` Stanislav Fomichev
2019-08-14 20:22 ` Andrii Nakryiko
2019-08-14 16:47 ` [PATCH bpf-next 4/4] selftests/bpf: test_progs: remove asserts from subtests Stanislav Fomichev
2019-08-14 19:52 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814170748.GK2820@mini-arch \
--to=sdf@fomichev.me \
--cc=alexei.starovoitov@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).