From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Andrii Nakryiko <andriin@fb.com>, bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Stanislav Fomichev <sdf@google.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v2 bpf-next] bpftool: fix bpftool build by switching to bpf_object__open_file()
Date: Mon, 7 Oct 2019 19:50:01 -0700 [thread overview]
Message-ID: <20191007195001.4cb47f99@cakuba.netronome.com> (raw)
In-Reply-To: <CAADnVQJne3UYsuuyzTMrCB5LS2d+=--mJ1uRod=JVBcozuuDzg@mail.gmail.com>
On Mon, 7 Oct 2019 19:38:15 -0700, Alexei Starovoitov wrote:
> On Mon, Oct 7, 2019 at 7:23 PM Jakub Kicinski wrote:
> > On Mon, 7 Oct 2019 19:16:45 -0700, Alexei Starovoitov wrote:
> > > On Mon, Oct 7, 2019 at 7:00 PM Jakub Kicinski wrote:
> > > > On Mon, 7 Oct 2019 15:56:04 -0700, Andrii Nakryiko wrote:
> > > > > diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c
> > > > > index 43fdbbfe41bb..27da96a797ab 100644
> > > > > --- a/tools/bpf/bpftool/prog.c
> > > > > +++ b/tools/bpf/bpftool/prog.c
> > > > > @@ -1092,9 +1092,7 @@ static int do_run(int argc, char **argv)
> > > > > static int load_with_options(int argc, char **argv, bool first_prog_only)
> > > > > {
> > > > > struct bpf_object_load_attr load_attr = { 0 };
> > > > > - struct bpf_object_open_attr open_attr = {
> > > > > - .prog_type = BPF_PROG_TYPE_UNSPEC,
> > > > > - };
> > > > > + enum bpf_prog_type common_prog_type = BPF_PROG_TYPE_UNSPEC;
> > > > > enum bpf_attach_type expected_attach_type;
> > > > > struct map_replace *map_replace = NULL;
> > > > > struct bpf_program *prog = NULL, *pos;
> > > >
> > > > Please maintain reverse xmas tree..
> > >
> > > There are exceptions. I don't think it's worth doing everywhere.
> >
> > Rule #0 stick to the existing code style.
> >
> > "Previous line of code declaring this variable in a different way was
> > in this place" is a really weak argument and the only one which can be
> > made here...
>
> do you seriously think that arguing about xmas tree is a good
> spend of yours and my time?!
Hahaha I really don't, I was about to say. I'm just registering my
disgruntlement :) I can't stay silent when I see hasty submissions
that make the code of which I'm the original author deteriorate.
I hope that's understandable.
prev parent reply other threads:[~2019-10-08 2:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 22:56 [PATCH v2 bpf-next] bpftool: fix bpftool build by switching to bpf_object__open_file() Andrii Nakryiko
2019-10-08 1:45 ` Alexei Starovoitov
2019-10-08 1:59 ` Jakub Kicinski
2019-10-08 2:16 ` Alexei Starovoitov
2019-10-08 2:23 ` Jakub Kicinski
2019-10-08 2:38 ` Alexei Starovoitov
2019-10-08 2:50 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007195001.4cb47f99@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).