From: David Miller <davem@davemloft.net>
To: ben.dooks@codethink.co.uk
Cc: daniel@iogearbox.net, linux-kernel@lists.codethink.co.uk,
ast@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
jakub.kicinski@netronome.com, hawk@kernel.org,
john.fastabend@gmail.com, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: bpf: add static in net/core/filter.c
Date: Wed, 16 Oct 2019 13:44:11 -0400 (EDT) [thread overview]
Message-ID: <20191016.134411.315258296003464370.davem@davemloft.net> (raw)
In-Reply-To: <e3e81678-6c58-191b-3514-629f5f94def2@codethink.co.uk>
From: Ben Dooks <ben.dooks@codethink.co.uk>
Date: Wed, 16 Oct 2019 14:11:52 +0100
> Hmm, your config it does, I get /none/ of these warnings.
>
> I guess a lot of this is being built whether or not is then used.
When you are making changes like this, unless you have done a full grep
over the tree and are %100 sure it is unrefrenced you should do at
a minimum an allmodconfig build.
Otherwise by definition you are not testing the build of this change.
prev parent reply other threads:[~2019-10-16 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 11:04 [PATCH] net: bpf: add static in net/core/filter.c Ben Dooks (Codethink)
2019-10-16 12:26 ` Daniel Borkmann
2019-10-16 13:02 ` Ben Dooks
2019-10-16 13:10 ` Daniel Borkmann
2019-10-16 13:11 ` Ben Dooks
2019-10-16 13:24 ` [Linux-kernel] " Ben Dooks
2019-10-16 17:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016.134411.315258296003464370.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@kernel.org \
--cc=ben.dooks@codethink.co.uk \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hawk@kernel.org \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).