From: Steven Rostedt <rostedt@goodmis.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Alexei Starovoitov" <alexei.starovoitov@gmail.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"Andrii Nakryiko" <andriin@fb.com>,
"Quentin Monnet" <quentin.monnet@netronome.com>
Subject: Re: [RFC] btf: Some structs are doubled because of struct ring_buffer
Date: Wed, 18 Dec 2019 11:22:19 -0500 [thread overview]
Message-ID: <20191218112219.309d1031@gandalf.local.home> (raw)
In-Reply-To: <20191218161401.GC15571@krava>
On Wed, 18 Dec 2019 17:14:01 +0100
Jiri Olsa <jolsa@redhat.com> wrote:
> On Sat, Dec 14, 2019 at 12:35:10PM +0100, Jiri Olsa wrote:
> > On Fri, Dec 13, 2019 at 02:05:31PM -0500, Steven Rostedt wrote:
> >
> > SNIP
> >
> > > struct trace_array *tr = filp->private_data;
> > > - struct ring_buffer *buffer = tr->trace_buffer.buffer;
> > > + struct trace_buffer *buffer = tr->trace_buffer.buffer;
> > > unsigned long val;
> > > int ret;
> > >
> > > diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> > > index 63bf60f79398..308fcd673102 100644
> > > --- a/kernel/trace/trace.h
> > > +++ b/kernel/trace/trace.h
> > > @@ -178,7 +178,7 @@ struct trace_option_dentry;
> > >
> > > struct trace_buffer {
> > > struct trace_array *tr;
> > > - struct ring_buffer *buffer;
> > > + struct trace_buffer *buffer;
> >
> > perf change is fine, but 'trace_buffer' won't work because
> > we already have 'struct trace_buffer' defined in here
> >
> > maybe we could change this name to trace_buffer_array?
>
> ..like in patch below? it's independent of your previous changes
>
>
Actually, I would prefer to call it either trace_array_buffer, or just
array_buffer.
-- Steve
prev parent reply other threads:[~2019-12-18 16:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 15:35 [RFC] btf: Some structs are doubled because of struct ring_buffer Jiri Olsa
2019-12-13 16:25 ` Steven Rostedt
2019-12-13 16:51 ` Alexei Starovoitov
2019-12-13 17:11 ` Steven Rostedt
2019-12-13 17:30 ` Alexei Starovoitov
2019-12-13 18:28 ` Jiri Olsa
2019-12-13 18:02 ` Peter Zijlstra
2019-12-13 18:29 ` Steven Rostedt
2019-12-13 18:36 ` Jiri Olsa
2019-12-13 18:43 ` Steven Rostedt
2019-12-13 18:46 ` Peter Zijlstra
2019-12-13 19:03 ` Steven Rostedt
2019-12-13 19:05 ` Steven Rostedt
2019-12-14 11:35 ` Jiri Olsa
2019-12-18 16:14 ` Jiri Olsa
2019-12-18 16:22 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218112219.309d1031@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=quentin.monnet@netronome.com \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).