* [PATCH bpf-next] bpftool: simplify format string to not use positional args
@ 2019-12-18 21:43 Andrii Nakryiko
2019-12-18 23:27 ` [Potential Spoof] " Yonghong Song
0 siblings, 1 reply; 3+ messages in thread
From: Andrii Nakryiko @ 2019-12-18 21:43 UTC (permalink / raw)
To: bpf, netdev, ast, daniel; +Cc: andrii.nakryiko, kernel-team, Andrii Nakryiko
Change format string referring to just single argument out of two available.
Some versions of libc can reject such format string.
Reported-by: Nikita Shirokov <tehnerd@tehnerd.com>
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
---
tools/bpf/bpftool/gen.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/bpf/bpftool/gen.c b/tools/bpf/bpftool/gen.c
index 8d93c8f90f82..851c465f99dc 100644
--- a/tools/bpf/bpftool/gen.c
+++ b/tools/bpf/bpftool/gen.c
@@ -567,9 +567,9 @@ static int do_skeleton(int argc, char **argv)
return -1; \n\
} \n\
\n\
- #endif /* %2$s */ \n\
+ #endif /* %s */ \n\
",
- obj_name, header_guard);
+ header_guard);
err = 0;
out:
bpf_object__close(obj);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Potential Spoof] [PATCH bpf-next] bpftool: simplify format string to not use positional args
2019-12-18 21:43 [PATCH bpf-next] bpftool: simplify format string to not use positional args Andrii Nakryiko
@ 2019-12-18 23:27 ` Yonghong Song
2019-12-19 1:03 ` Alexei Starovoitov
0 siblings, 1 reply; 3+ messages in thread
From: Yonghong Song @ 2019-12-18 23:27 UTC (permalink / raw)
To: Andrii Nakryiko, bpf, netdev, Alexei Starovoitov, daniel
Cc: andrii.nakryiko, Kernel Team
On 12/18/19 1:43 PM, Andrii Nakryiko wrote:
> Change format string referring to just single argument out of two available.
> Some versions of libc can reject such format string.
>
> Reported-by: Nikita Shirokov <tehnerd@tehnerd.com>
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Acked-by: Yonghong Song <yhs@fb.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Potential Spoof] [PATCH bpf-next] bpftool: simplify format string to not use positional args
2019-12-18 23:27 ` [Potential Spoof] " Yonghong Song
@ 2019-12-19 1:03 ` Alexei Starovoitov
0 siblings, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2019-12-19 1:03 UTC (permalink / raw)
To: Yonghong Song
Cc: Andrii Nakryiko, bpf, netdev, Alexei Starovoitov, daniel,
andrii.nakryiko, Kernel Team
On Wed, Dec 18, 2019 at 3:28 PM Yonghong Song <yhs@fb.com> wrote:
>
>
>
> On 12/18/19 1:43 PM, Andrii Nakryiko wrote:
> > Change format string referring to just single argument out of two available.
> > Some versions of libc can reject such format string.
> >
> > Reported-by: Nikita Shirokov <tehnerd@tehnerd.com>
> > Signed-off-by: Andrii Nakryiko <andriin@fb.com>
>
> Acked-by: Yonghong Song <yhs@fb.com>
Applied. Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-19 1:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 21:43 [PATCH bpf-next] bpftool: simplify format string to not use positional args Andrii Nakryiko
2019-12-18 23:27 ` [Potential Spoof] " Yonghong Song
2019-12-19 1:03 ` Alexei Starovoitov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).