BPF Archive on lore.kernel.org
 help / color / Atom feed
From: Martin KaFai Lau <kafai@fb.com>
To: David Binderman <dcb314@hotmail.com>
Cc: "shuah@kernel.org" <shuah@kernel.org>,
	"ast@kernel.org" <ast@kernel.org>,
	"daniel@iogearbox.net" <daniel@iogearbox.net>,
	"songliubraving@fb.com" <songliubraving@fb.com>,
	"yhs@fb.com" <yhs@fb.com>, "andriin@fb.com" <andriin@fb.com>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-5.6-rc1/tools/testing/selftests/bpf/prog_tests/select_reuseport.cc :826: possible cut-n-paste error ?
Date: Mon, 10 Feb 2020 09:03:58 -0800
Message-ID: <20200210170358.a46i2nklxfcf5t54@kafai-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <DB7PR08MB3801805D869B8A37A53B98719C190@DB7PR08MB3801.eurprd08.prod.outlook.com>

On Mon, Feb 10, 2020 at 01:42:45PM +0000, David Binderman wrote:
> Hello there,
> 
>     saved_tcp_fo = read_int_sysctl(TCP_FO_SYSCTL);
>     saved_tcp_syncookie = read_int_sysctl(TCP_SYNCOOKIE_SYSCTL);
>     if (saved_tcp_syncookie < 0 || saved_tcp_syncookie < 0)
>         goto out;
> 
> Maybe better code
> 
>     saved_tcp_fo = read_int_sysctl(TCP_FO_SYSCTL);
>     saved_tcp_syncookie = read_int_sysctl(TCP_SYNCOOKIE_SYSCTL);
>     if (saved_tcp_fo < 0 || saved_tcp_syncookie < 0)
Thanks for the report.  I will post a fix.

           reply index

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <DB7PR08MB3801805D869B8A37A53B98719C190@DB7PR08MB3801.eurprd08.prod.outlook.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200210170358.a46i2nklxfcf5t54@kafai-mbp.dhcp.thefacebook.com \
    --to=kafai@fb.com \
    --cc=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=dcb314@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

BPF Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \
		bpf@vger.kernel.org
	public-inbox-index bpf

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.bpf


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git