BPF Archive on lore.kernel.org
 help / color / Atom feed
* Re: linux-5.6-rc1/tools/testing/selftests/bpf/prog_tests/select_reuseport.cc :826: possible cut-n-paste error ?
       [not found] <DB7PR08MB3801805D869B8A37A53B98719C190@DB7PR08MB3801.eurprd08.prod.outlook.com>
@ 2020-02-10 17:03 ` Martin KaFai Lau
  0 siblings, 0 replies; only message in thread
From: Martin KaFai Lau @ 2020-02-10 17:03 UTC (permalink / raw)
  To: David Binderman
  Cc: shuah, ast, daniel, songliubraving, yhs, andriin,
	linux-kselftest, netdev, bpf, Linux Kernel Mailing List

On Mon, Feb 10, 2020 at 01:42:45PM +0000, David Binderman wrote:
> Hello there,
> 
>     saved_tcp_fo = read_int_sysctl(TCP_FO_SYSCTL);
>     saved_tcp_syncookie = read_int_sysctl(TCP_SYNCOOKIE_SYSCTL);
>     if (saved_tcp_syncookie < 0 || saved_tcp_syncookie < 0)
>         goto out;
> 
> Maybe better code
> 
>     saved_tcp_fo = read_int_sysctl(TCP_FO_SYSCTL);
>     saved_tcp_syncookie = read_int_sysctl(TCP_SYNCOOKIE_SYSCTL);
>     if (saved_tcp_fo < 0 || saved_tcp_syncookie < 0)
Thanks for the report.  I will post a fix.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <DB7PR08MB3801805D869B8A37A53B98719C190@DB7PR08MB3801.eurprd08.prod.outlook.com>
2020-02-10 17:03 ` linux-5.6-rc1/tools/testing/selftests/bpf/prog_tests/select_reuseport.cc :826: possible cut-n-paste error ? Martin KaFai Lau

BPF Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \
		bpf@vger.kernel.org
	public-inbox-index bpf

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.bpf


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git