From: Song Liu <songliubraving@fb.com>
To: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>
Cc: <quentin@isovalent.com>, <kernel-team@fb.com>, <ast@kernel.org>,
<daniel@iogearbox.net>, <arnaldo.melo@gmail.com>,
<jolsa@kernel.org>, Song Liu <songliubraving@fb.com>
Subject: [PATCH v4 bpf-next 0/4] bpftool: introduce prog profile
Date: Wed, 4 Mar 2020 10:07:06 -0800 [thread overview]
Message-ID: <20200304180710.2677695-1-songliubraving@fb.com> (raw)
This set introduces bpftool prog profile command, which uses hardware
counters to profile BPF programs.
This command attaches fentry/fexit programs to a target program. These two
programs read hardware counters before and after the target program and
calculate the difference.
Changes v3 => v4:
1. Simplify err handling in profile_open_perf_events() (Quentin);
2. Remove redundant p_err() (Quentin);
3. Replace tab with space in bash-completion; (Quentin);
4. Fix typo _bpftool_get_map_names => _bpftool_get_prog_names (Quentin).
Changes v2 => v3:
1. Change order of arguments (Quentin), as:
bpftool prog profile PROG [duration DURATION] METRICs
2. Add bash-completion for bpftool prog profile (Quentin);
3. Fix build of selftests (Yonghong);
4. Better handling of bpf_map_lookup_elem() returns (Yonghong);
5. Improve clean up logic of do_profile() (Yonghong);
6. Other smaller fixes/cleanups.
Changes RFC => v2:
1. Use new bpf_program__set_attach_target() API;
2. Update output format to be perf-stat like (Alexei);
3. Incorporate skeleton generation into Makefile;
4. Make DURATION optional and Allow Ctrl-C (Alexei);
5. Add calcated values "insn per cycle" and "LLC misses per million isns".
Song Liu (4):
bpftool: introduce "prog profile" command
bpftool: Documentation for bpftool prog profile
bpftool: bash completion for "bpftool prog profile"
bpftool: fix typo in bash-completion
.../bpftool/Documentation/bpftool-prog.rst | 19 +
tools/bpf/bpftool/Makefile | 18 +
tools/bpf/bpftool/bash-completion/bpftool | 47 +-
tools/bpf/bpftool/prog.c | 425 +++++++++++++++++-
tools/bpf/bpftool/skeleton/profiler.bpf.c | 171 +++++++
tools/bpf/bpftool/skeleton/profiler.h | 47 ++
tools/scripts/Makefile.include | 1 +
7 files changed, 725 insertions(+), 3 deletions(-)
create mode 100644 tools/bpf/bpftool/skeleton/profiler.bpf.c
create mode 100644 tools/bpf/bpftool/skeleton/profiler.h
--
2.17.1
next reply other threads:[~2020-03-04 18:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 18:07 Song Liu [this message]
2020-03-04 18:07 ` [PATCH v4 bpf-next 1/4] bpftool: introduce "prog profile" command Song Liu
2020-03-04 19:21 ` Jiri Olsa
2020-03-04 21:17 ` Song Liu
2020-03-04 20:38 ` Jiri Olsa
2020-03-05 20:03 ` Song Liu
2020-03-04 18:07 ` [PATCH v4 bpf-next 2/4] bpftool: Documentation for bpftool prog profile Song Liu
2020-03-04 18:07 ` [PATCH v4 bpf-next 3/4] bpftool: bash completion for "bpftool prog profile" Song Liu
2020-03-04 18:07 ` [PATCH v4 bpf-next 4/4] bpftool: fix typo in bash-completion Song Liu
2020-03-04 19:08 ` [PATCH v4 bpf-next 0/4] bpftool: introduce prog profile Jiri Olsa
2020-03-04 20:41 ` Jiri Olsa
2020-03-04 21:16 ` Song Liu
2020-03-04 21:29 ` Jiri Olsa
2020-03-04 21:39 ` Song Liu
2020-03-05 20:03 ` Song Liu
2020-03-06 8:51 ` Jiri Olsa
2020-03-09 18:04 ` Quentin Monnet
2020-03-09 18:24 ` Song Liu
2020-03-09 19:30 ` Jiri Olsa
2020-03-04 19:13 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304180710.2677695-1-songliubraving@fb.com \
--to=songliubraving@fb.com \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).