From: Martin KaFai Lau <kafai@fb.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>, <ast@fb.com>,
<daniel@iogearbox.net>, <andrii.nakryiko@gmail.com>,
<kernel-team@fb.com>, Quentin Monnet <quentin@isovalent.com>
Subject: Re: [Potential Spoof] [PATCH bpf-next] libbpf: split BTF presence checks into libbpf- and kernel-specific parts
Date: Thu, 12 Mar 2020 12:58:27 -0700 [thread overview]
Message-ID: <20200312195827.h3xxc2gesrmiv57t@kafai-mbp> (raw)
In-Reply-To: <20200312185033.736911-1-andriin@fb.com>
On Thu, Mar 12, 2020 at 11:50:33AM -0700, Andrii Nakryiko wrote:
> Needs for application BTF being present differs between user-space libbpf needs and kernel
Nit. This line looks too long for commit message.
> needs. Currently, BTF is mandatory only in kernel only when BPF application is
> using STRUCT_OPS. While libbpf itself relies more heavily on presense of BTF:
> - for BTF-defined maps;
> - for Kconfig externs;
> - for STRUCT_OPS as well.
>
> Thus, checks for presence and validness of bpf_object's BPF needs to be
> performed separately, which is patch does.
Acked-by: Martin KaFai Lau <kafai@fb.com>
next prev parent reply other threads:[~2020-03-12 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 18:50 [PATCH bpf-next] libbpf: split BTF presence checks into libbpf- and kernel-specific parts Andrii Nakryiko
2020-03-12 19:58 ` Martin KaFai Lau [this message]
2020-03-12 23:16 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312195827.h3xxc2gesrmiv57t@kafai-mbp \
--to=kafai@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).