bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Slava Bacherikov <slava@bacher09.org>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jann Horn <jannh@google.com>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	bpf <bpf@vger.kernel.org>,
	Kernel Hardening <kernel-hardening@lists.openwall.com>
Subject: Re: CONFIG_DEBUG_INFO_BTF and CONFIG_GCC_PLUGIN_RANDSTRUCT
Date: Wed, 1 Apr 2020 00:32:28 -0700	[thread overview]
Message-ID: <202004010029.167BA4AA1F@keescook> (raw)
In-Reply-To: <8962ffa8-69b7-ab6b-3969-3029a95dfcec@bacher09.org>

On Wed, Apr 01, 2020 at 12:24:46AM +0300, Slava Bacherikov wrote:
> 31.03.2020 23:23, Andrii Nakryiko пишет:
> > On Tue, Mar 31, 2020 at 12:58 PM Kees Cook <keescook@chromium.org> wrote:
> >> Sure! That'd by fine by me. I'd just like it to be a "|| COMPILE_TEST"
> >> for GCC_PLUGIN_RANDSTRUCT. Feel free to CC me for an Ack. :)
> >>
> > 
> > +cc Slava
> > 
> > I'm unsure what COMPILE_TEST dependency (or is it anti-dependency?)
> > has to do with BTF generation and reading description in Kconfig
> > didn't clarify it for me. Can you please elaborate just a bit? Thanks!
> > 
> >> -Kees
> 
> Hi,
> 
> Regarding COMPILE_TEST, DEBUG_INFO has dependency on:
> 
> DEBUG_KERNEL && !COMPILE_TEST
> 
> And DEBUG_INFO_BTF depends on DEBUG_INFO, so enabling COMPILE_TEST
> would block DEBUG_INFO and so DEBUG_INFO_BTF as well. Unless I don't
> understand something and there is some other reason to add it.

I meant that if you're adjusting the depends for GCC_PLUGIN_RANDSTRUCT,
I'd like it to be:

	depends on COMPILE_TEST || !DEBUG_INFO

That way randconfig, all*config, etc, will still select
GCC_PLUGIN_RANDSTRUCT with everything else, regardless of DEBUG_INFO.

-- 
Kees Cook

      reply	other threads:[~2020-04-01  7:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-30 15:12 CONFIG_DEBUG_INFO_BTF and CONFIG_GCC_PLUGIN_RANDSTRUCT Jann Horn
2020-03-30 15:59 ` Alexei Starovoitov
2020-03-30 16:17   ` Jann Horn
2020-03-30 17:20     ` Kees Cook
2020-03-30 22:41       ` Daniel Borkmann
2020-03-31 18:12         ` Kees Cook
2020-03-31 19:50           ` Andrii Nakryiko
2020-03-31 19:58             ` Kees Cook
2020-03-31 20:23               ` Andrii Nakryiko
2020-03-31 21:24                 ` Slava Bacherikov
2020-04-01  7:32                   ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202004010029.167BA4AA1F@keescook \
    --to=keescook@chromium.org \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jannh@google.com \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=slava@bacher09.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).