* [PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_get_rxfh()
@ 2020-05-06 6:16 Jason Yan
2020-05-06 20:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-05-06 6:16 UTC (permalink / raw)
To: tariqt, davem, ast, daniel, kuba, hawk, john.fastabend, netdev,
linux-rdma, linux-kernel, bpf
Cc: Jason Yan
Fix the following coccicheck warning:
drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1238:5-8: Unneeded
variable: "err". Return "0" on line 1252
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
index 8a5ea2543670..216e6b2e9eed 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
@@ -1235,7 +1235,6 @@ static int mlx4_en_get_rxfh(struct net_device *dev, u32 *ring_index, u8 *key,
struct mlx4_en_priv *priv = netdev_priv(dev);
u32 n = mlx4_en_get_rxfh_indir_size(dev);
u32 i, rss_rings;
- int err = 0;
rss_rings = priv->prof->rss_rings ?: n;
rss_rings = rounddown_pow_of_two(rss_rings);
@@ -1249,7 +1248,7 @@ static int mlx4_en_get_rxfh(struct net_device *dev, u32 *ring_index, u8 *key,
memcpy(key, priv->rss_key, MLX4_EN_RSS_KEY_SIZE);
if (hfunc)
*hfunc = priv->rss_hash_fn;
- return err;
+ return 0;
}
static int mlx4_en_set_rxfh(struct net_device *dev, const u32 *ring_index,
--
2.21.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_get_rxfh()
2020-05-06 6:16 [PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_get_rxfh() Jason Yan
@ 2020-05-06 20:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-05-06 20:57 UTC (permalink / raw)
To: yanaijie
Cc: tariqt, ast, daniel, kuba, hawk, john.fastabend, netdev,
linux-rdma, linux-kernel, bpf
From: Jason Yan <yanaijie@huawei.com>
Date: Wed, 6 May 2020 14:16:30 +0800
> Fix the following coccicheck warning:
>
> drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1238:5-8: Unneeded
> variable: "err". Return "0" on line 1252
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-06 20:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06 6:16 [PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_get_rxfh() Jason Yan
2020-05-06 20:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).