* [PATCH 00/12] Rid W=1 warnings from Thunderbolt
@ 2021-01-27 11:25 Lee Jones
2021-01-27 11:25 ` [PATCH 06/12] thunderbolt: xdomain: Fix 'tb_unregister_service_driver()'s 'drv' param Lee Jones
2021-01-28 11:09 ` [PATCH 00/12] Rid W=1 warnings from Thunderbolt Mika Westerberg
0 siblings, 2 replies; 4+ messages in thread
From: Lee Jones @ 2021-01-27 11:25 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Alexei Starovoitov, Andreas Noever, bpf,
Daniel Borkmann, David S. Miller, Jakub Kicinski,
Jesper Dangaard Brouer, John Fastabend, linux-usb, Michael Jamet,
Mika Westerberg, netdev, Yehezkel Bernat
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Only 1 small set required for Thunderbolt. Pretty good!
Lee Jones (12):
thunderbolt: dma_port: Remove unused variable 'ret'
thunderbolt: cap: Fix kernel-doc formatting issue
thunderbolt: ctl: Demote non-conformant kernel-doc headers
thunderbolt: eeprom: Demote non-conformant kernel-doc headers to
standard comment blocks
thunderbolt: pa: Demote non-conformant kernel-doc headers
thunderbolt: xdomain: Fix 'tb_unregister_service_driver()'s 'drv'
param
thunderbolt: nhi: Demote some non-conformant kernel-doc headers
thunderbolt: tb: Kernel-doc function headers should document their
parameters
thunderbolt: swit: Demote a bunch of non-conformant kernel-doc headers
thunderbolt: icm: Fix a couple of formatting issues
thunderbolt: tunnel: Fix misspelling of 'receive_path'
thunderbolt: swit: Fix function name in the header
drivers/thunderbolt/cap.c | 2 +-
drivers/thunderbolt/ctl.c | 22 +++++++++++-----------
drivers/thunderbolt/dma_port.c | 5 ++---
drivers/thunderbolt/eeprom.c | 24 ++++++++++++------------
drivers/thunderbolt/icm.c | 4 ++--
drivers/thunderbolt/nhi.c | 14 +++++++-------
drivers/thunderbolt/path.c | 4 ++--
drivers/thunderbolt/switch.c | 14 +++++++-------
drivers/thunderbolt/tb.c | 12 ++++++------
drivers/thunderbolt/tunnel.c | 2 +-
drivers/thunderbolt/xdomain.c | 2 +-
11 files changed, 52 insertions(+), 53 deletions(-)
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Andreas Noever <andreas.noever@gmail.com>
Cc: bpf@vger.kernel.org
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Jesper Dangaard Brouer <hawk@kernel.org>
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: linux-usb@vger.kernel.org
Cc: Michael Jamet <michael.jamet@intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: netdev@vger.kernel.org
Cc: Yehezkel Bernat <YehezkelShB@gmail.com>
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 06/12] thunderbolt: xdomain: Fix 'tb_unregister_service_driver()'s 'drv' param
2021-01-27 11:25 [PATCH 00/12] Rid W=1 warnings from Thunderbolt Lee Jones
@ 2021-01-27 11:25 ` Lee Jones
2021-01-28 11:09 ` [PATCH 00/12] Rid W=1 warnings from Thunderbolt Mika Westerberg
1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2021-01-27 11:25 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Andreas Noever, Michael Jamet, Mika Westerberg,
Yehezkel Bernat, Alexei Starovoitov, Daniel Borkmann,
David S. Miller, Jakub Kicinski, Jesper Dangaard Brouer,
John Fastabend, linux-usb, netdev, bpf
Fixes the following W=1 kernel build warning(s):
drivers/thunderbolt/xdomain.c:678: warning: Function parameter or member 'drv' not described in 'tb_unregister_service_driver'
drivers/thunderbolt/xdomain.c:678: warning: Excess function parameter 'xdrv' description in 'tb_unregister_service_driver'
Cc: Andreas Noever <andreas.noever@gmail.com>
Cc: Michael Jamet <michael.jamet@intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Yehezkel Bernat <YehezkelShB@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Jesper Dangaard Brouer <hawk@kernel.org>
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: linux-usb@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: bpf@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/thunderbolt/xdomain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c
index f2d4db1cd84d0..6e8bea6a7d392 100644
--- a/drivers/thunderbolt/xdomain.c
+++ b/drivers/thunderbolt/xdomain.c
@@ -670,7 +670,7 @@ EXPORT_SYMBOL_GPL(tb_register_service_driver);
/**
* tb_unregister_service_driver() - Unregister XDomain service driver
- * @xdrv: Driver to unregister
+ * @drv: Driver to unregister
*
* Unregisters XDomain service driver from the bus.
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 00/12] Rid W=1 warnings from Thunderbolt
2021-01-27 11:25 [PATCH 00/12] Rid W=1 warnings from Thunderbolt Lee Jones
2021-01-27 11:25 ` [PATCH 06/12] thunderbolt: xdomain: Fix 'tb_unregister_service_driver()'s 'drv' param Lee Jones
@ 2021-01-28 11:09 ` Mika Westerberg
2021-01-28 13:16 ` Lee Jones
1 sibling, 1 reply; 4+ messages in thread
From: Mika Westerberg @ 2021-01-28 11:09 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Alexei Starovoitov, Andreas Noever, bpf,
Daniel Borkmann, David S. Miller, Jakub Kicinski,
Jesper Dangaard Brouer, John Fastabend, linux-usb, Michael Jamet,
netdev, Yehezkel Bernat
Hi Lee,
On Wed, Jan 27, 2021 at 11:25:42AM +0000, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Only 1 small set required for Thunderbolt. Pretty good!
>
> Lee Jones (12):
> thunderbolt: dma_port: Remove unused variable 'ret'
> thunderbolt: cap: Fix kernel-doc formatting issue
> thunderbolt: ctl: Demote non-conformant kernel-doc headers
> thunderbolt: eeprom: Demote non-conformant kernel-doc headers to
> standard comment blocks
> thunderbolt: pa: Demote non-conformant kernel-doc headers
> thunderbolt: xdomain: Fix 'tb_unregister_service_driver()'s 'drv'
> param
> thunderbolt: nhi: Demote some non-conformant kernel-doc headers
> thunderbolt: tb: Kernel-doc function headers should document their
> parameters
> thunderbolt: swit: Demote a bunch of non-conformant kernel-doc headers
> thunderbolt: icm: Fix a couple of formatting issues
> thunderbolt: tunnel: Fix misspelling of 'receive_path'
> thunderbolt: swit: Fix function name in the header
I applied all of the changes that touch static functions. For non-static
functions I will send a patch set shortly that adds the missing bits for
the kernel-doc descriptions. I also fixed $subject lines of few patches
("switch:" instead of "swit:").
Please check that I got everything correct in
git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git next
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 00/12] Rid W=1 warnings from Thunderbolt
2021-01-28 11:09 ` [PATCH 00/12] Rid W=1 warnings from Thunderbolt Mika Westerberg
@ 2021-01-28 13:16 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2021-01-28 13:16 UTC (permalink / raw)
To: Mika Westerberg
Cc: linux-kernel, Alexei Starovoitov, Andreas Noever, bpf,
Daniel Borkmann, David S. Miller, Jakub Kicinski,
Jesper Dangaard Brouer, John Fastabend, linux-usb, Michael Jamet,
netdev, Yehezkel Bernat
On Thu, 28 Jan 2021, Mika Westerberg wrote:
> Hi Lee,
>
> On Wed, Jan 27, 2021 at 11:25:42AM +0000, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Only 1 small set required for Thunderbolt. Pretty good!
> >
> > Lee Jones (12):
> > thunderbolt: dma_port: Remove unused variable 'ret'
> > thunderbolt: cap: Fix kernel-doc formatting issue
> > thunderbolt: ctl: Demote non-conformant kernel-doc headers
> > thunderbolt: eeprom: Demote non-conformant kernel-doc headers to
> > standard comment blocks
> > thunderbolt: pa: Demote non-conformant kernel-doc headers
> > thunderbolt: xdomain: Fix 'tb_unregister_service_driver()'s 'drv'
> > param
> > thunderbolt: nhi: Demote some non-conformant kernel-doc headers
> > thunderbolt: tb: Kernel-doc function headers should document their
> > parameters
> > thunderbolt: swit: Demote a bunch of non-conformant kernel-doc headers
> > thunderbolt: icm: Fix a couple of formatting issues
> > thunderbolt: tunnel: Fix misspelling of 'receive_path'
> > thunderbolt: swit: Fix function name in the header
>
> I applied all of the changes that touch static functions. For non-static
> functions I will send a patch set shortly that adds the missing bits for
> the kernel-doc descriptions. I also fixed $subject lines of few patches
> ("switch:" instead of "swit:").
Oh, that's odd. This must be a bug in my script.
As I strip [ch], as in *.c and *.h.
Thanks for noticing.
> Please check that I got everything correct in
>
> git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git next
>
> Thanks!
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-28 13:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-27 11:25 [PATCH 00/12] Rid W=1 warnings from Thunderbolt Lee Jones
2021-01-27 11:25 ` [PATCH 06/12] thunderbolt: xdomain: Fix 'tb_unregister_service_driver()'s 'drv' param Lee Jones
2021-01-28 11:09 ` [PATCH 00/12] Rid W=1 warnings from Thunderbolt Mika Westerberg
2021-01-28 13:16 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).