* [PATCH] kallsyms: make arch_get_kallsym static
@ 2021-02-25 7:08 Jiapeng Chong
2021-02-25 16:56 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-02-25 7:08 UTC (permalink / raw)
To: ast
Cc: daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh, linux-kernel, netdev, bpf, Jiapeng Chong
Fix the following sparse warning:
kernel/kallsyms.c:457:12: warning: symbol 'arch_get_kallsym' was not
declared. Should it be static?
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
kernel/kallsyms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c
index 8043a90..a26f98e 100644
--- a/kernel/kallsyms.c
+++ b/kernel/kallsyms.c
@@ -454,7 +454,7 @@ struct kallsym_iter {
int show_value;
};
-int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
+static int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
char *type, char *name)
{
return -EINVAL;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kallsyms: make arch_get_kallsym static
2021-02-25 7:08 [PATCH] kallsyms: make arch_get_kallsym static Jiapeng Chong
@ 2021-02-25 16:56 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2021-02-25 16:56 UTC (permalink / raw)
To: Jiapeng Chong
Cc: ast, daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh, linux-kernel, netdev, bpf
On Thu, Feb 25, 2021 at 03:08:37PM +0800, Jiapeng Chong wrote:
> Fix the following sparse warning:
>
> kernel/kallsyms.c:457:12: warning: symbol 'arch_get_kallsym' was not
> declared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Please just remove the function entirely.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-25 16:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 7:08 [PATCH] kallsyms: make arch_get_kallsym static Jiapeng Chong
2021-02-25 16:56 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).