* [PATCH] selftests/bpf: fix potential unreleased lock
@ 2021-08-27 7:41 Chengfeng Ye
0 siblings, 0 replies; only message in thread
From: Chengfeng Ye @ 2021-08-27 7:41 UTC (permalink / raw)
To: ast, daniel, kafai
Cc: andrii, songliubraving, yhs, john.fastabend, kpsingh, netdev,
bpf, linux-kselftest, Chengfeng Ye
This lock is not released if the program
return at the patched branch.
Cc: cyeaa@connect.ust.hk
Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
---
tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c b/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
index ec281b0363b8..86f97681ad89 100644
--- a/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
+++ b/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
@@ -195,8 +195,10 @@ static void run_test(int cgroup_fd)
pthread_mutex_lock(&server_started_mtx);
if (CHECK_FAIL(pthread_create(&tid, NULL, server_thread,
- (void *)&server_fd)))
+ (void *)&server_fd))) {
+ pthread_mutex_unlock(&server_started_mtx);
goto close_server_fd;
+ }
pthread_cond_wait(&server_started, &server_started_mtx);
pthread_mutex_unlock(&server_started_mtx);
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-08-27 7:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 7:41 [PATCH] selftests/bpf: fix potential unreleased lock Chengfeng Ye
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).