* Re: Re: [PATCH] sfc: Check null pointer of rx_queue->page_ring
@ 2021-12-20 14:51 Jiasheng Jiang
0 siblings, 0 replies; only message in thread
From: Jiasheng Jiang @ 2021-12-20 14:51 UTC (permalink / raw)
To: ecree.xilinx, habetsm.xilinx, davem, kuba, ast, daniel, hawk,
john.fastabend
Cc: netdev, linux-kernel, bpf, Jiasheng Jiang
On Mon, Dec 20, 2021 at 10:16:28PM +0800, Greg KH wrote:
> Why not return an error?
Because I have received the mail from Martin Habets that telling me
it doesn't need to return error code.
Here is the mail.
https://lore.kernel.org/lkml/20211219092948.t2iprptmyfrzgthb@gmail.com/
On Sun, Dec 19, 2021 at 05:29:48PM +0800, Martin Habets wrote:
> Your predicate is wrong. The code that uses rx_queue->page_ring
> can deal with it being NULL.
> The only thing you might want to do is set rx_queue->page_ptr_mask
> to 0.
Jiasheng
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-12-20 14:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 14:51 Re: [PATCH] sfc: Check null pointer of rx_queue->page_ring Jiasheng Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).