bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RFC v2 0/3] remove remaining users of SHA-1
@ 2022-01-14 14:20 Jason A. Donenfeld
  2022-01-14 14:20 ` [PATCH RFC v2 1/3] bpf: move from sha1 to blake2s in tag calculation Jason A. Donenfeld
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Jason A. Donenfeld @ 2022-01-14 14:20 UTC (permalink / raw)
  To: linux-kernel, netdev, bpf, linux-crypto
  Cc: Jason A. Donenfeld, Alexei Starovoitov, Andy Lutomirski,
	Ard Biesheuvel, Erik Kline, Fernando Gont, Geert Uytterhoeven,
	Hannes Frederic Sowa, Herbert Xu, Jean-Philippe Aumasson,
	Lorenzo Colitti

Hi,

There are currently two remaining users of SHA-1 left in the kernel: bpf
tag generation, and ipv6 address calculation. In an effort to reduce
code size and rid ourselves of insecure primitives, this RFC patchset
moves to using the more secure BLAKE2s function. I wanted to get your
feedback on how feasible this patchset is, and if there is some
remaining attachment to SHA-1, why exactly, and what could be done to
mitigate it. Rather than sending a mailing list post just asking, "what
do you think?" I figured it'd be easier to send this as an RFC patchset,
so you see specifically what I mean.

Version 2 makes the ipv6 handling a bit cleaner and fixes a build
warning from the last commit. Since this is just an RFC-for-discussion,
there's not technically a need to be sending this, but from the looks of
it, a real solution here might involve a bit more heavy lifting, so I
wanted to at least get my latest on the list in case others want to play
around with solutions in this space too. Also, the original recipient
list was too narrow, so this v2 expands that a bit.

Thoughts? Comments?

Thanks,
Jason

Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Erik Kline <ek@google.com>
Cc: Fernando Gont <fgont@si6networks.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Jean-Philippe Aumasson <jeanphilippe.aumasson@gmail.com>
Cc: Lorenzo Colitti <lorenzo@google.com>

Jason A. Donenfeld (3):
  bpf: move from sha1 to blake2s in tag calculation
  ipv6: move from sha1 to blake2s in address calculation
  crypto: sha1_generic - import lib/sha1.c locally

 crypto/sha1_generic.c | 182 +++++++++++++++++++++++++++++++++++++
 include/crypto/sha1.h |  10 ---
 kernel/bpf/core.c     |  39 +-------
 lib/Makefile          |   2 +-
 lib/sha1.c            | 204 ------------------------------------------
 net/ipv6/addrconf.c   |  56 +++---------
 6 files changed, 201 insertions(+), 292 deletions(-)
 delete mode 100644 lib/sha1.c

-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-01-14 16:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-14 14:20 [PATCH RFC v2 0/3] remove remaining users of SHA-1 Jason A. Donenfeld
2022-01-14 14:20 ` [PATCH RFC v2 1/3] bpf: move from sha1 to blake2s in tag calculation Jason A. Donenfeld
2022-01-14 16:20   ` Alexei Starovoitov
2022-01-14 16:33     ` Jason A. Donenfeld
2022-01-14 14:20 ` [PATCH RFC v2 2/3] ipv6: move from sha1 to blake2s in address calculation Jason A. Donenfeld
2022-01-14 14:20 ` [PATCH RFC v2 3/3] crypto: sha1_generic - import lib/sha1.c locally Jason A. Donenfeld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).