* [PATCH] net/netfilter: use memset avoid infoleaks
@ 2022-03-01 8:18 cgel.zte
2022-03-01 9:38 ` Florian Westphal
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-03-01 8:18 UTC (permalink / raw)
To: pablo
Cc: kadlec, fw, davem, kuba, ast, daniel, andrii, kafai,
songliubraving, yhs, john.fastabend, kpsingh, netfilter-devel,
coreteam, netdev, bpf, linux-kernel, Minghao Chi, Zeal Robot
From: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
Use memset to initialize structs to preventing infoleaks
in __bpf_mt_check_bytecode
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
---
net/netfilter/xt_bpf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/netfilter/xt_bpf.c b/net/netfilter/xt_bpf.c
index 849ac552a154..5750a68a2a3f 100644
--- a/net/netfilter/xt_bpf.c
+++ b/net/netfilter/xt_bpf.c
@@ -29,6 +29,7 @@ static int __bpf_mt_check_bytecode(struct sock_filter *insns, __u16 len,
if (len > XT_BPF_MAX_NUM_INSTR)
return -EINVAL;
+ memset(&program, 0x0, sizeof(program));
program.len = len;
program.filter = insns;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/netfilter: use memset avoid infoleaks
2022-03-01 8:18 [PATCH] net/netfilter: use memset avoid infoleaks cgel.zte
@ 2022-03-01 9:38 ` Florian Westphal
0 siblings, 0 replies; 2+ messages in thread
From: Florian Westphal @ 2022-03-01 9:38 UTC (permalink / raw)
To: cgel.zte
Cc: pablo, kadlec, fw, davem, kuba, ast, daniel, andrii, kafai,
songliubraving, yhs, john.fastabend, kpsingh, netfilter-devel,
coreteam, netdev, bpf, linux-kernel, Minghao Chi, Zeal Robot
cgel.zte@gmail.com <cgel.zte@gmail.com> wrote:
> From: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
>
> Use memset to initialize structs to preventing infoleaks
> in __bpf_mt_check_bytecode
What infoleak, care to elaborate? I don't see where this gets
returned to userspace, its on-stack struct?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-01 9:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-01 8:18 [PATCH] net/netfilter: use memset avoid infoleaks cgel.zte
2022-03-01 9:38 ` Florian Westphal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).