* [PATCH bpf-next] selftests/bpf: Fix return value checks in perf_event_stackmap.c
@ 2022-04-07 15:38 Yuntao Wang
2022-04-07 19:23 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Yuntao Wang @ 2022-04-07 15:38 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko
Cc: Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Shuah Khan, Hengqi Chen, netdev, bpf, linux-kernel,
linux-kselftest, Yuntao Wang
The bpf_get_stackid() function may also return 0 on success.
Signed-off-by: Yuntao Wang <ytcoode@gmail.com>
---
tools/testing/selftests/bpf/progs/perf_event_stackmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/progs/perf_event_stackmap.c b/tools/testing/selftests/bpf/progs/perf_event_stackmap.c
index b3fcb5274ee0..f793280a3238 100644
--- a/tools/testing/selftests/bpf/progs/perf_event_stackmap.c
+++ b/tools/testing/selftests/bpf/progs/perf_event_stackmap.c
@@ -35,10 +35,10 @@ int oncpu(void *ctx)
long val;
val = bpf_get_stackid(ctx, &stackmap, 0);
- if (val > 0)
+ if (val >= 0)
stackid_kernel = 2;
val = bpf_get_stackid(ctx, &stackmap, BPF_F_USER_STACK);
- if (val > 0)
+ if (val >= 0)
stackid_user = 2;
trace = bpf_map_lookup_elem(&stackdata_map, &key);
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] selftests/bpf: Fix return value checks in perf_event_stackmap.c
2022-04-07 15:38 [PATCH bpf-next] selftests/bpf: Fix return value checks in perf_event_stackmap.c Yuntao Wang
@ 2022-04-07 19:23 ` Shuah Khan
2022-04-08 4:14 ` [PATCH bpf-next v2] " Yuntao Wang
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2022-04-07 19:23 UTC (permalink / raw)
To: Yuntao Wang, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko
Cc: Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Shuah Khan, Hengqi Chen, netdev, bpf, linux-kernel,
linux-kselftest, Shuah Khan
On 4/7/22 9:38 AM, Yuntao Wang wrote:
> The bpf_get_stackid() function may also return 0 on success.
Can you add couple of sentences to describe what this patch
does? bpf_get_stackid() may also return doesn't really say
anything about why this patch is needed.
>
> Signed-off-by: Yuntao Wang <ytcoode@gmail.com>
> ---
> tools/testing/selftests/bpf/progs/perf_event_stackmap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/perf_event_stackmap.c b/tools/testing/selftests/bpf/progs/perf_event_stackmap.c
> index b3fcb5274ee0..f793280a3238 100644
> --- a/tools/testing/selftests/bpf/progs/perf_event_stackmap.c
> +++ b/tools/testing/selftests/bpf/progs/perf_event_stackmap.c
> @@ -35,10 +35,10 @@ int oncpu(void *ctx)
> long val;
>
> val = bpf_get_stackid(ctx, &stackmap, 0);
> - if (val > 0)
> + if (val >= 0)
> stackid_kernel = 2;
> val = bpf_get_stackid(ctx, &stackmap, BPF_F_USER_STACK);
> - if (val > 0)
> + if (val >= 0)
> stackid_user = 2;
>
> trace = bpf_map_lookup_elem(&stackdata_map, &key);
>
Linux 5.18-rc1 shows a couple of more bpf_get_stackid() in this function.
Removed in bpf-next - I assume.
The change is good. I would like to see it explained better in the
commit log.
With the commit log fixed to explain why this change is needed and
what happens if val equals to 0 condition isn't checked:
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH bpf-next v2] selftests/bpf: Fix return value checks in perf_event_stackmap.c
2022-04-07 19:23 ` Shuah Khan
@ 2022-04-08 4:14 ` Yuntao Wang
2022-04-08 21:09 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 4+ messages in thread
From: Yuntao Wang @ 2022-04-08 4:14 UTC (permalink / raw)
To: skhan
Cc: andrii, ast, bpf, daniel, hengqi.chen, john.fastabend, kafai,
kpsingh, linux-kernel, linux-kselftest, netdev, shuah,
songliubraving, yhs, ytcoode
The bpf_get_stackid() function may also return 0 on success.
Correct checks from 'val > 0' to 'val >= 0' to ensure that they cover all
possible success return values.
Signed-off-by: Yuntao Wang <ytcoode@gmail.com>
---
v1 -> v2: update commit message
tools/testing/selftests/bpf/progs/perf_event_stackmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/progs/perf_event_stackmap.c b/tools/testing/selftests/bpf/progs/perf_event_stackmap.c
index b3fcb5274ee0..f793280a3238 100644
--- a/tools/testing/selftests/bpf/progs/perf_event_stackmap.c
+++ b/tools/testing/selftests/bpf/progs/perf_event_stackmap.c
@@ -35,10 +35,10 @@ int oncpu(void *ctx)
long val;
val = bpf_get_stackid(ctx, &stackmap, 0);
- if (val > 0)
+ if (val >= 0)
stackid_kernel = 2;
val = bpf_get_stackid(ctx, &stackmap, BPF_F_USER_STACK);
- if (val > 0)
+ if (val >= 0)
stackid_user = 2;
trace = bpf_map_lookup_elem(&stackdata_map, &key);
--
2.35.0.rc2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next v2] selftests/bpf: Fix return value checks in perf_event_stackmap.c
2022-04-08 4:14 ` [PATCH bpf-next v2] " Yuntao Wang
@ 2022-04-08 21:09 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-04-08 21:09 UTC (permalink / raw)
To: Yuntao Wang
Cc: skhan, andrii, ast, bpf, daniel, hengqi.chen, john.fastabend,
kafai, kpsingh, linux-kernel, linux-kselftest, netdev, shuah,
songliubraving, yhs
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Fri, 8 Apr 2022 12:14:52 +0800 you wrote:
> The bpf_get_stackid() function may also return 0 on success.
>
> Correct checks from 'val > 0' to 'val >= 0' to ensure that they cover all
> possible success return values.
>
> Signed-off-by: Yuntao Wang <ytcoode@gmail.com>
>
> [...]
Here is the summary with links:
- [bpf-next,v2] selftests/bpf: Fix return value checks in perf_event_stackmap.c
https://git.kernel.org/bpf/bpf-next/c/658d87687cd5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-08 21:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 15:38 [PATCH bpf-next] selftests/bpf: Fix return value checks in perf_event_stackmap.c Yuntao Wang
2022-04-07 19:23 ` Shuah Khan
2022-04-08 4:14 ` [PATCH bpf-next v2] " Yuntao Wang
2022-04-08 21:09 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).