* [PATCH] nfp: bpf: offload: Check prog before dereference
@ 2023-10-18 14:52 Artem Chernyshev
2023-10-18 15:17 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Artem Chernyshev @ 2023-10-18 14:52 UTC (permalink / raw)
To: Louis Peens
Cc: Artem Chernyshev, Jakub Kicinski, David S . Miller, Eric Dumazet,
Paolo Abeni, bpf, oss-drivers, netdev, linux-kernel, lvc-project
In nfp_net_bpf_offload() it is possible to dereference a
NULL pointer.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
---
drivers/net/ethernet/netronome/nfp/bpf/offload.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/bpf/offload.c b/drivers/net/ethernet/netronome/nfp/bpf/offload.c
index 9d97cd281f18..925862f7b7d6 100644
--- a/drivers/net/ethernet/netronome/nfp/bpf/offload.c
+++ b/drivers/net/ethernet/netronome/nfp/bpf/offload.c
@@ -598,8 +598,7 @@ int nfp_net_bpf_offload(struct nfp_net *nn, struct bpf_prog *prog,
if (old_prog && !prog)
return nfp_net_bpf_stop(nn);
- err = nfp_net_bpf_load(nn, prog, extack);
- if (err)
+ if (prog && (err = nfp_net_bpf_load(nn, prog, extack)))
return err;
if (!old_prog)
--
2.37.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfp: bpf: offload: Check prog before dereference
2023-10-18 14:52 [PATCH] nfp: bpf: offload: Check prog before dereference Artem Chernyshev
@ 2023-10-18 15:17 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2023-10-18 15:17 UTC (permalink / raw)
To: Artem Chernyshev
Cc: Louis Peens, David S . Miller, Eric Dumazet, Paolo Abeni, bpf,
oss-drivers, netdev, linux-kernel, lvc-project
On Wed, 18 Oct 2023 17:52:44 +0300 Artem Chernyshev wrote:
> In nfp_net_bpf_offload() it is possible to dereference a
> NULL pointer.
And who would call this function with prog = NULL if old_prog
is also NULL, exactly?
--
pw-bot: cr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-18 15:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-18 14:52 [PATCH] nfp: bpf: offload: Check prog before dereference Artem Chernyshev
2023-10-18 15:17 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).