bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* build failure (BTFIDS) with CONFIG_NET && !CONFIG_INET
@ 2020-09-29 10:17 Michal Kubecek
  2020-09-30  4:57 ` Yonghong Song
  0 siblings, 1 reply; 2+ messages in thread
From: Michal Kubecek @ 2020-09-29 10:17 UTC (permalink / raw)
  To: bpf; +Cc: netdev, linux-kernel, Yonghong Song

Hello,

our builds of s390x for zfcpdump fail since 5.9-rc1 with

    BTFIDS  vmlinux
  FAILED unresolved symbol tcp_timewait_sock
  make[1]: *** [/home/abuild/rpmbuild/BUILD/kernel-zfcpdump-5.9.rc7/linux-5.9-rc7/Makefile:1176: vmlinux] Error 255

I believe this is caused by commit fce557bcef11 ("bpf: Make btf_sock_ids
global") and the problem is caused by a specific configuration which has
CONFIG_NET enabled but CONFIG_INET disabled. IIUC there will be no user
of struct tcp_timewait_sock but btf_ids will try to generate BTF info
for it.

Michal

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: build failure (BTFIDS) with CONFIG_NET && !CONFIG_INET
  2020-09-29 10:17 build failure (BTFIDS) with CONFIG_NET && !CONFIG_INET Michal Kubecek
@ 2020-09-30  4:57 ` Yonghong Song
  0 siblings, 0 replies; 2+ messages in thread
From: Yonghong Song @ 2020-09-30  4:57 UTC (permalink / raw)
  To: Michal Kubecek, bpf; +Cc: netdev, linux-kernel



On 9/29/20 3:17 AM, Michal Kubecek wrote:
> Hello,
> 
> our builds of s390x for zfcpdump fail since 5.9-rc1 with
> 
>      BTFIDS  vmlinux
>    FAILED unresolved symbol tcp_timewait_sock
>    make[1]: *** [/home/abuild/rpmbuild/BUILD/kernel-zfcpdump-5.9.rc7/linux-5.9-rc7/Makefile:1176: vmlinux] Error 255
> 
> I believe this is caused by commit fce557bcef11 ("bpf: Make btf_sock_ids
> global") and the problem is caused by a specific configuration which has
> CONFIG_NET enabled but CONFIG_INET disabled. IIUC there will be no user
> of struct tcp_timewait_sock but btf_ids will try to generate BTF info
> for it.

Thanks for reporting! Will send a patch to fix the issue soon.

> 
> Michal
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-30  4:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-29 10:17 build failure (BTFIDS) with CONFIG_NET && !CONFIG_INET Michal Kubecek
2020-09-30  4:57 ` Yonghong Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).