bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Song Liu <liu.song.a23@gmail.com>
Cc: bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next] selftests/bpf: do not ignore clang failures
Date: Mon, 1 Jul 2019 10:55:32 +0200	[thread overview]
Message-ID: <2EA9DD60-A922-4056-8775-3F556B9A0087@linux.ibm.com> (raw)
In-Reply-To: <CAPhsuW5ToikpcEbJjC+JsxWSjgUBHKS97=hiTmt1EHmC9HFb8Q@mail.gmail.com>

> Am 28.06.2019 um 22:35 schrieb Song Liu <liu.song.a23@gmail.com>:
> 
> On Thu, Jun 27, 2019 at 2:15 AM Ilya Leoshkevich <iii@linux.ibm.com> wrote:
>> 
>> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
>> index f2dbe2043067..2316fa2d5b3b 100644
>> --- a/tools/testing/selftests/bpf/Makefile
>> +++ b/tools/testing/selftests/bpf/Makefile
>> @@ -1,5 +1,6 @@
>> # SPDX-License-Identifier: GPL-2.0
>> 
>> +SHELL := /bin/bash
> 
> I am not sure whether it is ok to require bash. I don't see such requirements in
> other Makefile's under tools/.
> 
> Can we enable some fall back when bash is not present?
> 
> Thanks,
> Song

I think checking for bash presence would unnecessarily complicate
things.  What do you think about having separate targets for
clang-generated bitcode?

Best regards,
Ilya

  reply	other threads:[~2019-07-01  8:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27  9:14 [PATCH bpf-next] selftests/bpf: do not ignore clang failures Ilya Leoshkevich
2019-06-28 20:35 ` Song Liu
2019-07-01  8:55   ` Ilya Leoshkevich [this message]
2019-07-01 15:31     ` Andrii Nakryiko
2019-07-01 18:40       ` [PATCH v2 " Ilya Leoshkevich
2019-07-05 14:22         ` Daniel Borkmann
2019-07-08 15:01           ` Ilya Leoshkevich
2019-07-09 18:14             ` Andrii Nakryiko
2019-07-10 13:25               ` Ilya Leoshkevich
2019-07-10 16:04                 ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2EA9DD60-A922-4056-8775-3F556B9A0087@linux.ibm.com \
    --to=iii@linux.ibm.com \
    --cc=bpf@vger.kernel.org \
    --cc=liu.song.a23@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).