From: Daniel Borkmann <daniel@iogearbox.net>
To: Carlos Antonio Neira Bustos <cneirabustos@gmail.com>,
Martin KaFai Lau <kafai@fb.com>
Cc: netdev@vger.kernel.org, yhs@fb.com, quentin@isovalent.com,
ebiederm@xmission.com, brouer@redhat.com, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next] bpf_helpers_doc.py: Fix warning when compiling bpftool.
Date: Fri, 13 Mar 2020 21:13:02 +0100 [thread overview]
Message-ID: <2ac3730c-123c-df3e-0ec8-45957bbf8d8a@iogearbox.net> (raw)
In-Reply-To: <20200313182319.GA13630@bpf-dev>
On 3/13/20 7:23 PM, Carlos Antonio Neira Bustos wrote:
> On Fri, Mar 13, 2020 at 10:21:19AM -0700, Martin KaFai Lau wrote:
>> On Fri, Mar 13, 2020 at 12:46:50PM -0300, Carlos Neira wrote:
>>>
>>> When compiling bpftool the following warning is found:
>>> "declaration of 'struct bpf_pidns_info' will not be visible outside of this function."
>>> This patch adds struct bpf_pidns_info to type_fwds array to fix this.
>>>
>>> Signed-off-by: Carlos Neira <cneirabustos@gmail.com>
>> Fixes: b4490c5c4e02 ("bpf: Added new helper bpf_get_ns_current_pid_tgid")
>> Acked-by: Martin KaFai Lau <kafai@fb.com>
>>
>> Please add the Fixes tag next time. Other than tracking,
>> it will be easier for review purpose also.
>
> Thanks, I will do that in the future.
Applied, thanks!
prev parent reply other threads:[~2020-03-13 20:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 15:46 [PATCH bpf-next] bpf_helpers_doc.py: Fix warning when compiling bpftool Carlos Neira
2020-03-13 16:20 ` Quentin Monnet
2020-03-13 17:21 ` Martin KaFai Lau
2020-03-13 18:23 ` Carlos Antonio Neira Bustos
2020-03-13 20:13 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ac3730c-123c-df3e-0ec8-45957bbf8d8a@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=cneirabustos@gmail.com \
--cc=ebiederm@xmission.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).