From: Yoshiki Komachi <komachi.yoshiki@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Martin KaFai Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
Andrii Nakryiko <andriin@fb.com>, KP Singh <kpsingh@chromium.org>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
bpf@vger.kernel.org
Subject: Re: [RFC PATCH bpf-next 2/3] bpf: Add helper to do forwarding lookups in kernel FDB table
Date: Fri, 7 Aug 2020 17:06:41 +0900 [thread overview]
Message-ID: <3B486A33-7A46-436A-A563-80F842A16F23@gmail.com> (raw)
In-Reply-To: <e92455ce-3a3f-7c52-1388-da40e8ceefd0@gmail.com>
> 2020/08/06 1:38、David Ahern <dsahern@gmail.com>のメール:
>
> On 8/4/20 5:27 AM, Yoshiki Komachi wrote:
>>
>> I guess that no build errors will occur because the API is allowed when
>> CONFIG_BRIDGE is enabled.
>>
>> I successfully build my kernel applying this patch, and I don’t receive any
>> messages from build robots for now.
>
> If CONFIG_BRIDGE is a module, build should fail: filter.c is built-in
> trying to access a symbol from module.
When I tried building my kernel with CONFIG_BRIDGE set as a module, I got
the following error as you pointed out:
ld: net/core/filter.o: in function `____bpf_xdp_fdb_lookup':
/root/bpf-next/net/core/filter.c:5108: undefined reference to `br_fdb_find_port_xdp'
It may be necessary to fix it to support kernels built with CONFIG_BRIDGE set
as a mfodule, so let me make sure if it should be called via netdev ops to get
destination port in a bridge again.
Thanks & Best regards,
—
Yoshiki Komachi
komachi.yoshiki@gmail.com
next prev parent reply other threads:[~2020-08-07 8:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 4:44 [RFC PATCH bpf-next 0/3] Add a new bpf helper for FDB lookup Yoshiki Komachi
2020-07-31 4:44 ` [RFC PATCH bpf-next 1/3] net/bridge: Add new function to access FDB from XDP programs Yoshiki Komachi
2020-07-31 4:44 ` [RFC PATCH bpf-next 2/3] bpf: Add helper to do forwarding lookups in kernel FDB table Yoshiki Komachi
2020-07-31 11:52 ` Maciej Fijalkowski
2020-08-04 8:44 ` Yoshiki Komachi
2020-07-31 17:15 ` David Ahern
2020-08-04 11:27 ` Yoshiki Komachi
2020-08-05 16:38 ` David Ahern
2020-08-07 8:06 ` Yoshiki Komachi [this message]
2020-07-31 21:12 ` Daniel Borkmann
2020-08-05 4:45 ` Yoshiki Komachi
2020-07-31 4:44 ` [RFC PATCH bpf-next 3/3] samples/bpf: Add a simple bridge example accelerated with XDP Yoshiki Komachi
2020-07-31 14:15 ` Jesper Dangaard Brouer
2020-08-04 10:08 ` Yoshiki Komachi
2020-07-31 17:48 ` Andrii Nakryiko
2020-08-04 10:35 ` Yoshiki Komachi
2020-07-31 21:52 ` [RFC PATCH bpf-next 0/3] Add a new bpf helper for FDB lookup John Fastabend
2020-08-05 10:26 ` Yoshiki Komachi
2020-08-05 16:36 ` David Ahern
2020-08-07 8:30 ` Yoshiki Komachi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B486A33-7A46-436A-A563-80F842A16F23@gmail.com \
--to=komachi.yoshiki@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).