* [PATCH bpf-next 1/2] samples/bpf: Remove duplicate option from xdpsock @ 2019-11-14 16:28 Andre Guedes 2019-11-14 16:28 ` [PATCH bpf-next 2/2] samples/bpf: Add missing option to xdpsock usage Andre Guedes 2019-11-15 22:27 ` [PATCH bpf-next 1/2] samples/bpf: Remove duplicate option from xdpsock Daniel Borkmann 0 siblings, 2 replies; 3+ messages in thread From: Andre Guedes @ 2019-11-14 16:28 UTC (permalink / raw) To: bpf; +Cc: netdev The '-f' option is shown twice in the usage(). This patch removes the outdated version. Signed-off-by: Andre Guedes <andre.guedes@intel.com> --- samples/bpf/xdpsock_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c index a1f96e55e43a..c5d0a006cafc 100644 --- a/samples/bpf/xdpsock_user.c +++ b/samples/bpf/xdpsock_user.c @@ -393,7 +393,6 @@ static void usage(const char *prog) " -n, --interval=n Specify statistics update interval (default 1 sec).\n" " -z, --zero-copy Force zero-copy mode.\n" " -c, --copy Force copy mode.\n" - " -f, --frame-size=n Set the frame size (must be a power of two, default is %d).\n" " -m, --no-need-wakeup Turn off use of driver need wakeup flag.\n" " -f, --frame-size=n Set the frame size (must be a power of two in aligned mode, default is %d).\n" " -u, --unaligned Enable unaligned chunk placement\n" -- 2.24.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH bpf-next 2/2] samples/bpf: Add missing option to xdpsock usage 2019-11-14 16:28 [PATCH bpf-next 1/2] samples/bpf: Remove duplicate option from xdpsock Andre Guedes @ 2019-11-14 16:28 ` Andre Guedes 2019-11-15 22:27 ` [PATCH bpf-next 1/2] samples/bpf: Remove duplicate option from xdpsock Daniel Borkmann 1 sibling, 0 replies; 3+ messages in thread From: Andre Guedes @ 2019-11-14 16:28 UTC (permalink / raw) To: bpf; +Cc: netdev Commit 743e568c1586 (samples/bpf: Add a "force" flag to XDP samples) introduced the '-F' option but missed adding it to the usage() and the 'long_option' array. Signed-off-by: Andre Guedes <andre.guedes@intel.com> --- samples/bpf/xdpsock_user.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c index c5d0a006cafc..a15480010828 100644 --- a/samples/bpf/xdpsock_user.c +++ b/samples/bpf/xdpsock_user.c @@ -374,6 +374,7 @@ static struct option long_options[] = { {"no-need-wakeup", no_argument, 0, 'm'}, {"unaligned", no_argument, 0, 'u'}, {"shared-umem", no_argument, 0, 'M'}, + {"force", no_argument, 0, 'F'}, {0, 0, 0, 0} }; @@ -397,6 +398,7 @@ static void usage(const char *prog) " -f, --frame-size=n Set the frame size (must be a power of two in aligned mode, default is %d).\n" " -u, --unaligned Enable unaligned chunk placement\n" " -M, --shared-umem Enable XDP_SHARED_UMEM\n" + " -F, --force Force loading the XDP prog\n" "\n"; fprintf(stderr, str, prog, XSK_UMEM__DEFAULT_FRAME_SIZE); exit(EXIT_FAILURE); -- 2.24.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next 1/2] samples/bpf: Remove duplicate option from xdpsock 2019-11-14 16:28 [PATCH bpf-next 1/2] samples/bpf: Remove duplicate option from xdpsock Andre Guedes 2019-11-14 16:28 ` [PATCH bpf-next 2/2] samples/bpf: Add missing option to xdpsock usage Andre Guedes @ 2019-11-15 22:27 ` Daniel Borkmann 1 sibling, 0 replies; 3+ messages in thread From: Daniel Borkmann @ 2019-11-15 22:27 UTC (permalink / raw) To: Andre Guedes, bpf; +Cc: netdev On 11/14/19 5:28 PM, Andre Guedes wrote: > The '-f' option is shown twice in the usage(). This patch removes the > outdated version. > > Signed-off-by: Andre Guedes <andre.guedes@intel.com> Both applied, thanks! ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-15 22:27 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-14 16:28 [PATCH bpf-next 1/2] samples/bpf: Remove duplicate option from xdpsock Andre Guedes 2019-11-14 16:28 ` [PATCH bpf-next 2/2] samples/bpf: Add missing option to xdpsock usage Andre Guedes 2019-11-15 22:27 ` [PATCH bpf-next 1/2] samples/bpf: Remove duplicate option from xdpsock Daniel Borkmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).