bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 bpf-next] scripts/pahole-flags.sh: Enable parallelization of pahole.
@ 2022-02-16 19:34 Kui-Feng Lee
  2022-02-16 20:38 ` Yonghong Song
  2022-02-17 15:22 ` Daniel Borkmann
  0 siblings, 2 replies; 3+ messages in thread
From: Kui-Feng Lee @ 2022-02-16 19:34 UTC (permalink / raw)
  To: bpf, ast, daniel, andrii; +Cc: kernel-team, Kui-Feng Lee

Pass a -j argument to pahole to parse DWARF and generate BTF with
multithreading.

v2 checks the version of pahole to apply -j only if >= v1.22.

Signed-off-by: Kui-Feng Lee <kuifeng@fb.com>
---
 scripts/pahole-flags.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/pahole-flags.sh b/scripts/pahole-flags.sh
index c293941612e7..264c05020263 100755
--- a/scripts/pahole-flags.sh
+++ b/scripts/pahole-flags.sh
@@ -16,5 +16,8 @@ fi
 if [ "${pahole_ver}" -ge "121" ]; then
 	extra_paholeopt="${extra_paholeopt} --btf_gen_floats"
 fi
+if [ "${pahole_ver}" -ge "122" ]; then
+    extra_paholeopt="${extra_paholeopt} -j"
+fi
 
 echo ${extra_paholeopt}
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 bpf-next] scripts/pahole-flags.sh: Enable parallelization of pahole.
  2022-02-16 19:34 [PATCH v2 bpf-next] scripts/pahole-flags.sh: Enable parallelization of pahole Kui-Feng Lee
@ 2022-02-16 20:38 ` Yonghong Song
  2022-02-17 15:22 ` Daniel Borkmann
  1 sibling, 0 replies; 3+ messages in thread
From: Yonghong Song @ 2022-02-16 20:38 UTC (permalink / raw)
  To: Kui-Feng Lee, bpf, ast, daniel, andrii; +Cc: kernel-team



On 2/16/22 11:34 AM, Kui-Feng Lee wrote:
> Pass a -j argument to pahole to parse DWARF and generate BTF with
> multithreading.
> 
> v2 checks the version of pahole to apply -j only if >= v1.22.
> 
> Signed-off-by: Kui-Feng Lee <kuifeng@fb.com>

Acked-by: Yonghong Song <yhs@fb.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 bpf-next] scripts/pahole-flags.sh: Enable parallelization of pahole.
  2022-02-16 19:34 [PATCH v2 bpf-next] scripts/pahole-flags.sh: Enable parallelization of pahole Kui-Feng Lee
  2022-02-16 20:38 ` Yonghong Song
@ 2022-02-17 15:22 ` Daniel Borkmann
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2022-02-17 15:22 UTC (permalink / raw)
  To: Kui-Feng Lee, bpf, ast, andrii; +Cc: kernel-team

On 2/16/22 8:34 PM, Kui-Feng Lee wrote:
> Pass a -j argument to pahole to parse DWARF and generate BTF with
> multithreading.
> 
> v2 checks the version of pahole to apply -j only if >= v1.22.
> 
> Signed-off-by: Kui-Feng Lee <kuifeng@fb.com>
> ---
>   scripts/pahole-flags.sh | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/pahole-flags.sh b/scripts/pahole-flags.sh
> index c293941612e7..264c05020263 100755
> --- a/scripts/pahole-flags.sh
> +++ b/scripts/pahole-flags.sh
> @@ -16,5 +16,8 @@ fi
>   if [ "${pahole_ver}" -ge "121" ]; then
>   	extra_paholeopt="${extra_paholeopt} --btf_gen_floats"
>   fi
> +if [ "${pahole_ver}" -ge "122" ]; then
> +    extra_paholeopt="${extra_paholeopt} -j"

Fixed up whitespace and improved commit desc while applying, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-02-17 15:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 19:34 [PATCH v2 bpf-next] scripts/pahole-flags.sh: Enable parallelization of pahole Kui-Feng Lee
2022-02-16 20:38 ` Yonghong Song
2022-02-17 15:22 ` Daniel Borkmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).