* [PATCH bpf-next] tools/bpftool: remove warning about PID iterator support
@ 2020-07-10 23:26 Andrii Nakryiko
2020-07-11 2:09 ` Yonghong Song
0 siblings, 1 reply; 3+ messages in thread
From: Andrii Nakryiko @ 2020-07-10 23:26 UTC (permalink / raw)
To: bpf, netdev, ast, daniel
Cc: andrii.nakryiko, kernel-team, Andrii Nakryiko, Andrey Ignatov
Don't emit warning that bpftool was built without PID iterator support. This
error garbles JSON output of otherwise perfectly valid show commands.
Reported-by: Andrey Ignatov <rdna@fb.com>
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
---
tools/bpf/bpftool/pids.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/bpf/bpftool/pids.c b/tools/bpf/bpftool/pids.c
index c0d23ce4a6f4..e3b116325403 100644
--- a/tools/bpf/bpftool/pids.c
+++ b/tools/bpf/bpftool/pids.c
@@ -15,7 +15,6 @@
int build_obj_refs_table(struct obj_refs_table *table, enum bpf_obj_type type)
{
- p_err("bpftool built without PID iterator support");
return -ENOTSUP;
}
void delete_obj_refs_table(struct obj_refs_table *table) {}
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH bpf-next] tools/bpftool: remove warning about PID iterator support
2020-07-10 23:26 [PATCH bpf-next] tools/bpftool: remove warning about PID iterator support Andrii Nakryiko
@ 2020-07-11 2:09 ` Yonghong Song
2020-07-13 22:43 ` Alexei Starovoitov
0 siblings, 1 reply; 3+ messages in thread
From: Yonghong Song @ 2020-07-11 2:09 UTC (permalink / raw)
To: Andrii Nakryiko, bpf, netdev, ast, daniel
Cc: andrii.nakryiko, kernel-team, Andrey Ignatov
On 7/10/20 4:26 PM, Andrii Nakryiko wrote:
> Don't emit warning that bpftool was built without PID iterator support. This
> error garbles JSON output of otherwise perfectly valid show commands.
>
> Reported-by: Andrey Ignatov <rdna@fb.com>
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Thanks for the fix.
Acked-by: Yonghong Song <yhs@fb.com>
> ---
> tools/bpf/bpftool/pids.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/bpf/bpftool/pids.c b/tools/bpf/bpftool/pids.c
> index c0d23ce4a6f4..e3b116325403 100644
> --- a/tools/bpf/bpftool/pids.c
> +++ b/tools/bpf/bpftool/pids.c
> @@ -15,7 +15,6 @@
>
> int build_obj_refs_table(struct obj_refs_table *table, enum bpf_obj_type type)
> {
> - p_err("bpftool built without PID iterator support");
> return -ENOTSUP;
> }
> void delete_obj_refs_table(struct obj_refs_table *table) {}
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH bpf-next] tools/bpftool: remove warning about PID iterator support
2020-07-11 2:09 ` Yonghong Song
@ 2020-07-13 22:43 ` Alexei Starovoitov
0 siblings, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2020-07-13 22:43 UTC (permalink / raw)
To: Yonghong Song
Cc: Andrii Nakryiko, bpf, Network Development, Alexei Starovoitov,
Daniel Borkmann, Andrii Nakryiko, Kernel Team, Andrey Ignatov
On Fri, Jul 10, 2020 at 7:10 PM Yonghong Song <yhs@fb.com> wrote:
>
>
>
> On 7/10/20 4:26 PM, Andrii Nakryiko wrote:
> > Don't emit warning that bpftool was built without PID iterator support. This
> > error garbles JSON output of otherwise perfectly valid show commands.
> >
> > Reported-by: Andrey Ignatov <rdna@fb.com>
> > Signed-off-by: Andrii Nakryiko <andriin@fb.com>
>
> Thanks for the fix.
> Acked-by: Yonghong Song <yhs@fb.com>
Applied. Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-13 22:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-10 23:26 [PATCH bpf-next] tools/bpftool: remove warning about PID iterator support Andrii Nakryiko
2020-07-11 2:09 ` Yonghong Song
2020-07-13 22:43 ` Alexei Starovoitov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).