From: Yonghong Song <yhs@fb.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>, <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next v2 05/11] bpf: add hashtab support for bpf_for_each_map_elem() helper
Date: Tue, 23 Feb 2021 10:41:02 -0800 [thread overview]
Message-ID: <4b6acd8d-8299-5881-3240-3e06539bb678@fb.com> (raw)
In-Reply-To: <20210222225619.iakpkks7htobsdlk@ast-mbp.dhcp.thefacebook.com>
On 2/22/21 2:56 PM, Alexei Starovoitov wrote:
> On Wed, Feb 17, 2021 at 10:18:08AM -0800, Yonghong Song wrote:
>> + ret = BPF_CAST_CALL(callback_fn)((u64)(long)map,
>> + (u64)(long)key, (u64)(long)val,
>> + (u64)(long)callback_ctx, 0);
>> + if (ret) {
>> + rcu_read_unlock();
>> + ret = (ret == 1) ? 0 : -EINVAL;
>> + goto out;
>
> There is a tnum(0,1) check in patch 4.
> I'm missing the purpose of this additional check.
I missed this one after I added tnum(0, 1) checking. Will fix in the
next revision.
>
>> + }
>> + }
>> + rcu_read_unlock();
>> + }
>> +out:
>> + migrate_enable();
>> + return ret ?: num_calls;
>> +}
next prev parent reply other threads:[~2021-02-23 18:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 18:18 [PATCH bpf-next v2 00/11] bpf: add bpf_for_each_map_elem() helper Yonghong Song
2021-02-17 18:18 ` [PATCH bpf-next v2 01/11] bpf: factor out visit_func_call_insn() in check_cfg() Yonghong Song
2021-02-17 18:18 ` [PATCH bpf-next v2 02/11] bpf: factor out verbose_invalid_scalar() Yonghong Song
2021-02-17 18:18 ` [PATCH bpf-next v2 03/11] bpf: refactor check_func_call() to allow callback function Yonghong Song
2021-02-17 18:18 ` [PATCH bpf-next v2 04/11] bpf: add bpf_for_each_map_elem() helper Yonghong Song
2021-02-22 20:59 ` Alexei Starovoitov
2021-02-23 18:39 ` Yonghong Song
2021-02-23 18:46 ` Alexei Starovoitov
2021-02-23 19:37 ` Yonghong Song
2021-02-17 18:18 ` [PATCH bpf-next v2 05/11] bpf: add hashtab support for " Yonghong Song
2021-02-22 22:56 ` Alexei Starovoitov
2021-02-23 18:41 ` Yonghong Song [this message]
2021-02-17 18:18 ` [PATCH bpf-next v2 06/11] bpf: add arraymap " Yonghong Song
2021-02-17 18:18 ` [PATCH bpf-next v2 07/11] libbpf: move function is_ldimm64() earlier in libbpf.c Yonghong Song
2021-02-23 8:06 ` Andrii Nakryiko
2021-02-17 18:18 ` [PATCH bpf-next v2 08/11] libbpf: support local function pointer relocation Yonghong Song
2021-02-23 8:03 ` Andrii Nakryiko
2021-02-23 18:55 ` Yonghong Song
2021-02-23 19:07 ` Alexei Starovoitov
2021-02-23 19:21 ` Andrii Nakryiko
2021-02-23 19:19 ` Andrii Nakryiko
2021-02-23 19:47 ` Yonghong Song
2021-02-23 21:24 ` Andrii Nakryiko
2021-02-17 18:18 ` [PATCH bpf-next v2 09/11] bpftool: print local function pointer properly Yonghong Song
2021-02-23 8:06 ` Andrii Nakryiko
2021-02-23 19:00 ` Yonghong Song
2021-02-17 18:18 ` [PATCH bpf-next v2 10/11] selftests/bpf: add hashmap test for bpf_for_each_map_elem() helper Yonghong Song
2021-02-17 18:18 ` [PATCH bpf-next v2 11/11] selftests/bpf: add arraymap " Yonghong Song
2021-02-17 18:29 ` [PATCH bpf-next v2 00/11] bpf: add " Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b6acd8d-8299-5881-3240-3e06539bb678@fb.com \
--to=yhs@fb.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).