bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andriin@fb.com>
To: John Fastabend <john.fastabend@gmail.com>,
	"ast@kernel.org" <ast@kernel.org>,
	"daniel@iogearbox.net" <daniel@iogearbox.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: Re: [bpf-next PATCH] bpf: libbpf, add kernel version section parsing back
Date: Fri, 18 Oct 2019 16:51:43 +0000	[thread overview]
Message-ID: <4da33f52-e857-9997-4226-4eae0f440df9@fb.com> (raw)
In-Reply-To: <157140968634.9073.6407090804163937103.stgit@john-XPS-13-9370>

On 10/18/19 7:41 AM, John Fastabend wrote:
> With commit "libbpf: stop enforcing kern_version,..." we removed the
> kernel version section parsing in favor of querying for the kernel
> using uname() and populating the version using the result of the
> query. After this any version sections were simply ignored.
> Unfortunately, the world of kernels is not so friendly. I've found some
> customized kernels where uname() does not match the in kernel version.
> To fix this so programs can load in this environment this patch adds
> back parsing the section and if it exists uses the user specified
> kernel version to override the uname() result. However, keep most the
> kernel uname() discovery bits so users are not required to insert the
> version except in these odd cases.
> Fixes: 5e61f27070292 ("libbpf: stop enforcing kern_version, populate it for users")
> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
> ---

In the name of not breaking users of weird kernels :)

Acked-by: Andrii Nakryiko <andriin@fb.com>

>   tools/lib/bpf/libbpf.c |   21 ++++++++++++++++++++-
>   1 file changed, 20 insertions(+), 1 deletion(-)


  reply	other threads:[~2019-10-18 16:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 14:41 John Fastabend
2019-10-18 16:51 ` Andrii Nakryiko [this message]
2019-10-19  1:33   ` Alexei Starovoitov
2019-10-19  4:41     ` John Fastabend
2019-10-18 19:11 ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4da33f52-e857-9997-4226-4eae0f440df9@fb.com \
    --to=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [bpf-next PATCH] bpf: libbpf, add kernel version section parsing back' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).