From: Daniel Borkmann <daniel@iogearbox.net>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
"Andrii Nakryiko" <andriin@fb.com>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
"Alexei Starovoitov" <ast@fb.com>,
"Kernel Team" <kernel-team@fb.com>, "Yonghong Song" <yhs@fb.com>
Subject: Re: [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums
Date: Wed, 4 Mar 2020 17:03:11 +0100 [thread overview]
Message-ID: <5057ca77-2780-07c5-3a7d-20d2934fc6a5@iogearbox.net> (raw)
In-Reply-To: <CAADnVQK4uJRNQzPChvQ==sL02nXHEELFJL_ehqYssuD_xeQx+A@mail.gmail.com>
On 3/4/20 4:50 PM, Alexei Starovoitov wrote:
> On Wed, Mar 4, 2020 at 7:39 AM Daniel Borkmann <daniel@iogearbox.net> wrote:
>>
>> I was about to push the series out, but agree that there may be a risk for #ifndefs
>> in the BPF C code. If we want to be on safe side, #define FOO FOO would be needed.
>
> There is really no risk.
> Let's not be paranoid about it and uglify bpf.h for no reason.
From what I've seen it seems so, yes. I've pushed the series now. Worst case we can
always add the define FOO FOO before it's exposed.
Thanks,
Daniel
next prev parent reply other threads:[~2020-03-04 16:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 0:32 [PATCH v3 bpf-next 0/3] Convert BPF UAPI constants into enum values Andrii Nakryiko
2020-03-03 0:32 ` [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums Andrii Nakryiko
2020-03-03 23:01 ` Daniel Borkmann
2020-03-03 23:24 ` Andrii Nakryiko
2020-03-04 9:37 ` Toke Høiland-Jørgensen
2020-03-04 15:38 ` Daniel Borkmann
2020-03-04 15:50 ` Alexei Starovoitov
2020-03-04 16:03 ` Daniel Borkmann [this message]
2020-03-04 15:57 ` Daniel Borkmann
2020-03-04 16:02 ` Andrii Nakryiko
2020-03-04 16:07 ` Alexei Starovoitov
2020-03-05 10:50 ` Toke Høiland-Jørgensen
2020-06-02 5:31 ` Michael Forney
2020-06-02 19:17 ` Alexei Starovoitov
2020-06-02 21:40 ` Michael Forney
2020-06-02 23:07 ` Alexei Starovoitov
2020-06-02 23:21 ` Michael Forney
2020-06-02 23:36 ` Alexei Starovoitov
2020-06-03 21:22 ` Michael Forney
2020-03-03 0:32 ` [PATCH v3 bpf-next 2/3] libbpf: assume unsigned values for BTF_KIND_ENUM Andrii Nakryiko
2020-03-03 0:32 ` [PATCH v3 bpf-next 3/3] tools/runqslower: drop copy/pasted BPF_F_CURRENT_CPU definiton Andrii Nakryiko
2020-03-04 15:21 ` [PATCH v3 bpf-next 0/3] Convert BPF UAPI constants into enum values Daniel Borkmann
2020-03-04 15:34 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5057ca77-2780-07c5-3a7d-20d2934fc6a5@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).