From: John Fastabend <john.fastabend@gmail.com> To: Daniel Borkmann <daniel@iogearbox.net>, John Fastabend <john.fastabend@gmail.com>, yhs@fb.com, andrii.nakryiko@gmail.com, ast@kernel.org Cc: netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [bpf-next PATCH v5 1/5] bpf, sk_msg: add some generic helpers that may be useful from sk_msg Date: Mon, 25 May 2020 15:57:00 -0700 [thread overview] Message-ID: <5ecc4d3c78c9e_718d2b15b962e5b845@john-XPS-13-9370.notmuch> (raw) In-Reply-To: <48c47712-bba1-3f53-bbeb-8a7403dab6db@iogearbox.net> Daniel Borkmann wrote: > On 5/24/20 6:50 PM, John Fastabend wrote: > > Add these generic helpers that may be useful to use from sk_msg programs. > > The helpers do not depend on ctx so we can simply add them here, > > > > BPF_FUNC_perf_event_output > > BPF_FUNC_get_current_uid_gid > > BPF_FUNC_get_current_pid_tgid > > BPF_FUNC_get_current_comm > > Hmm, added helpers below are what you list here except get_current_comm. > Was this forgotten to be added here? Forgot to update commit messages. I dropped it because it wasn't clear to me it was very useful or how I would use it from this context. I figure we can add it later if its needed. > > > BPF_FUNC_get_current_cgroup_id > > BPF_FUNC_get_current_ancestor_cgroup_id > > BPF_FUNC_get_cgroup_classid > > > > Acked-by: Yonghong Song <yhs@fb.com> > > Signed-off-by: John Fastabend <john.fastabend@gmail.com> > > --- > > net/core/filter.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/net/core/filter.c b/net/core/filter.c > > index 822d662..a56046a 100644 > > --- a/net/core/filter.c > > +++ b/net/core/filter.c > > @@ -6443,6 +6443,22 @@ sk_msg_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog) > > return &bpf_msg_push_data_proto; > > case BPF_FUNC_msg_pop_data: > > return &bpf_msg_pop_data_proto; > > + case BPF_FUNC_perf_event_output: > > + return &bpf_event_output_data_proto; > > + case BPF_FUNC_get_current_uid_gid: > > + return &bpf_get_current_uid_gid_proto; > > + case BPF_FUNC_get_current_pid_tgid: > > + return &bpf_get_current_pid_tgid_proto; > > +#ifdef CONFIG_CGROUPS > > + case BPF_FUNC_get_current_cgroup_id: > > + return &bpf_get_current_cgroup_id_proto; > > + case BPF_FUNC_get_current_ancestor_cgroup_id: > > + return &bpf_get_current_ancestor_cgroup_id_proto; > > +#endif > > +#ifdef CONFIG_CGROUP_NET_CLASSID > > + case BPF_FUNC_get_cgroup_classid: > > + return &bpf_get_cgroup_classid_curr_proto; > > +#endif > > default: > > return bpf_base_func_proto(func_id); > > } > > >
next prev parent reply other threads:[~2020-05-25 22:57 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-24 16:50 [bpf-next PATCH v5 0/5] bpf: Add sk_msg and networking helpers John Fastabend 2020-05-24 16:50 ` [bpf-next PATCH v5 1/5] bpf, sk_msg: add some generic helpers that may be useful from sk_msg John Fastabend 2020-05-25 21:51 ` Daniel Borkmann 2020-05-25 22:57 ` John Fastabend [this message] 2020-05-26 18:33 ` Andrii Nakryiko 2020-05-26 20:51 ` John Fastabend 2020-05-26 21:29 ` Andrii Nakryiko 2020-05-26 23:12 ` Daniel Borkmann 2020-05-24 16:50 ` [bpf-next PATCH v5 2/5] bpf: extend bpf_base_func_proto helpers with probe_* and *current_task* John Fastabend 2020-05-25 21:52 ` Daniel Borkmann 2020-05-25 22:58 ` John Fastabend 2020-05-24 16:51 ` [bpf-next PATCH v5 3/5] bpf, sk_msg: add get socket storage helpers John Fastabend 2020-05-24 16:51 ` [bpf-next PATCH v5 4/5] bpf, selftests: add sk_msg helpers load and attach test John Fastabend 2020-05-26 18:07 ` Andrii Nakryiko 2020-05-24 16:51 ` [bpf-next PATCH v5 5/5] bpf, selftests: test probe_* helpers from SCHED_CLS John Fastabend 2020-05-26 18:09 ` Andrii Nakryiko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5ecc4d3c78c9e_718d2b15b962e5b845@john-XPS-13-9370.notmuch \ --to=john.fastabend@gmail.com \ --cc=andrii.nakryiko@gmail.com \ --cc=ast@kernel.org \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=netdev@vger.kernel.org \ --cc=yhs@fb.com \ --subject='Re: [bpf-next PATCH v5 1/5] bpf, sk_msg: add some generic helpers that may be useful from sk_msg' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).