BPF Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH bpf] libbpf: fix Makefile' libbpf symbol mismatch diagnostic
@ 2019-11-27 20:01 Andrii Nakryiko
  2019-11-27 20:16 ` Yonghong Song
  2019-11-27 21:33 ` Daniel Borkmann
  0 siblings, 2 replies; 3+ messages in thread
From: Andrii Nakryiko @ 2019-11-27 20:01 UTC (permalink / raw)
  To: bpf, netdev, ast, daniel, yhs
  Cc: andrii.nakryiko, kernel-team, Andrii Nakryiko

Fix Makefile's diagnostic diff output when there is LIBBPF_API-versioned
symbols mismatch.

Fixes: 1bd63524593b ("libbpf: handle symbol versioning properly for libbpf.a")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
---
 tools/lib/bpf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
index 99425d0be6ff..1470303b1922 100644
--- a/tools/lib/bpf/Makefile
+++ b/tools/lib/bpf/Makefile
@@ -214,7 +214,7 @@ check_abi: $(OUTPUT)libbpf.so
 		     "versioned symbols in $^ ($(VERSIONED_SYM_COUNT))." \
 		     "Please make sure all LIBBPF_API symbols are"	 \
 		     "versioned in $(VERSION_SCRIPT)." >&2;		 \
-		readelf -s --wide $(OUTPUT)libbpf-in.o |		 \
+		readelf -s --wide $(BPF_IN_SHARED) |			 \
 		    cut -d "@" -f1 | sed 's/_v[0-9]_[0-9]_[0-9].*//' |	 \
 		    awk '/GLOBAL/ && /DEFAULT/ && !/UND/ {print $$8}'|   \
 		    sort -u > $(OUTPUT)libbpf_global_syms.tmp;		 \
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH bpf] libbpf: fix Makefile' libbpf symbol mismatch diagnostic
  2019-11-27 20:01 [PATCH bpf] libbpf: fix Makefile' libbpf symbol mismatch diagnostic Andrii Nakryiko
@ 2019-11-27 20:16 ` Yonghong Song
  2019-11-27 21:33 ` Daniel Borkmann
  1 sibling, 0 replies; 3+ messages in thread
From: Yonghong Song @ 2019-11-27 20:16 UTC (permalink / raw)
  To: Andrii Nakryiko, bpf, netdev, Alexei Starovoitov, daniel
  Cc: andrii.nakryiko, Kernel Team



On 11/27/19 12:01 PM, Andrii Nakryiko wrote:
> Fix Makefile's diagnostic diff output when there is LIBBPF_API-versioned
> symbols mismatch.
> 
> Fixes: 1bd63524593b ("libbpf: handle symbol versioning properly for libbpf.a")
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>

Thanks for the fix!
Acked-by: Yonghong Song <yhs@fb.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH bpf] libbpf: fix Makefile' libbpf symbol mismatch diagnostic
  2019-11-27 20:01 [PATCH bpf] libbpf: fix Makefile' libbpf symbol mismatch diagnostic Andrii Nakryiko
  2019-11-27 20:16 ` Yonghong Song
@ 2019-11-27 21:33 ` Daniel Borkmann
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2019-11-27 21:33 UTC (permalink / raw)
  To: Andrii Nakryiko, bpf, netdev, ast, yhs; +Cc: andrii.nakryiko, kernel-team

On 11/27/19 9:01 PM, Andrii Nakryiko wrote:
> Fix Makefile's diagnostic diff output when there is LIBBPF_API-versioned
> symbols mismatch.
> 
> Fixes: 1bd63524593b ("libbpf: handle symbol versioning properly for libbpf.a")
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>

Applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27 20:01 [PATCH bpf] libbpf: fix Makefile' libbpf symbol mismatch diagnostic Andrii Nakryiko
2019-11-27 20:16 ` Yonghong Song
2019-11-27 21:33 ` Daniel Borkmann

BPF Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \
		bpf@vger.kernel.org
	public-inbox-index bpf

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.bpf


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git