* [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers
@ 2022-02-10 20:30 Sherry Yang
2022-02-10 21:16 ` Kees Cook
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Sherry Yang @ 2022-02-10 20:30 UTC (permalink / raw)
To: skhan, shuah, keescook, luto, wad, christian, ast, daniel,
andrii, kafai, songliubraving, yhs, john.fastabend, kpsingh
Cc: linux-kselftest, linux-kernel, netdev, bpf, sherry.yang
seccomp_bpf failed on tests 47 global.user_notification_filter_empty
and 48 global.user_notification_filter_empty_threaded when it's
tested on updated kernel but with old kernel headers. Because old
kernel headers don't have definition of macro __NR_clone3 which is
required for these two tests. Since under selftests/, we can install
headers once for all tests (the default INSTALL_HDR_PATH is
usr/include), fix it by adding usr/include to the list of directories
to be searched. Use "-isystem" to indicate it's a system directory as
the real kernel headers directories are.
Signed-off-by: Sherry Yang <sherry.yang@oracle.com>
Tested-by: Sherry Yang <sherry.yang@oracle.com>
---
tools/testing/selftests/seccomp/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile
index 0ebfe8b0e147..585f7a0c10cb 100644
--- a/tools/testing/selftests/seccomp/Makefile
+++ b/tools/testing/selftests/seccomp/Makefile
@@ -1,5 +1,5 @@
# SPDX-License-Identifier: GPL-2.0
-CFLAGS += -Wl,-no-as-needed -Wall
+CFLAGS += -Wl,-no-as-needed -Wall -isystem ../../../../usr/include/
LDFLAGS += -lpthread
TEST_GEN_PROGS := seccomp_bpf seccomp_benchmark
--
2.31.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers
2022-02-10 20:30 [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers Sherry Yang
@ 2022-02-10 21:16 ` Kees Cook
2022-02-10 21:36 ` Shuah Khan
2022-02-10 23:11 ` Muhammad Usama Anjum
2022-02-10 23:14 ` Muhammad Usama Anjum
2 siblings, 1 reply; 11+ messages in thread
From: Kees Cook @ 2022-02-10 21:16 UTC (permalink / raw)
To: Sherry Yang
Cc: skhan, shuah, luto, wad, christian, ast, daniel, andrii, kafai,
songliubraving, yhs, john.fastabend, kpsingh, linux-kselftest,
linux-kernel, netdev, bpf
On Thu, Feb 10, 2022 at 12:30:49PM -0800, Sherry Yang wrote:
> seccomp_bpf failed on tests 47 global.user_notification_filter_empty
> and 48 global.user_notification_filter_empty_threaded when it's
> tested on updated kernel but with old kernel headers. Because old
> kernel headers don't have definition of macro __NR_clone3 which is
> required for these two tests. Since under selftests/, we can install
> headers once for all tests (the default INSTALL_HDR_PATH is
> usr/include), fix it by adding usr/include to the list of directories
> to be searched. Use "-isystem" to indicate it's a system directory as
> the real kernel headers directories are.
>
> Signed-off-by: Sherry Yang <sherry.yang@oracle.com>
Thanks!
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers
2022-02-10 21:16 ` Kees Cook
@ 2022-02-10 21:36 ` Shuah Khan
0 siblings, 0 replies; 11+ messages in thread
From: Shuah Khan @ 2022-02-10 21:36 UTC (permalink / raw)
To: Kees Cook, Sherry Yang
Cc: shuah, luto, wad, christian, ast, daniel, andrii, kafai,
songliubraving, yhs, john.fastabend, kpsingh, linux-kselftest,
linux-kernel, netdev, bpf, Shuah Khan
On 2/10/22 2:16 PM, Kees Cook wrote:
> On Thu, Feb 10, 2022 at 12:30:49PM -0800, Sherry Yang wrote:
>> seccomp_bpf failed on tests 47 global.user_notification_filter_empty
>> and 48 global.user_notification_filter_empty_threaded when it's
>> tested on updated kernel but with old kernel headers. Because old
>> kernel headers don't have definition of macro __NR_clone3 which is
>> required for these two tests. Since under selftests/, we can install
>> headers once for all tests (the default INSTALL_HDR_PATH is
>> usr/include), fix it by adding usr/include to the list of directories
>> to be searched. Use "-isystem" to indicate it's a system directory as
>> the real kernel headers directories are.
>>
>> Signed-off-by: Sherry Yang <sherry.yang@oracle.com>
>
> Thanks!
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
Thank you. I will queue this up for rc5.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers
2022-02-10 20:30 [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers Sherry Yang
2022-02-10 21:16 ` Kees Cook
@ 2022-02-10 23:11 ` Muhammad Usama Anjum
2022-02-10 23:14 ` Muhammad Usama Anjum
2 siblings, 0 replies; 11+ messages in thread
From: Muhammad Usama Anjum @ 2022-02-10 23:11 UTC (permalink / raw)
To: Sherry Yang, skhan, shuah, keescook, luto, wad, christian, ast,
daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh
Cc: usama.anjum, linux-kselftest, linux-kernel, netdev, bpf
On 2/11/22 1:30 AM, Sherry Yang wrote:
> seccomp_bpf failed on tests 47 global.user_notification_filter_empty
> and 48 global.user_notification_filter_empty_threaded when it's
> tested on updated kernel but with old kernel headers. Because old
> kernel headers don't have definition of macro __NR_clone3 which is
> required for these two tests. Since under selftests/, we can install
> headers once for all tests (the default INSTALL_HDR_PATH is
> usr/include), fix it by adding usr/include to the list of directories
> to be searched. Use "-isystem" to indicate it's a system directory as
> the real kernel headers directories are.
>
> Signed-off-by: Sherry Yang <sherry.yang@oracle.com>
> Tested-by: Sherry Yang <sherry.yang@oracle.com>
> ---
> tools/testing/selftests/seccomp/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile
> index 0ebfe8b0e147..585f7a0c10cb 100644
> --- a/tools/testing/selftests/seccomp/Makefile
> +++ b/tools/testing/selftests/seccomp/Makefile
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0
> -CFLAGS += -Wl,-no-as-needed -Wall
> +CFLAGS += -Wl,-no-as-needed -Wall -isystem ../../../../usr/include/"../../../../usr/include/" directory doesn't have header files if
different output directory is used for kselftests build like "make -C
tools/tests/selftest O=build". Can you try adding recently added
variable, KHDR_INCLUDES here which makes this kind of headers inclusion
easy and correct for other build combinations as well?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers
2022-02-10 20:30 [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers Sherry Yang
2022-02-10 21:16 ` Kees Cook
2022-02-10 23:11 ` Muhammad Usama Anjum
@ 2022-02-10 23:14 ` Muhammad Usama Anjum
2022-02-10 23:58 ` Kees Cook
2022-02-11 1:14 ` Sherry Yang
2 siblings, 2 replies; 11+ messages in thread
From: Muhammad Usama Anjum @ 2022-02-10 23:14 UTC (permalink / raw)
To: Sherry Yang, skhan, shuah, keescook, luto, wad, christian, ast,
daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh
Cc: usama.anjum, linux-kselftest, linux-kernel, netdev, bpf
On 2/11/22 1:30 AM, Sherry Yang wrote:
> seccomp_bpf failed on tests 47 global.user_notification_filter_empty
> and 48 global.user_notification_filter_empty_threaded when it's
> tested on updated kernel but with old kernel headers. Because old
> kernel headers don't have definition of macro __NR_clone3 which is
> required for these two tests. Since under selftests/, we can install
> headers once for all tests (the default INSTALL_HDR_PATH is
> usr/include), fix it by adding usr/include to the list of directories
> to be searched. Use "-isystem" to indicate it's a system directory as
> the real kernel headers directories are.
>
> Signed-off-by: Sherry Yang <sherry.yang@oracle.com>
> Tested-by: Sherry Yang <sherry.yang@oracle.com>
> ---
> tools/testing/selftests/seccomp/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile
> index 0ebfe8b0e147..585f7a0c10cb 100644
> --- a/tools/testing/selftests/seccomp/Makefile
> +++ b/tools/testing/selftests/seccomp/Makefile
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0
> -CFLAGS += -Wl,-no-as-needed -Wall
> +CFLAGS += -Wl,-no-as-needed -Wall -isystem ../../../../usr/include/
"../../../../usr/include/" directory doesn't have header files if
different output directory is used for kselftests build like "make -C
tools/tests/selftest O=build". Can you try adding recently added
variable, KHDR_INCLUDES here which makes this kind of headers inclusion
easy and correct for other build combinations as well?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers
2022-02-10 23:14 ` Muhammad Usama Anjum
@ 2022-02-10 23:58 ` Kees Cook
2022-02-11 1:14 ` Sherry Yang
1 sibling, 0 replies; 11+ messages in thread
From: Kees Cook @ 2022-02-10 23:58 UTC (permalink / raw)
To: Muhammad Usama Anjum
Cc: Sherry Yang, skhan, shuah, luto, wad, christian, ast, daniel,
andrii, kafai, songliubraving, yhs, john.fastabend, kpsingh,
linux-kselftest, linux-kernel, netdev, bpf
On Fri, Feb 11, 2022 at 04:14:17AM +0500, Muhammad Usama Anjum wrote:
> On 2/11/22 1:30 AM, Sherry Yang wrote:
> > seccomp_bpf failed on tests 47 global.user_notification_filter_empty
> > and 48 global.user_notification_filter_empty_threaded when it's
> > tested on updated kernel but with old kernel headers. Because old
> > kernel headers don't have definition of macro __NR_clone3 which is
> > required for these two tests. Since under selftests/, we can install
> > headers once for all tests (the default INSTALL_HDR_PATH is
> > usr/include), fix it by adding usr/include to the list of directories
> > to be searched. Use "-isystem" to indicate it's a system directory as
> > the real kernel headers directories are.
> >
> > Signed-off-by: Sherry Yang <sherry.yang@oracle.com>
> > Tested-by: Sherry Yang <sherry.yang@oracle.com>
> > ---
> > tools/testing/selftests/seccomp/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile
> > index 0ebfe8b0e147..585f7a0c10cb 100644
> > --- a/tools/testing/selftests/seccomp/Makefile
> > +++ b/tools/testing/selftests/seccomp/Makefile
> > @@ -1,5 +1,5 @@
> > # SPDX-License-Identifier: GPL-2.0
> > -CFLAGS += -Wl,-no-as-needed -Wall
> > +CFLAGS += -Wl,-no-as-needed -Wall -isystem ../../../../usr/include/
>
> "../../../../usr/include/" directory doesn't have header files if
> different output directory is used for kselftests build like "make -C
> tools/tests/selftest O=build". Can you try adding recently added
> variable, KHDR_INCLUDES here which makes this kind of headers inclusion
> easy and correct for other build combinations as well?
Ah, if that's true I think there are some other instances in the tree
that need fixing too.
--
Kees Cook
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers
2022-02-10 23:14 ` Muhammad Usama Anjum
2022-02-10 23:58 ` Kees Cook
@ 2022-02-11 1:14 ` Sherry Yang
2022-02-14 16:12 ` Muhammad Usama Anjum
1 sibling, 1 reply; 11+ messages in thread
From: Sherry Yang @ 2022-02-11 1:14 UTC (permalink / raw)
To: Muhammad Usama Anjum
Cc: Shuah Khan, shuah, Kees Cook, luto, wad, christian, ast, daniel,
andrii, kafai, songliubraving, yhs, john.fastabend, kpsingh,
linux-kselftest, linux-kernel, netdev, bpf
> On Feb 10, 2022, at 3:14 PM, Muhammad Usama Anjum <usama.anjum@collabora.com> wrote:
>
> On 2/11/22 1:30 AM, Sherry Yang wrote:
>> seccomp_bpf failed on tests 47 global.user_notification_filter_empty
>> and 48 global.user_notification_filter_empty_threaded when it's
>> tested on updated kernel but with old kernel headers. Because old
>> kernel headers don't have definition of macro __NR_clone3 which is
>> required for these two tests. Since under selftests/, we can install
>> headers once for all tests (the default INSTALL_HDR_PATH is
>> usr/include), fix it by adding usr/include to the list of directories
>> to be searched. Use "-isystem" to indicate it's a system directory as
>> the real kernel headers directories are.
>>
>> Signed-off-by: Sherry Yang <sherry.yang@oracle.com>
>> Tested-by: Sherry Yang <sherry.yang@oracle.com>
>> ---
>> tools/testing/selftests/seccomp/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile
>> index 0ebfe8b0e147..585f7a0c10cb 100644
>> --- a/tools/testing/selftests/seccomp/Makefile
>> +++ b/tools/testing/selftests/seccomp/Makefile
>> @@ -1,5 +1,5 @@
>> # SPDX-License-Identifier: GPL-2.0
>> -CFLAGS += -Wl,-no-as-needed -Wall
>> +CFLAGS += -Wl,-no-as-needed -Wall -isystem ../../../../usr/include/
>
> "../../../../usr/include/" directory doesn't have header files if
> different output directory is used for kselftests build like "make -C
> tools/tests/selftest O=build". Can you try adding recently added
> variable, KHDR_INCLUDES here which makes this kind of headers inclusion
> easy and correct for other build combinations as well?
>
>
Hi Muhammad,
I just pulled linux-next, and tried with KHDR_INCLUDES. It works. Very nice
work! I really appreciate you made headers inclusion compatible. However,
my case is a little more complicated. It will throw warnings with -I, using
-isystem can suppress these warnings, more details please refer to
https://lore.kernel.org/all/C340461A-6FD2-440A-8EFC-D7E85BF48DB5@oracle.com/
According to this case, do you think will it be better to export header path
(KHDR_INCLUDES) without “-I”?
Thanks,
Sherry
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers
2022-02-11 1:14 ` Sherry Yang
@ 2022-02-14 16:12 ` Muhammad Usama Anjum
2022-02-15 18:17 ` Muhammad Usama Anjum
0 siblings, 1 reply; 11+ messages in thread
From: Muhammad Usama Anjum @ 2022-02-14 16:12 UTC (permalink / raw)
To: Sherry Yang
Cc: usama.anjum, Shuah Khan, shuah, Kees Cook, luto, wad, christian,
ast, daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh, linux-kselftest, linux-kernel, netdev, bpf
>> "../../../../usr/include/" directory doesn't have header files if
>> different output directory is used for kselftests build like "make -C
>> tools/tests/selftest O=build". Can you try adding recently added
>> variable, KHDR_INCLUDES here which makes this kind of headers inclusion
>> easy and correct for other build combinations as well?
>>
>>
>
> Hi Muhammad,
>
> I just pulled linux-next, and tried with KHDR_INCLUDES. It works. Very nice
> work! I really appreciate you made headers inclusion compatible. However,
> my case is a little more complicated. It will throw warnings with -I, using
> -isystem can suppress these warnings, more details please refer to
> https://lore.kernel.org/all/C340461A-6FD2-440A-8EFC-D7E85BF48DB5@oracle.com/
>
> According to this case, do you think will it be better to export header path
> (KHDR_INCLUDES) without “-I”?
Well said. I've thought about it and it seems like -isystem is better
than -I. I've sent a patch:
https://lore.kernel.org/linux-kselftest/20220214160756.3543590-1-usama.anjum@collabora.com/
I'm looking forward to discussion on it.
Thanks,
Usama
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers
2022-02-14 16:12 ` Muhammad Usama Anjum
@ 2022-02-15 18:17 ` Muhammad Usama Anjum
2022-02-15 18:43 ` Shuah Khan
0 siblings, 1 reply; 11+ messages in thread
From: Muhammad Usama Anjum @ 2022-02-15 18:17 UTC (permalink / raw)
To: Sherry Yang
Cc: usama.anjum, Shuah Khan, shuah, Kees Cook, luto, wad, christian,
ast, daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh, linux-kselftest, linux-kernel, netdev, bpf
On 2/14/22 9:12 PM, Muhammad Usama Anjum wrote:
>>> "../../../../usr/include/" directory doesn't have header files if
>>> different output directory is used for kselftests build like "make -C
>>> tools/tests/selftest O=build". Can you try adding recently added
>>> variable, KHDR_INCLUDES here which makes this kind of headers inclusion
>>> easy and correct for other build combinations as well?
>>>
>>>
>>
>> Hi Muhammad,
>>
>> I just pulled linux-next, and tried with KHDR_INCLUDES. It works. Very nice
>> work! I really appreciate you made headers inclusion compatible. However,
>> my case is a little more complicated. It will throw warnings with -I, using
>> -isystem can suppress these warnings, more details please refer to
>> https://lore.kernel.org/all/C340461A-6FD2-440A-8EFC-D7E85BF48DB5@oracle.com/
>>
>> According to this case, do you think will it be better to export header path
>> (KHDR_INCLUDES) without “-I”?
> Well said. I've thought about it and it seems like -isystem is better
> than -I. I've sent a patch:
> https://lore.kernel.org/linux-kselftest/20220214160756.3543590-1-usama.anjum@collabora.com/
> I'm looking forward to discussion on it.
The patch has been accepted. It should appear in linux-next soon. You
should be able to use KHDR_INCLUDES easily now.
Thanks,
Usama
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers
2022-02-15 18:17 ` Muhammad Usama Anjum
@ 2022-02-15 18:43 ` Shuah Khan
2022-02-15 18:51 ` Sherry Yang
0 siblings, 1 reply; 11+ messages in thread
From: Shuah Khan @ 2022-02-15 18:43 UTC (permalink / raw)
To: Muhammad Usama Anjum, Sherry Yang
Cc: shuah, Kees Cook, luto, wad, christian, ast, daniel, andrii,
kafai, songliubraving, yhs, john.fastabend, kpsingh,
linux-kselftest, linux-kernel, netdev, bpf, Shuah Khan
On 2/15/22 11:17 AM, Muhammad Usama Anjum wrote:
>
> On 2/14/22 9:12 PM, Muhammad Usama Anjum wrote:
>>>> "../../../../usr/include/" directory doesn't have header files if
>>>> different output directory is used for kselftests build like "make -C
>>>> tools/tests/selftest O=build". Can you try adding recently added
>>>> variable, KHDR_INCLUDES here which makes this kind of headers inclusion
>>>> easy and correct for other build combinations as well?
>>>>
>>>>
>>>
>>> Hi Muhammad,
>>>
>>> I just pulled linux-next, and tried with KHDR_INCLUDES. It works. Very nice
>>> work! I really appreciate you made headers inclusion compatible. However,
>>> my case is a little more complicated. It will throw warnings with -I, using
>>> -isystem can suppress these warnings, more details please refer to
>>> https://lore.kernel.org/all/C340461A-6FD2-440A-8EFC-D7E85BF48DB5@oracle.com/
>>>
>>> According to this case, do you think will it be better to export header path
>>> (KHDR_INCLUDES) without “-I”?
>> Well said. I've thought about it and it seems like -isystem is better
>> than -I. I've sent a patch:
>> https://lore.kernel.org/linux-kselftest/20220214160756.3543590-1-usama.anjum@collabora.com/
>> I'm looking forward to discussion on it.
> The patch has been accepted. It should appear in linux-next soon. You
> should be able to use KHDR_INCLUDES easily now.
>
Sherry,
I pulled in your patch as a fix as is for 5.17-rc5.
Using KHDR_INCLUDES can be separate patch for next release.
This way the fix is going to be pulled for this release
without dependencies on other patches.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers
2022-02-15 18:43 ` Shuah Khan
@ 2022-02-15 18:51 ` Sherry Yang
0 siblings, 0 replies; 11+ messages in thread
From: Sherry Yang @ 2022-02-15 18:51 UTC (permalink / raw)
To: Shuah Khan
Cc: Muhammad Usama Anjum, shuah, Kees Cook, luto, wad, christian,
ast, daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh, linux-kselftest, linux-kernel, netdev, bpf
> On Feb 15, 2022, at 10:43 AM, Shuah Khan <skhan@linuxfoundation.org> wrote:
>
> On 2/15/22 11:17 AM, Muhammad Usama Anjum wrote:
>> On 2/14/22 9:12 PM, Muhammad Usama Anjum wrote:
>>>>> "../../../../usr/include/" directory doesn't have header files if
>>>>> different output directory is used for kselftests build like "make -C
>>>>> tools/tests/selftest O=build". Can you try adding recently added
>>>>> variable, KHDR_INCLUDES here which makes this kind of headers inclusion
>>>>> easy and correct for other build combinations as well?
>>>>>
>>>>>
>>>>
>>>> Hi Muhammad,
>>>>
>>>> I just pulled linux-next, and tried with KHDR_INCLUDES. It works. Very nice
>>>> work! I really appreciate you made headers inclusion compatible. However,
>>>> my case is a little more complicated. It will throw warnings with -I, using
>>>> -isystem can suppress these warnings, more details please refer to
>>>> https://urldefense.com/v3/__https://lore.kernel.org/all/C340461A-6FD2-440A-8EFC-D7E85BF48DB5@oracle.com/__;!!ACWV5N9M2RV99hQ!e4ajMH2HRzLNZZDe3Z1iqAO7L8SVjqnvp-a5NfT6I-mKD59xjA-zHM8TAfkJM1Udcg$
>>>> According to this case, do you think will it be better to export header path
>>>> (KHDR_INCLUDES) without “-I”?
>>> Well said. I've thought about it and it seems like -isystem is better
>>> than -I. I've sent a patch:
>>> https://urldefense.com/v3/__https://lore.kernel.org/linux-kselftest/20220214160756.3543590-1-usama.anjum@collabora.com/__;!!ACWV5N9M2RV99hQ!e4ajMH2HRzLNZZDe3Z1iqAO7L8SVjqnvp-a5NfT6I-mKD59xjA-zHM8TAfk0AVSbFg$ I'm looking forward to discussion on it.
>> The patch has been accepted. It should appear in linux-next soon. You
>> should be able to use KHDR_INCLUDES easily now.
>
> Sherry,
>
> I pulled in your patch as a fix as is for 5.17-rc5.
>
> Using KHDR_INCLUDES can be separate patch for next release.
> This way the fix is going to be pulled for this release
> without dependencies on other patches.
>
> thanks,
> -- Shuah
Oh, I just sent out v3 patch before I received the updates. Okay, I will send
a separate patch with KHDR_INCLUDES later.
Thanks,
Sherry
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-02-15 18:51 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10 20:30 [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers Sherry Yang
2022-02-10 21:16 ` Kees Cook
2022-02-10 21:36 ` Shuah Khan
2022-02-10 23:11 ` Muhammad Usama Anjum
2022-02-10 23:14 ` Muhammad Usama Anjum
2022-02-10 23:58 ` Kees Cook
2022-02-11 1:14 ` Sherry Yang
2022-02-14 16:12 ` Muhammad Usama Anjum
2022-02-15 18:17 ` Muhammad Usama Anjum
2022-02-15 18:43 ` Shuah Khan
2022-02-15 18:51 ` Sherry Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).