* [PATCH -next V2] sysctl: returns -EINVAL when a negative value is passed to proc_doulongvec_minmax
@ 2021-12-20 9:26 Baokun Li
2021-12-20 19:17 ` Luis Chamberlain
0 siblings, 1 reply; 3+ messages in thread
From: Baokun Li @ 2021-12-20 9:26 UTC (permalink / raw)
To: mcgrof, akpm, keescook, yzaikin, ast, daniel, andrii, kafai,
songliubraving, yhs, john.fastabend, kpsingh
Cc: linux-kernel, linux-fsdevel, netdev, bpf, libaokun1, yukuai3, Hulk Robot
When we pass a negative value to the proc_doulongvec_minmax() function,
the function returns 0, but the corresponding interface value does not
change.
we can easily reproduce this problem with the following commands:
`cd /proc/sys/fs/epoll`
`echo -1 > max_user_watches; echo $?; cat max_user_watches`
This function requires a non-negative number to be passed in, so when
a negative number is passed in, -EINVAL is returned.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
V1->V2:
Modify the judgment position.
kernel/sysctl.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 7f07b058b180..4211e39a5fd3 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1147,10 +1147,11 @@ static int __do_proc_doulongvec_minmax(void *data, struct ctl_table *table,
err = proc_get_long(&p, &left, &val, &neg,
proc_wspace_sep,
sizeof(proc_wspace_sep), NULL);
- if (err)
+ if (err || neg) {
+ err = -EINVAL;
break;
- if (neg)
- continue;
+ }
+
val = convmul * val / convdiv;
if ((min && val < *min) || (max && val > *max)) {
err = -EINVAL;
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next V2] sysctl: returns -EINVAL when a negative value is passed to proc_doulongvec_minmax
2021-12-20 9:26 [PATCH -next V2] sysctl: returns -EINVAL when a negative value is passed to proc_doulongvec_minmax Baokun Li
@ 2021-12-20 19:17 ` Luis Chamberlain
2021-12-21 1:21 ` libaokun (A)
0 siblings, 1 reply; 3+ messages in thread
From: Luis Chamberlain @ 2021-12-20 19:17 UTC (permalink / raw)
To: Baokun Li
Cc: akpm, keescook, yzaikin, ast, daniel, andrii, kafai,
songliubraving, yhs, john.fastabend, kpsingh, linux-kernel,
linux-fsdevel, netdev, bpf, yukuai3, Hulk Robot
On Mon, Dec 20, 2021 at 05:26:27PM +0800, Baokun Li wrote:
> When we pass a negative value to the proc_doulongvec_minmax() function,
> the function returns 0, but the corresponding interface value does not
> change.
>
> we can easily reproduce this problem with the following commands:
> `cd /proc/sys/fs/epoll`
> `echo -1 > max_user_watches; echo $?; cat max_user_watches`
>
> This function requires a non-negative number to be passed in, so when
> a negative number is passed in, -EINVAL is returned.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next V2] sysctl: returns -EINVAL when a negative value is passed to proc_doulongvec_minmax
2021-12-20 19:17 ` Luis Chamberlain
@ 2021-12-21 1:21 ` libaokun (A)
0 siblings, 0 replies; 3+ messages in thread
From: libaokun (A) @ 2021-12-21 1:21 UTC (permalink / raw)
To: Luis Chamberlain
Cc: akpm, keescook, yzaikin, ast, daniel, andrii, kafai,
songliubraving, yhs, john.fastabend, kpsingh, linux-kernel,
linux-fsdevel, netdev, bpf, yukuai3, Hulk Robot, Baokun Li
在 2021/12/21 3:17, Luis Chamberlain 写道:
> On Mon, Dec 20, 2021 at 05:26:27PM +0800, Baokun Li wrote:
>> When we pass a negative value to the proc_doulongvec_minmax() function,
>> the function returns 0, but the corresponding interface value does not
>> change.
>>
>> we can easily reproduce this problem with the following commands:
>> `cd /proc/sys/fs/epoll`
>> `echo -1 > max_user_watches; echo $?; cat max_user_watches`
>>
>> This function requires a non-negative number to be passed in, so when
>> a negative number is passed in, -EINVAL is returned.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> Acked-by: Luis Chamberlain <mcgrof@kernel.org>
>
> Luis
> .
Thank you for your Ack.
--
With Best Regards,
Baokun Li
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-21 1:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 9:26 [PATCH -next V2] sysctl: returns -EINVAL when a negative value is passed to proc_doulongvec_minmax Baokun Li
2021-12-20 19:17 ` Luis Chamberlain
2021-12-21 1:21 ` libaokun (A)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).