bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeedm@nvidia.com>
To: Vlad Buslov <vladbu@nvidia.com>, "kuba@kernel.org" <kuba@kernel.org>
Cc: "songliubraving@fb.com" <songliubraving@fb.com>,
	"hawk@kernel.org" <hawk@kernel.org>,
	"syzkaller-bugs@googlegroups.com"
	<syzkaller-bugs@googlegroups.com>, "kafai@fb.com" <kafai@fb.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
	"andrii@kernel.org" <andrii@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"kpsingh@kernel.org" <kpsingh@kernel.org>,
	"ast@kernel.org" <ast@kernel.org>,
	"joamaki@gmail.com" <joamaki@gmail.com>,
	"yhs@fb.com" <yhs@fb.com>, "toke@toke.dk" <toke@toke.dk>,
	"daniel@iogearbox.net" <daniel@iogearbox.net>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	Maxim Mikityanskiy <maximmi@nvidia.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"syzbot+62e474dd92a35e3060d8@syzkaller.appspotmail.com" 
	<syzbot+62e474dd92a35e3060d8@syzkaller.appspotmail.com>
Subject: Re: [syzbot] BUG: corrupted list in netif_napi_add
Date: Mon, 18 Oct 2021 23:31:41 +0000	[thread overview]
Message-ID: <8209462f985ac235a9d307de05835e31053528cc.camel@nvidia.com> (raw)
In-Reply-To: <ygnh35oyb9c0.fsf@nvidia.com>

On Mon, 2021-10-18 at 19:12 +0300, Vlad Buslov wrote:
> On Mon 18 Oct 2021 at 18:42, Jakub Kicinski <kuba@kernel.org> wrote:
> > On Mon, 18 Oct 2021 17:04:19 +0300 Vlad Buslov wrote:
> > > We got a use-after-free with very similar trace [0] during
> > > nightly
> > > regression. The issue happens when ip link up/down state is
> > > flipped
> > > several times in loop and doesn't reproduce for me manually. The
> > > fact
> > > that it didn't reproduce for me after running test ten times
> > > suggests
> > > that it is either very hard to reproduce or that it is a result
> > > of some
> > > interaction between several tests in our suite.
> > > 
> > > [0]:
> > > 
> > > [ 3187.779569] mlx5_core 0000:08:00.0 enp8s0f0: Link up
> > >  [ 3187.890694]
> > > =================================================================
> > > =
> > >  [ 3187.892518] BUG: KASAN: use-after-free in
> > > __list_add_valid+0xc3/0xf0
> > >  [ 3187.894132] Read of size 8 at addr ffff8881150b3fb8 by task
> > > ip/119618
> > 
> > Hm, not sure how similar it is. This one looks like channel was
> > freed
> > without deleting NAPI. Do you have list debug enabled?
> 
> Yes, CONFIG_DEBUG_LIST is enabled.
> 
do you have core dumps ?
let's enable kernel.panic_on_oops with core dumps and look at it next
time we see this, I really don't think mlx5 is leaking.. 


  reply	other threads:[~2021-10-18 23:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 11:40 [syzbot] BUG: corrupted list in netif_napi_add syzbot
2021-10-13 13:35 ` Daniel Borkmann
2021-10-14 13:50   ` Paolo Abeni
2021-10-18 14:04     ` Vlad Buslov
2021-10-18 15:42       ` Jakub Kicinski
2021-10-18 16:12         ` Vlad Buslov
2021-10-18 23:31           ` Saeed Mahameed [this message]
2021-10-18 17:40         ` Toke Høiland-Jørgensen
2021-10-18 17:58           ` Jakub Kicinski
2021-10-19 10:11     ` Jussi Maki
2021-10-13 14:41 ` Paolo Abeni
2021-12-14  7:52 ` syzbot
2021-12-14 17:56   ` Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8209462f985ac235a9d307de05835e31053528cc.camel@nvidia.com \
    --to=saeedm@nvidia.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=joamaki@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maximmi@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=songliubraving@fb.com \
    --cc=syzbot+62e474dd92a35e3060d8@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=toke@toke.dk \
    --cc=vladbu@nvidia.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).