From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Jakub Kicinski <kuba@kernel.org>, Vlad Buslov <vladbu@nvidia.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
Daniel Borkmann <daniel@iogearbox.net>,
syzbot <syzbot+62e474dd92a35e3060d8@syzkaller.appspotmail.com>,
andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
davem@davemloft.net, hawk@kernel.org, john.fastabend@gmail.com,
kafai@fb.com, kpsingh@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, songliubraving@fb.com,
syzkaller-bugs@googlegroups.com, yhs@fb.com, joamaki@gmail.com,
Saeed Mahameed <saeedm@nvidia.com>,
Maxim Mikityanskiy <maximmi@nvidia.com>
Subject: Re: [syzbot] BUG: corrupted list in netif_napi_add
Date: Mon, 18 Oct 2021 19:40:40 +0200 [thread overview]
Message-ID: <87lf2qi63r.fsf@toke.dk> (raw)
In-Reply-To: <20211018084201.4c7e5be1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Jakub Kicinski <kuba@kernel.org> writes:
> On Mon, 18 Oct 2021 17:04:19 +0300 Vlad Buslov wrote:
>> We got a use-after-free with very similar trace [0] during nightly
>> regression. The issue happens when ip link up/down state is flipped
>> several times in loop and doesn't reproduce for me manually. The fact
>> that it didn't reproduce for me after running test ten times suggests
>> that it is either very hard to reproduce or that it is a result of some
>> interaction between several tests in our suite.
>>
>> [0]:
>>
>> [ 3187.779569] mlx5_core 0000:08:00.0 enp8s0f0: Link up
>> [ 3187.890694] ==================================================================
>> [ 3187.892518] BUG: KASAN: use-after-free in __list_add_valid+0xc3/0xf0
>> [ 3187.894132] Read of size 8 at addr ffff8881150b3fb8 by task ip/119618
>
> Hm, not sure how similar it is. This one looks like channel was freed
> without deleting NAPI. Do you have list debug enabled?
Well, the other report[0] also kinda looks like the NAPI thread keeps
running after it should have been disabled, so maybe they are in fact
related?
-Toke
[0] https://lore.kernel.org/r/000000000000c1524005cdeacc5f@google.com
next prev parent reply other threads:[~2021-10-18 17:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 11:40 [syzbot] BUG: corrupted list in netif_napi_add syzbot
2021-10-13 13:35 ` Daniel Borkmann
2021-10-14 13:50 ` Paolo Abeni
2021-10-18 14:04 ` Vlad Buslov
2021-10-18 15:42 ` Jakub Kicinski
2021-10-18 16:12 ` Vlad Buslov
2021-10-18 23:31 ` Saeed Mahameed
2021-10-18 17:40 ` Toke Høiland-Jørgensen [this message]
2021-10-18 17:58 ` Jakub Kicinski
2021-10-19 10:11 ` Jussi Maki
2021-10-13 14:41 ` Paolo Abeni
2021-12-14 7:52 ` syzbot
2021-12-14 17:56 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf2qi63r.fsf@toke.dk \
--to=toke@toke.dk \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=joamaki@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximmi@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=songliubraving@fb.com \
--cc=syzbot+62e474dd92a35e3060d8@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=vladbu@nvidia.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).