Re: arch/riscv/net/bpf_jit_comp64.c build error

Re: arch/riscv/net/bpf_jit_comp64.c build error

[Björn Töpel]

Aleksandr Nogikh <nogikh@google.com> writes:

> Hi Pu Lehui,
>
> I'm writing to you regarding your following patch.
>
> Author: Pu Lehui <pulehui@huawei.com>
> Date:   Wed Feb 15 21:52:04 2023 +0800
>
>     riscv, bpf: Add bpf_arch_text_poke support for RV64
>
> When trying to compile the "fixes" branch of the
> "git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git" tree,
> syzbot gets the following error:
>
> arch/riscv/net/bpf_jit_comp64.c: In function 'bpf_arch_text_poke':
> arch/riscv/net/bpf_jit_comp64.c:691:9: error: implicit declaration of
> function 'patch_text'; did you mean 'path_get'?
> [-Werror=implicit-function-declaration]
>   691 |   ret = patch_text(ip, new_insns, ninsns);
>       |         ^~~~~~~~~~
>       |         path_get
>
> FWIW the compiler is riscv64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1
> 20210110, GNU ld (GNU Binutils for Debian) 2.35.2.
>
> Could you please take a look?

Randy sent a fix for this [1], which went in via the BPF tree. Pull in
commit 2d311f480b52 ("riscv, bpf: Fix patch_text implicit declaration").


Björn

[1] https://lore.kernel.org/linux-riscv/20230227072016.14618-1-rdunlap@infradead.org/