From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Martin KaFai Lau <kafai@fb.com>
Cc: John Fastabend <john.fastabend@gmail.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, Cong Wang <cong.wang@bytedance.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>
Subject: Re: [RFC Patch net-next] net_sched: introduce eBPF based Qdisc
Date: Fri, 03 Sep 2021 16:44:04 +0200 [thread overview]
Message-ID: <87zgstra6j.fsf@toke.dk> (raw)
In-Reply-To: <20210902233510.gnimg2krwwkzv4f2@kafai-mbp.dhcp.thefacebook.com>
Martin KaFai Lau <kafai@fb.com> writes:
> On Fri, Sep 03, 2021 at 12:27:52AM +0200, Toke Høiland-Jørgensen wrote:
>> >> The question is if it's useful to provide the full struct_ops for
>> >> qdiscs? Having it would allow a BPF program to implement that interface
>> >> towards userspace (things like statistics, classes etc), but the
>> >> question is if anyone is going to bother with that given the wealth of
>> >> BPF-specific introspection tools already available?
> Instead of bpftool can only introspect bpf qdisc and the existing tc
> can only introspect kernel qdisc, it will be nice to have bpf
> qdisc work as other qdisc and showing details together with others
> in tc. e.g. a bpf qdisc export its data/stats with its btf-id
> to tc and have tc print it out in a generic way?
I'm not opposed to the idea, certainly. I just wonder if people who go
to the trouble of writing a custom qdisc in BPF will feel it's worth it
to do the extra work to make this available via a second API. We could
certainly encourage it, and some things are easy (drop and pkt counters,
etc), but other things (like class stats) will depend on the semantics
of the qdisc being implemented, so will require extra work from the BPF
qdisc developer...
-Toke
next prev parent reply other threads:[~2021-09-03 14:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-21 1:02 [RFC Patch net-next] net_sched: introduce eBPF based Qdisc Cong Wang
2021-08-24 23:47 ` Martin KaFai Lau
2021-09-01 4:39 ` Cong Wang
2021-09-01 5:45 ` John Fastabend
2021-09-01 10:42 ` Toke Høiland-Jørgensen
2021-09-01 17:45 ` Martin KaFai Lau
2021-09-01 18:03 ` Alexei Starovoitov
2021-09-02 16:57 ` Toke Høiland-Jørgensen
2021-09-02 20:40 ` John Fastabend
2021-09-02 22:27 ` Toke Høiland-Jørgensen
2021-09-02 23:35 ` Martin KaFai Lau
2021-09-03 14:44 ` Toke Høiland-Jørgensen [this message]
2021-09-03 15:33 ` Jamal Hadi Salim
2021-09-10 6:55 ` Martin KaFai Lau
2021-09-10 11:31 ` Toke Høiland-Jørgensen
2021-09-04 1:09 ` Cong Wang
2021-09-17 4:19 ` Martin KaFai Lau
2021-09-04 1:30 ` Cong Wang
2021-09-06 11:45 ` Toke Høiland-Jørgensen
2021-09-04 1:05 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgstra6j.fsf@toke.dk \
--to=toke@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).