* [PATCH] bpf: btf: include linux/types.h for u32
@ 2024-04-14 4:51 Dmitrii Bundin
2024-04-15 12:11 ` Jiri Olsa
0 siblings, 1 reply; 13+ messages in thread
From: Dmitrii Bundin @ 2024-04-14 4:51 UTC (permalink / raw)
To: linux-kernel
Cc: bpf, jolsa, haoluo, sdf, kpsingh, john.fastabend, yonghong.song,
song, eddyz87, andrii, daniel, ast, martin.lau, khazhy, vmalik,
ndesaulniers, ncopa, dxu, Dmitrii Bundin
Inclusion of the header linux/btf_ids.h relies on indirect inclusion of
the header linux/types.h. Including it directly on the top level helps
to avoid potential problems if linux/types.h hasn't been included
before.
Signed-off-by: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
---
include/linux/btf_ids.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h
index e24aabfe8ecc..c0e3e1426a82 100644
--- a/include/linux/btf_ids.h
+++ b/include/linux/btf_ids.h
@@ -3,6 +3,8 @@
#ifndef _LINUX_BTF_IDS_H
#define _LINUX_BTF_IDS_H
+#include <linux/types.h> /* for u32 */
+
struct btf_id_set {
u32 cnt;
u32 ids[];
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] bpf: btf: include linux/types.h for u32
2024-04-14 4:51 [PATCH] bpf: btf: include linux/types.h for u32 Dmitrii Bundin
@ 2024-04-15 12:11 ` Jiri Olsa
2024-04-16 5:15 ` [PATCH bpf-next v2] " Dmitrii Bundin
2024-04-16 5:27 ` [PATCH] " Dmitrii Bundin
0 siblings, 2 replies; 13+ messages in thread
From: Jiri Olsa @ 2024-04-15 12:11 UTC (permalink / raw)
To: Dmitrii Bundin
Cc: linux-kernel, bpf, haoluo, sdf, kpsingh, john.fastabend,
yonghong.song, song, eddyz87, andrii, daniel, ast, martin.lau,
khazhy, vmalik, ndesaulniers, ncopa, dxu
please use '[PATCH bpf-next]' in subject
On Sun, Apr 14, 2024 at 07:51:24AM +0300, Dmitrii Bundin wrote:
> Inclusion of the header linux/btf_ids.h relies on indirect inclusion of
> the header linux/types.h. Including it directly on the top level helps
> to avoid potential problems if linux/types.h hasn't been included
> before.
>
> Signed-off-by: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
> ---
> include/linux/btf_ids.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h
> index e24aabfe8ecc..c0e3e1426a82 100644
> --- a/include/linux/btf_ids.h
> +++ b/include/linux/btf_ids.h
> @@ -3,6 +3,8 @@
> #ifndef _LINUX_BTF_IDS_H
> #define _LINUX_BTF_IDS_H
>
> +#include <linux/types.h> /* for u32 */
lgtm, did it actualy cause problem anywhere?
there's also tools/include/linux/btf_ids.h
jirka
> +
> struct btf_id_set {
> u32 cnt;
> u32 ids[];
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH bpf-next v2] bpf: btf: include linux/types.h for u32
2024-04-15 12:11 ` Jiri Olsa
@ 2024-04-16 5:15 ` Dmitrii Bundin
2024-04-16 7:23 ` Jiri Olsa
2024-04-16 5:27 ` [PATCH] " Dmitrii Bundin
1 sibling, 1 reply; 13+ messages in thread
From: Dmitrii Bundin @ 2024-04-16 5:15 UTC (permalink / raw)
To: olsajiri
Cc: andrii, ast, bpf, daniel, dmitrii.bundin.a, dxu, eddyz87, haoluo,
john.fastabend, khazhy, kpsingh, linux-kernel, martin.lau, ncopa,
ndesaulniers, sdf, song, vmalik, yonghong.song
Inclusion of the header linux/btf_ids.h relies on indirect inclusion of
the header linux/types.h. Including it directly on the top level helps
to avoid potential problems if linux/types.h hasn't been included
before.
Signed-off-by: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
---
Changes in v2: Add bpf-next to the subject
include/linux/btf_ids.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h
index e24aabfe8ecc..c0e3e1426a82 100644
--- a/include/linux/btf_ids.h
+++ b/include/linux/btf_ids.h
@@ -3,6 +3,8 @@
#ifndef _LINUX_BTF_IDS_H
#define _LINUX_BTF_IDS_H
+#include <linux/types.h> /* for u32 */
+
struct btf_id_set {
u32 cnt;
u32 ids[];
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] bpf: btf: include linux/types.h for u32
2024-04-15 12:11 ` Jiri Olsa
2024-04-16 5:15 ` [PATCH bpf-next v2] " Dmitrii Bundin
@ 2024-04-16 5:27 ` Dmitrii Bundin
2024-04-16 7:28 ` Jiri Olsa
1 sibling, 1 reply; 13+ messages in thread
From: Dmitrii Bundin @ 2024-04-16 5:27 UTC (permalink / raw)
To: Jiri Olsa
Cc: linux-kernel, bpf, haoluo, sdf, kpsingh, john.fastabend,
yonghong.song, song, eddyz87, andrii, daniel, ast, martin.lau,
khazhy, vmalik, ndesaulniers, ncopa, dxu
On Mon, Apr 15, 2024 at 3:11 PM Jiri Olsa <olsajiri@gmail.com> wrote:
> lgtm, did it actualy cause problem anywhere?
>
> there's also tools/include/linux/btf_ids.h
It caused the problems exactly in the file
tools/include/linux/btf_ids.h and was reported in
https://bugzilla.kernel.org/show_bug.cgi?id=218647
The patch including linux/types.h in tools/include/linux/btf_ids.h is
already there https://lore.kernel.org/all/20240328110103.28734-1-ncopa@alpinelinux.org/
I also faced the same compile-error of the form
error: unknown type name 'u32'
u32 cnt;
^~~
when compiling the bpf tool with glibc 2.28.
I think it might be reasonable to add the inclusion in
include/linux/btf_ids.h as well to prevent build problems like this.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH bpf-next v2] bpf: btf: include linux/types.h for u32
2024-04-16 5:15 ` [PATCH bpf-next v2] " Dmitrii Bundin
@ 2024-04-16 7:23 ` Jiri Olsa
0 siblings, 0 replies; 13+ messages in thread
From: Jiri Olsa @ 2024-04-16 7:23 UTC (permalink / raw)
To: Dmitrii Bundin
Cc: olsajiri, andrii, ast, bpf, daniel, dxu, eddyz87, haoluo,
john.fastabend, khazhy, kpsingh, linux-kernel, martin.lau, ncopa,
ndesaulniers, sdf, song, vmalik, yonghong.song
On Tue, Apr 16, 2024 at 08:15:27AM +0300, Dmitrii Bundin wrote:
> Inclusion of the header linux/btf_ids.h relies on indirect inclusion of
> the header linux/types.h. Including it directly on the top level helps
> to avoid potential problems if linux/types.h hasn't been included
> before.
>
> Signed-off-by: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
jirka
> ---
>
> Changes in v2: Add bpf-next to the subject
>
> include/linux/btf_ids.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h
> index e24aabfe8ecc..c0e3e1426a82 100644
> --- a/include/linux/btf_ids.h
> +++ b/include/linux/btf_ids.h
> @@ -3,6 +3,8 @@
> #ifndef _LINUX_BTF_IDS_H
> #define _LINUX_BTF_IDS_H
>
> +#include <linux/types.h> /* for u32 */
> +
> struct btf_id_set {
> u32 cnt;
> u32 ids[];
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] bpf: btf: include linux/types.h for u32
2024-04-16 5:27 ` [PATCH] " Dmitrii Bundin
@ 2024-04-16 7:28 ` Jiri Olsa
2024-04-16 14:47 ` Daniel Borkmann
0 siblings, 1 reply; 13+ messages in thread
From: Jiri Olsa @ 2024-04-16 7:28 UTC (permalink / raw)
To: Dmitrii Bundin
Cc: Jiri Olsa, linux-kernel, bpf, haoluo, sdf, kpsingh,
john.fastabend, yonghong.song, song, eddyz87, andrii, daniel,
ast, martin.lau, khazhy, vmalik, ndesaulniers, ncopa, dxu
On Tue, Apr 16, 2024 at 08:27:21AM +0300, Dmitrii Bundin wrote:
> On Mon, Apr 15, 2024 at 3:11 PM Jiri Olsa <olsajiri@gmail.com> wrote:
> > lgtm, did it actualy cause problem anywhere?
> >
> > there's also tools/include/linux/btf_ids.h
>
> It caused the problems exactly in the file
> tools/include/linux/btf_ids.h and was reported in
> https://bugzilla.kernel.org/show_bug.cgi?id=218647
> The patch including linux/types.h in tools/include/linux/btf_ids.h is
> already there https://lore.kernel.org/all/20240328110103.28734-1-ncopa@alpinelinux.org/
> I also faced the same compile-error of the form
>
> error: unknown type name 'u32'
> u32 cnt;
> ^~~
> when compiling the bpf tool with glibc 2.28.
>
> I think it might be reasonable to add the inclusion in
> include/linux/btf_ids.h as well to prevent build problems like this.
ok, it's in the bpf/master already
jirka
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] bpf: btf: include linux/types.h for u32
2024-04-16 7:28 ` Jiri Olsa
@ 2024-04-16 14:47 ` Daniel Borkmann
2024-04-17 6:26 ` Dmitrii Bundin
0 siblings, 1 reply; 13+ messages in thread
From: Daniel Borkmann @ 2024-04-16 14:47 UTC (permalink / raw)
To: Jiri Olsa, Dmitrii Bundin
Cc: linux-kernel, bpf, haoluo, sdf, kpsingh, john.fastabend,
yonghong.song, song, eddyz87, andrii, ast, martin.lau, khazhy,
vmalik, ndesaulniers, ncopa, dxu
On 4/16/24 9:28 AM, Jiri Olsa wrote:
> On Tue, Apr 16, 2024 at 08:27:21AM +0300, Dmitrii Bundin wrote:
>> On Mon, Apr 15, 2024 at 3:11 PM Jiri Olsa <olsajiri@gmail.com> wrote:
>>> lgtm, did it actualy cause problem anywhere?
>>>
>>> there's also tools/include/linux/btf_ids.h
>>
>> It caused the problems exactly in the file
>> tools/include/linux/btf_ids.h and was reported in
>> https://bugzilla.kernel.org/show_bug.cgi?id=218647
>> The patch including linux/types.h in tools/include/linux/btf_ids.h is
>> already there https://lore.kernel.org/all/20240328110103.28734-1-ncopa@alpinelinux.org/
>> I also faced the same compile-error of the form
>>
>> error: unknown type name 'u32'
>> u32 cnt;
>> ^~~
>> when compiling the bpf tool with glibc 2.28.
>>
>> I think it might be reasonable to add the inclusion in
>> include/linux/btf_ids.h as well to prevent build problems like this.
>
> ok, it's in the bpf/master already
Please add the error description as motivation aka "why" into the commit
description, otherwise it's not really obvious looking at it at a later
point in time why the include was needed.
Thanks,
Daniel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] bpf: btf: include linux/types.h for u32
2024-04-16 14:47 ` Daniel Borkmann
@ 2024-04-17 6:26 ` Dmitrii Bundin
2024-04-17 7:17 ` Jiri Olsa
0 siblings, 1 reply; 13+ messages in thread
From: Dmitrii Bundin @ 2024-04-17 6:26 UTC (permalink / raw)
To: Daniel Borkmann
Cc: Jiri Olsa, linux-kernel, bpf, haoluo, sdf, kpsingh,
john.fastabend, yonghong.song, song, eddyz87, andrii, ast,
martin.lau, khazhy, vmalik, ndesaulniers, ncopa, dxu
On Tue, Apr 16, 2024 at 5:47 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
> Please add the error description as motivation aka "why" into the commit
> description, otherwise it's not really obvious looking at it at a later
> point in time why the include was needed.
Doesn't the comment /* for u32 */ following the include explain the
purpose? I thought the include was actually missing since relying on
indirect declaration of u32 is relatively fragile.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] bpf: btf: include linux/types.h for u32
2024-04-17 6:26 ` Dmitrii Bundin
@ 2024-04-17 7:17 ` Jiri Olsa
2024-04-20 4:24 ` [PATCH bpf-next v3] " Dmitrii Bundin
0 siblings, 1 reply; 13+ messages in thread
From: Jiri Olsa @ 2024-04-17 7:17 UTC (permalink / raw)
To: Dmitrii Bundin
Cc: Daniel Borkmann, Jiri Olsa, linux-kernel, bpf, haoluo, sdf,
kpsingh, john.fastabend, yonghong.song, song, eddyz87, andrii,
ast, martin.lau, khazhy, vmalik, ndesaulniers, ncopa, dxu
On Wed, Apr 17, 2024 at 09:26:03AM +0300, Dmitrii Bundin wrote:
> On Tue, Apr 16, 2024 at 5:47 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
> > Please add the error description as motivation aka "why" into the commit
> > description, otherwise it's not really obvious looking at it at a later
> > point in time why the include was needed.
>
> Doesn't the comment /* for u32 */ following the include explain the
> purpose? I thought the include was actually missing since relying on
> indirect declaration of u32 is relatively fragile.
I think you can add similar descirption as for the already merged tool
change in bpf/master, and also include the Fixes/stable tags
commit 62248b22d01e96a4d669cde0d7005bd51ebf9e76
Author: Natanael Copa <ncopa@alpinelinux.org>
Date: Thu Mar 28 11:59:13 2024 +0100
tools/resolve_btfids: fix build with musl libc
Include the header that defines u32.
This fixes build of 6.6.23 and 6.1.83 kernels for Alpine Linux, which
uses musl libc. I assume that GNU libc indirecly pulls in linux/types.h.
Fixes: 9707ac4fe2f5 ("tools/resolve_btfids: Refactor set sorting with types from btf_ids.h")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218647
Cc: stable@vger.kernel.org
Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
Tested-by: Greg Thelen <gthelen@google.com>
Link: https://lore.kernel.org/r/20240328110103.28734-1-ncopa@alpinelinux.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
jirka
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH bpf-next v3] bpf: btf: include linux/types.h for u32
2024-04-17 7:17 ` Jiri Olsa
@ 2024-04-20 4:24 ` Dmitrii Bundin
2024-04-26 15:54 ` Daniel Borkmann
2024-04-29 23:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 13+ messages in thread
From: Dmitrii Bundin @ 2024-04-20 4:24 UTC (permalink / raw)
To: olsajiri
Cc: andrii, ast, bpf, daniel, dmitrii.bundin.a, dxu, eddyz87, haoluo,
john.fastabend, khazhy, kpsingh, linux-kernel, martin.lau, ncopa,
ndesaulniers, sdf, song, vmalik, yonghong.song
Inclusion of the header linux/btf_ids.h relies on indirect inclusion of
the header linux/types.h. Including it directly on the top level helps
to avoid potential problems if linux/types.h hasn't been included
before.
The main motiviation to introduce this it is to avoid similar problems that
was shown up in the bpf tool where GNU libc indirectly pulls
linux/types.h causing compile error of the form:
error: unknown type name 'u32'
u32 cnt;
^~~
The bpf tool compile error was fixed at 62248b22d01e96a4d669cde0d7005bd51ebf9e76
Fixes: 9707ac4fe2f5 ("tools/resolve_btfids: Refactor set sorting with types from btf_ids.h")
Signed-off-by: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
---
Changes in v2: Add bpf-next to the subject
Changes in v3: Add Fixes tag and bpf tool commit reference
include/linux/btf_ids.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h
index e24aabfe8ecc..c0e3e1426a82 100644
--- a/include/linux/btf_ids.h
+++ b/include/linux/btf_ids.h
@@ -3,6 +3,8 @@
#ifndef _LINUX_BTF_IDS_H
#define _LINUX_BTF_IDS_H
+#include <linux/types.h> /* for u32 */
+
struct btf_id_set {
u32 cnt;
u32 ids[];
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH bpf-next v3] bpf: btf: include linux/types.h for u32
2024-04-20 4:24 ` [PATCH bpf-next v3] " Dmitrii Bundin
@ 2024-04-26 15:54 ` Daniel Borkmann
2024-04-29 23:33 ` Andrii Nakryiko
2024-04-29 23:40 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 13+ messages in thread
From: Daniel Borkmann @ 2024-04-26 15:54 UTC (permalink / raw)
To: Dmitrii Bundin, olsajiri
Cc: andrii, ast, bpf, dxu, eddyz87, haoluo, john.fastabend, khazhy,
kpsingh, linux-kernel, martin.lau, ncopa, ndesaulniers, sdf,
song, vmalik, yonghong.song
On 4/20/24 6:24 AM, Dmitrii Bundin wrote:
> Inclusion of the header linux/btf_ids.h relies on indirect inclusion of
> the header linux/types.h. Including it directly on the top level helps
> to avoid potential problems if linux/types.h hasn't been included
> before.
>
> The main motiviation to introduce this it is to avoid similar problems that
nit: spelling
> was shown up in the bpf tool where GNU libc indirectly pulls
> linux/types.h causing compile error of the form:
>
> error: unknown type name 'u32'
> u32 cnt;
> ^~~
>
> The bpf tool compile error was fixed at 62248b22d01e96a4d669cde0d7005bd51ebf9e76
>
> Fixes: 9707ac4fe2f5 ("tools/resolve_btfids: Refactor set sorting with types from btf_ids.h")
>
> Signed-off-by: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
> ---
>
> Changes in v2: Add bpf-next to the subject
> Changes in v3: Add Fixes tag and bpf tool commit reference
>
> include/linux/btf_ids.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h
> index e24aabfe8ecc..c0e3e1426a82 100644
> --- a/include/linux/btf_ids.h
> +++ b/include/linux/btf_ids.h
> @@ -3,6 +3,8 @@
> #ifndef _LINUX_BTF_IDS_H
> #define _LINUX_BTF_IDS_H
>
> +#include <linux/types.h> /* for u32 */
> +
> struct btf_id_set {
> u32 cnt;
> u32 ids[];
>
Lgtm, not sure if its worth it but also doesn't hurt and aligns the header
from tooling a bit closer to the kernel one. Just to clarify, this does not
fix a concrete issue today, so small 'cleanup' rather than 'fix'.
Thanks,
Daniel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH bpf-next v3] bpf: btf: include linux/types.h for u32
2024-04-26 15:54 ` Daniel Borkmann
@ 2024-04-29 23:33 ` Andrii Nakryiko
0 siblings, 0 replies; 13+ messages in thread
From: Andrii Nakryiko @ 2024-04-29 23:33 UTC (permalink / raw)
To: Daniel Borkmann
Cc: Dmitrii Bundin, olsajiri, andrii, ast, bpf, dxu, eddyz87, haoluo,
john.fastabend, khazhy, kpsingh, linux-kernel, martin.lau, ncopa,
ndesaulniers, sdf, song, vmalik, yonghong.song
On Fri, Apr 26, 2024 at 8:54 AM Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> On 4/20/24 6:24 AM, Dmitrii Bundin wrote:
> > Inclusion of the header linux/btf_ids.h relies on indirect inclusion of
> > the header linux/types.h. Including it directly on the top level helps
> > to avoid potential problems if linux/types.h hasn't been included
> > before.
> >
> > The main motiviation to introduce this it is to avoid similar problems that
>
> nit: spelling
>
> > was shown up in the bpf tool where GNU libc indirectly pulls
> > linux/types.h causing compile error of the form:
> >
> > error: unknown type name 'u32'
> > u32 cnt;
> > ^~~
> >
> > The bpf tool compile error was fixed at 62248b22d01e96a4d669cde0d7005bd51ebf9e76
> >
> > Fixes: 9707ac4fe2f5 ("tools/resolve_btfids: Refactor set sorting with types from btf_ids.h")
> >
> > Signed-off-by: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
> > ---
> >
> > Changes in v2: Add bpf-next to the subject
> > Changes in v3: Add Fixes tag and bpf tool commit reference
> >
> > include/linux/btf_ids.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h
> > index e24aabfe8ecc..c0e3e1426a82 100644
> > --- a/include/linux/btf_ids.h
> > +++ b/include/linux/btf_ids.h
> > @@ -3,6 +3,8 @@
> > #ifndef _LINUX_BTF_IDS_H
> > #define _LINUX_BTF_IDS_H
> >
> > +#include <linux/types.h> /* for u32 */
> > +
> > struct btf_id_set {
> > u32 cnt;
> > u32 ids[];
> >
>
> Lgtm, not sure if its worth it but also doesn't hurt and aligns the header
> from tooling a bit closer to the kernel one. Just to clarify, this does not
> fix a concrete issue today, so small 'cleanup' rather than 'fix'.
>
Adjusted commit message and pushed to bpf-next, thanks.
> Thanks,
> Daniel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH bpf-next v3] bpf: btf: include linux/types.h for u32
2024-04-20 4:24 ` [PATCH bpf-next v3] " Dmitrii Bundin
2024-04-26 15:54 ` Daniel Borkmann
@ 2024-04-29 23:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 13+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-04-29 23:40 UTC (permalink / raw)
To: Dmitrii Bundin
Cc: olsajiri, andrii, ast, bpf, daniel, dxu, eddyz87, haoluo,
john.fastabend, khazhy, kpsingh, linux-kernel, martin.lau, ncopa,
ndesaulniers, sdf, song, vmalik, yonghong.song
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Sat, 20 Apr 2024 07:24:57 +0300 you wrote:
> Inclusion of the header linux/btf_ids.h relies on indirect inclusion of
> the header linux/types.h. Including it directly on the top level helps
> to avoid potential problems if linux/types.h hasn't been included
> before.
>
> The main motiviation to introduce this it is to avoid similar problems that
> was shown up in the bpf tool where GNU libc indirectly pulls
> linux/types.h causing compile error of the form:
>
> [...]
Here is the summary with links:
- [bpf-next,v3] bpf: btf: include linux/types.h for u32
https://git.kernel.org/bpf/bpf-next/c/cfd3bfe9507b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2024-04-29 23:40 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-14 4:51 [PATCH] bpf: btf: include linux/types.h for u32 Dmitrii Bundin
2024-04-15 12:11 ` Jiri Olsa
2024-04-16 5:15 ` [PATCH bpf-next v2] " Dmitrii Bundin
2024-04-16 7:23 ` Jiri Olsa
2024-04-16 5:27 ` [PATCH] " Dmitrii Bundin
2024-04-16 7:28 ` Jiri Olsa
2024-04-16 14:47 ` Daniel Borkmann
2024-04-17 6:26 ` Dmitrii Bundin
2024-04-17 7:17 ` Jiri Olsa
2024-04-20 4:24 ` [PATCH bpf-next v3] " Dmitrii Bundin
2024-04-26 15:54 ` Daniel Borkmann
2024-04-29 23:33 ` Andrii Nakryiko
2024-04-29 23:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).