From: Sedat Dilek <sedat.dilek@gmail.com>
To: Yonghong Song <yhs@fb.com>
Cc: bpf@vger.kernel.org, Andrii Nakryiko <andrii@kernel.org>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
kernel-team@fb.com, Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH bpf-next 0/5] support build selftests/bpf with clang
Date: Sat, 10 Apr 2021 21:19:21 +0200 [thread overview]
Message-ID: <CA+icZUVz0US1y7LSkk_cvq5bOrTok0LqVSCLkUukmyde5aChpA@mail.gmail.com> (raw)
In-Reply-To: <20210410164925.768741-1-yhs@fb.com>
On Sat, Apr 10, 2021 at 6:49 PM Yonghong Song <yhs@fb.com> wrote:
>
> To build kernel with clang, people typically use
> make -j60 LLVM=1 LLVM_IAS=1
> LLVM_IAS=1 is not required for non-LTO build but
> is required for LTO build. In my environment,
> I am always having LLVM_IAS=1 regardless of
> whether LTO is enabled or not.
>
> After kernel is build with clang, the following command
> can be used to build selftests with clang:
> make -j60 -C tools/testing/selftests/bpf LLVM=1 LLVM_IAS=1
>
> But currently, some compilations still use gcc
> and there are also compilation errors and warnings.
> This patch set intends to fix these issues.
> Patch #1 and #2 fixed the issue so clang/clang++ is
> used instead of gcc/g++. Patch #3 fixed a compilation
> failure. Patch #4 and #5 fixed various compiler warnings.
>
> Yonghong Song (5):
> selftests: set CC to clang in lib.mk if LLVM is set
> tools: allow proper CC/CXX/... override with LLVM=1 in
> Makefile.include
> selftests/bpf: fix test_cpp compilation failure with clang
> selftests/bpf: silence clang compilation warnings
> bpftool: fix a clang compilation warning
>
> tools/bpf/bpftool/net.c | 2 +-
> tools/scripts/Makefile.include | 12 ++++++++++--
> tools/testing/selftests/bpf/Makefile | 4 +++-
> tools/testing/selftests/lib.mk | 4 ++++
> 4 files changed, 18 insertions(+), 4 deletions(-)
>
> --
> 2.30.2
>
Thanks for CCing me and taking care to clean BPF selftests with clang.
I applied (adapted 4/5) the 5 patches to fit latest Linus Git.
As I had a fresh compiled Clang-CFI kernel without enabling BTF
debug-info KConfig this fails at some point.
I am not sure what the situation is with Clang-CFI + BTF thus I will
do another Clang-LTO build with BTF enabled.
So, I was not able to build test_cpp.
I am missing some comments that LLVM=1 misses to set CXX=clang++ if
people want that explicitly as CXX.
Did you try with this?
AFAICS LC_ALL=C was not the culprit.
Did you try with and without LC_ALL=C - I have this in all my build-scripts.
Here I have German localisation as default.
Wil report later... (might be Monday when Linux v5.12-rc7 is released).
- Sedat -
next prev parent reply other threads:[~2021-04-10 19:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 16:49 [PATCH bpf-next 0/5] support build selftests/bpf with clang Yonghong Song
2021-04-10 16:49 ` [PATCH bpf-next 1/5] selftests: set CC to clang in lib.mk if LLVM is set Yonghong Song
2021-04-11 10:22 ` Sedat Dilek
2021-04-11 16:51 ` Yonghong Song
2021-04-11 17:10 ` Sedat Dilek
2021-04-10 16:49 ` [PATCH bpf-next 2/5] tools: allow proper CC/CXX/... override with LLVM=1 in Makefile.include Yonghong Song
2021-04-11 10:24 ` Sedat Dilek
2021-04-11 16:52 ` Yonghong Song
2021-04-10 16:49 ` [PATCH bpf-next 3/5] selftests/bpf: fix test_cpp compilation failure with clang Yonghong Song
2021-04-11 10:47 ` Sedat Dilek
2021-04-11 17:20 ` Yonghong Song
2021-04-11 17:31 ` Sedat Dilek
2021-04-11 19:08 ` Yonghong Song
2021-04-12 4:47 ` Sedat Dilek
2021-04-12 5:42 ` Yonghong Song
2021-04-12 6:06 ` Sedat Dilek
2021-04-12 14:15 ` Yonghong Song
2021-04-13 4:32 ` Andrii Nakryiko
2021-04-13 6:12 ` Yonghong Song
2021-04-13 17:50 ` Andrii Nakryiko
2021-04-10 16:49 ` [PATCH bpf-next 4/5] selftests/bpf: silence clang compilation warnings Yonghong Song
2021-04-11 11:12 ` Sedat Dilek
2021-04-11 17:40 ` Yonghong Song
2021-04-10 16:49 ` [PATCH bpf-next 5/5] bpftool: fix a clang compilation warning Yonghong Song
2021-04-11 11:05 ` Sedat Dilek
2021-04-11 17:24 ` Yonghong Song
2021-04-10 17:23 ` [PATCH bpf-next 0/5] support build selftests/bpf with clang Alexei Starovoitov
2021-04-10 17:38 ` Yonghong Song
2021-04-10 19:19 ` Sedat Dilek [this message]
2021-04-11 16:46 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+icZUVz0US1y7LSkk_cvq5bOrTok0LqVSCLkUukmyde5aChpA@mail.gmail.com \
--to=sedat.dilek@gmail.com \
--cc=andrii@kernel.org \
--cc=arnaldo.melo@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=ndesaulniers@google.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).