From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Yonghong Song <yhs@fb.com>
Cc: bpf <bpf@vger.kernel.org>, Andrii Nakryiko <andrii@kernel.org>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Kernel Team <kernel-team@fb.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Sedat Dilek <sedat.dilek@gmail.com>
Subject: Re: [PATCH bpf-next 3/5] selftests/bpf: fix test_cpp compilation failure with clang
Date: Tue, 13 Apr 2021 10:50:18 -0700 [thread overview]
Message-ID: <CAEf4BzaxPGYvy1y=4Q4fCAwGD7Bzw1Mwz55hpQ6R4kXM8e3V1Q@mail.gmail.com> (raw)
In-Reply-To: <0d97da89-4e29-7274-4970-ce6f79a43242@fb.com>
On Mon, Apr 12, 2021 at 11:12 PM Yonghong Song <yhs@fb.com> wrote:
>
>
>
> On 4/12/21 9:32 PM, Andrii Nakryiko wrote:
> > On Sat, Apr 10, 2021 at 9:49 AM Yonghong Song <yhs@fb.com> wrote:
> >>
> >> With clang compiler:
> >> make -j60 LLVM=1 LLVM_IAS=1 <=== compile kernel
> >> make -j60 -C tools/testing/selftests/bpf LLVM=1 LLVM_IAS=1
> >> the test_cpp build failed due to the failure:
> >> warning: treating 'c-header' input as 'c++-header' when in C++ mode, this behavior is deprecated [-Wdeprecated]
> >> clang-13: warning: cannot specify -o when generating multiple output files
> >>
> >> test_cpp compilation flag looks like:
> >> clang++ -g -Og -rdynamic -Wall -I<...> ... \
> >> -Dbpf_prog_load=bpf_prog_test_load -Dbpf_load_program=bpf_test_load_program \
> >> test_cpp.cpp <...>/test_core_extern.skel.h <...>/libbpf.a <...>/test_stub.o \
> >> -lcap -lelf -lz -lrt -lpthread -o <...>/test_cpp
> >>
> >> The clang++ compiler complains the header file in the command line.
> >> Let us remove the header file from the command line which is not intended
> >> any way, and this fixed the problem.
> >>
> >> Signed-off-by: Yonghong Song <yhs@fb.com>
> >> ---
> >> tools/testing/selftests/bpf/Makefile | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> >> index 6448c626498f..bbd61cc3889b 100644
> >> --- a/tools/testing/selftests/bpf/Makefile
> >> +++ b/tools/testing/selftests/bpf/Makefile
> >> @@ -481,7 +481,7 @@ $(OUTPUT)/test_verifier: test_verifier.c verifier/tests.h $(BPFOBJ) | $(OUTPUT)
> >> # Make sure we are able to include and link libbpf against c++.
> >> $(OUTPUT)/test_cpp: test_cpp.cpp $(OUTPUT)/test_core_extern.skel.h $(BPFOBJ)
> >> $(call msg,CXX,,$@)
> >> - $(Q)$(CXX) $(CFLAGS) $^ $(LDLIBS) -o $@
> >> + $(Q)$(CXX) $(CFLAGS) test_cpp.cpp $(BPFOBJ) $(LDLIBS) -o $@
> >
> > see what we do for other binaries:
> >
> > $(filter %.a %.o %.c,$^)
> >
> > It's more generic. Add %.cpp, of course.
>
> Okay, although I will remove %.c.
>
> [yhs@devbig003.ftw2 ~/tmp/tmp2]$ clang++ -c t.c
> clang-13: warning: treating 'c' input as 'c++' when in C++ mode, this
> behavior is deprecated [-Wdeprecated]
> [yhs@devbig003.ftw2 ~/tmp/tmp2]$
>
> clang++ will warn if trying to compile .c file.
> g++ 8.4.1 doesn't warn. Not sure about latest g++. But it is not
> a good practice to compile .c files with c++ compiler any way.
yeah, makes sense
>
> >
> >>
> >> # Benchmark runner
> >> $(OUTPUT)/bench_%.o: benchs/bench_%.c bench.h
> >> --
> >> 2.30.2
> >>
next prev parent reply other threads:[~2021-04-13 17:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 16:49 [PATCH bpf-next 0/5] support build selftests/bpf with clang Yonghong Song
2021-04-10 16:49 ` [PATCH bpf-next 1/5] selftests: set CC to clang in lib.mk if LLVM is set Yonghong Song
2021-04-11 10:22 ` Sedat Dilek
2021-04-11 16:51 ` Yonghong Song
2021-04-11 17:10 ` Sedat Dilek
2021-04-10 16:49 ` [PATCH bpf-next 2/5] tools: allow proper CC/CXX/... override with LLVM=1 in Makefile.include Yonghong Song
2021-04-11 10:24 ` Sedat Dilek
2021-04-11 16:52 ` Yonghong Song
2021-04-10 16:49 ` [PATCH bpf-next 3/5] selftests/bpf: fix test_cpp compilation failure with clang Yonghong Song
2021-04-11 10:47 ` Sedat Dilek
2021-04-11 17:20 ` Yonghong Song
2021-04-11 17:31 ` Sedat Dilek
2021-04-11 19:08 ` Yonghong Song
2021-04-12 4:47 ` Sedat Dilek
2021-04-12 5:42 ` Yonghong Song
2021-04-12 6:06 ` Sedat Dilek
2021-04-12 14:15 ` Yonghong Song
2021-04-13 4:32 ` Andrii Nakryiko
2021-04-13 6:12 ` Yonghong Song
2021-04-13 17:50 ` Andrii Nakryiko [this message]
2021-04-10 16:49 ` [PATCH bpf-next 4/5] selftests/bpf: silence clang compilation warnings Yonghong Song
2021-04-11 11:12 ` Sedat Dilek
2021-04-11 17:40 ` Yonghong Song
2021-04-10 16:49 ` [PATCH bpf-next 5/5] bpftool: fix a clang compilation warning Yonghong Song
2021-04-11 11:05 ` Sedat Dilek
2021-04-11 17:24 ` Yonghong Song
2021-04-10 17:23 ` [PATCH bpf-next 0/5] support build selftests/bpf with clang Alexei Starovoitov
2021-04-10 17:38 ` Yonghong Song
2021-04-10 19:19 ` Sedat Dilek
2021-04-11 16:46 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzaxPGYvy1y=4Q4fCAwGD7Bzw1Mwz55hpQ6R4kXM8e3V1Q@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=arnaldo.melo@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=ndesaulniers@google.com \
--cc=sedat.dilek@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).