Re: [RFT] pahole 1.20 RC was Re: [PATCH] btf_encoder: Add extra checks for symbol names

From: Sedat Dilek <sedat.dilek@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: "Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
	"Tom Stellard" <tstellar@redhat.com>,
	"Jiri Olsa" <jolsa@kernel.org>,
	dwarves@vger.kernel.org, bpf <bpf@vger.kernel.org>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Andrii Nakryiko" <andriin@fb.com>, "Yonghong Song" <yhs@fb.com>,
	"Hao Luo" <haoluo@google.com>, "Mark Wielaard" <mark@klomp.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [RFT] pahole 1.20 RC was Re: [PATCH] btf_encoder: Add extra checks for symbol names
Date: Thu, 28 Jan 2021 23:28:10 +0100	[thread overview]
Message-ID: <CA+icZUWsMKXZSZN9MSY-uCuCa_WVFLjn2JqkaM9e2zwS1A8Z8A@mail.gmail.com> (raw)
In-Reply-To: <20210128211120.GB794568@kernel.org>

On Thu, Jan 28, 2021 at 10:11 PM Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
>
> Em Thu, Jan 28, 2021 at 09:57:14PM +0100, Sedat Dilek escreveu:
> > On Thu, Jan 28, 2021 at 9:00 PM Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> wrote:
>
> > > Em Thu, Jan 21, 2021 at 08:11:17PM -0800, Andrii Nakryiko escreveu:
> > > > On Thu, Jan 21, 2021 at 6:07 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
> > > > > Do you want Nick's DWARF v5 patch-series as a base?
>
> > > > Arnaldo was going to figure out the DWARF v5 problem, so I'm leaving
> > > > it up to him. I'm curious about DWARF v4 problems because no one yet
> > > > reported that previously.
>
> > > I think I have the reported one fixed, Andrii, can you please do
> > > whatever pre-release tests you can in your environment with what is in:
>
> > > https://git.kernel.org/pub/scm/devel/pahole/pahole.git/log/?h=DW_AT_data_bit_offset
>
> > > ?
>
> > > The cset has the tests I performed and the references to the bugzilla
> > > ticket and Daniel has tested as well for his XDR + gcc 11 problem.
> >
> > What Git tree should someone use to test this?
> > Linus Git?
> > bpf / bpf-next?
>
> The one you were having problems with :)
>
> This pahole branch should be handling multiple problems, this is the
> list of changes since v1.19:
>
> [acme@five pahole]$ git log --oneline v1.19..
> b91b19840b0062b8 (HEAD -> master, quaco/master, origin/DW_AT_data_bit_offset) dwarf_loader: Support DW_AT_data_bit_offset
> c692e8ac5ccbab99 dwarf_loader: Optimize a bit the reading of DW_AT_data_member_location
> 65917b24942ce620 dwarf_loader: Fix typo
> 77205a119c85e396 dwarf_loader: Introduce __attr_offset() to reuse call to dwarf_attr()
> 8ec231f6b0c8aaef dwarf_loader: Support DW_FORM_implicit_const in attr_numeric()
> 7453895e01edb535 (origin/master, origin/HEAD) btf_encoder: Improve ELF error reporting
> 1bb49897dd2b65b0 bpf_encoder: Translate SHN_XINDEX in symbol's st_shndx values
> 3f8aad340bf1a188 elf_symtab: Handle SHN_XINDEX index in elf_section_by_name()
> e32b9800e650a6eb btf_encoder: Add extra checks for symbol names
> 82749180b23d3c9c libbpf: allow to use packaged version
> 452dbcf35f1a7bf9 btf_encoder: Improve error-handling around objcopy
> cf381f9a3822d68b btf_encoder: Fix handling of restrict qualifier
> b688e35970600c15 btf_encoder: fix skipping per-CPU variables at offset 0
> 8c009d6ce762dfc9 btf_encoder: fix BTF variable generation for kernel modules
> b94e97e015a94e6b dwarves: Fix compilation on 32-bit architectures
> 17df51c700248f02 btf_encoder: Detect kernel module ftrace addresses
> 06ca639505fc56c6 btf_encoder: Use address size based on ELF's class
> aff60970d16b909e btf_encoder: Factor filter_functions function
> 1e6a3fed6e52d365 rpm: Fix changelog date
> [acme@five pahole]$
>
> Now I just need to do the boilerplate update of the version number,
> Changes and .spec file, to release v1.20.
>

When do you plan to release v1.20?
I can wait until this is done.

- Sedat -