From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
LKML <linux-kernel@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>
Subject: Re: [PATCH] tracing/probe: Fix bpf_task_fd_query() for kprobes and uprobes
Date: Tue, 9 Jun 2020 11:18:57 -0700 [thread overview]
Message-ID: <CAADnVQ+1CsKo1wdY6hUwExP8dnCBDhjoWCjoHp-jTvOoghPh4w@mail.gmail.com> (raw)
In-Reply-To: <20200609161234.c0b1460e6a6ce73ba478a22a@kernel.org>
On Tue, Jun 9, 2020 at 12:12 AM Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> On Mon, 8 Jun 2020 14:45:32 +0200
> Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:
>
> > Commit 60d53e2c3b75 ("tracing/probe: Split trace_event related data from
> > trace_probe") removed the trace_[ku]probe structure from the
> > trace_event_call->data pointer. As bpf_get_[ku]probe_info() were
> > forgotten in that change, fix them now. These functions are currently
> > only used by the bpf_task_fd_query() syscall handler to collect
> > information about a perf event.
> >
>
> Oops, good catch!
>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>
>
> > Fixes: 60d53e2c3b75 ("tracing/probe: Split trace_event related data from trace_probe")
> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
>
> Cc: stable@vger.kernel.org
Applied to bpf tree. Thanks
prev parent reply other threads:[~2020-06-09 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 12:45 [PATCH] tracing/probe: Fix bpf_task_fd_query() for kprobes and uprobes Jean-Philippe Brucker
2020-06-08 15:24 ` Yonghong Song
2020-06-09 7:12 ` Masami Hiramatsu
2020-06-09 18:18 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQ+1CsKo1wdY6hUwExP8dnCBDhjoWCjoHp-jTvOoghPh4w@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jean-philippe@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).