* [PATCH bpf-next] samples/bpf: Add missing -lz to TPROGS_LDLIBS
@ 2019-12-16 10:24 Toke Høiland-Jørgensen
2019-12-16 12:16 ` Björn Töpel
0 siblings, 1 reply; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2019-12-16 10:24 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann
Cc: Toke Høiland-Jørgensen, netdev, bpf
Since libbpf now links against zlib, this needs to be included in the
linker invocation for the userspace programs in samples/bpf that link
statically against libbpf.
Fixes: 166750bc1dd2 ("libbpf: Support libbpf-provided extern variables")
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
---
samples/bpf/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
index 1fc42ad8ff49..b00651608765 100644
--- a/samples/bpf/Makefile
+++ b/samples/bpf/Makefile
@@ -196,7 +196,7 @@ endif
TPROGCFLAGS_bpf_load.o += -Wno-unused-variable
-TPROGS_LDLIBS += $(LIBBPF) -lelf
+TPROGS_LDLIBS += $(LIBBPF) -lelf -lz
TPROGLDLIBS_tracex4 += -lrt
TPROGLDLIBS_trace_output += -lrt
TPROGLDLIBS_map_perf_test += -lrt
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] samples/bpf: Add missing -lz to TPROGS_LDLIBS
2019-12-16 10:24 [PATCH bpf-next] samples/bpf: Add missing -lz to TPROGS_LDLIBS Toke Høiland-Jørgensen
@ 2019-12-16 12:16 ` Björn Töpel
2019-12-16 14:59 ` Alexei Starovoitov
0 siblings, 1 reply; 3+ messages in thread
From: Björn Töpel @ 2019-12-16 12:16 UTC (permalink / raw)
To: Toke Høiland-Jørgensen
Cc: Alexei Starovoitov, Daniel Borkmann, Netdev, bpf
On Mon, 16 Dec 2019 at 11:24, Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>
> Since libbpf now links against zlib, this needs to be included in the
> linker invocation for the userspace programs in samples/bpf that link
> statically against libbpf.
>
> Fixes: 166750bc1dd2 ("libbpf: Support libbpf-provided extern variables")
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Thanks Toke!
Tested-by: Björn Töpel <bjorn.topel@intel.com>
> ---
> samples/bpf/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
> index 1fc42ad8ff49..b00651608765 100644
> --- a/samples/bpf/Makefile
> +++ b/samples/bpf/Makefile
> @@ -196,7 +196,7 @@ endif
>
> TPROGCFLAGS_bpf_load.o += -Wno-unused-variable
>
> -TPROGS_LDLIBS += $(LIBBPF) -lelf
> +TPROGS_LDLIBS += $(LIBBPF) -lelf -lz
> TPROGLDLIBS_tracex4 += -lrt
> TPROGLDLIBS_trace_output += -lrt
> TPROGLDLIBS_map_perf_test += -lrt
> --
> 2.24.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] samples/bpf: Add missing -lz to TPROGS_LDLIBS
2019-12-16 12:16 ` Björn Töpel
@ 2019-12-16 14:59 ` Alexei Starovoitov
0 siblings, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2019-12-16 14:59 UTC (permalink / raw)
To: Björn Töpel
Cc: Toke Høiland-Jørgensen, Alexei Starovoitov,
Daniel Borkmann, Netdev, bpf
On Mon, Dec 16, 2019 at 4:16 AM Björn Töpel <bjorn.topel@gmail.com> wrote:
>
> On Mon, 16 Dec 2019 at 11:24, Toke Høiland-Jørgensen <toke@redhat.com> wrote:
> >
> > Since libbpf now links against zlib, this needs to be included in the
> > linker invocation for the userspace programs in samples/bpf that link
> > statically against libbpf.
> >
> > Fixes: 166750bc1dd2 ("libbpf: Support libbpf-provided extern variables")
> > Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
> Thanks Toke!
>
> Tested-by: Björn Töpel <bjorn.topel@intel.com>
Applied. Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-16 14:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-16 10:24 [PATCH bpf-next] samples/bpf: Add missing -lz to TPROGS_LDLIBS Toke Høiland-Jørgensen
2019-12-16 12:16 ` Björn Töpel
2019-12-16 14:59 ` Alexei Starovoitov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).