From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
stable <stable@vger.kernel.org>, Chen Yu <yu.chen.surf@gmail.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andrii@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Kees Cook <keescook@chromium.org>, Marco Elver <elver@google.com>,
Arvind Sankar <nivedita@alum.mit.edu>,
Randy Dunlap <rdunlap@infradead.org>,
Sami Tolvanen <samitolvanen@google.com>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>,
Clang-Built-Linux ML <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] compiler-clang: remove version check for BPF Tracing
Date: Thu, 5 Nov 2020 20:16:44 -0800 [thread overview]
Message-ID: <CAADnVQL_mP7HNz1n+=S7Tjk8f7efm3_w5+VQVptD2y7Wts_Mig@mail.gmail.com> (raw)
In-Reply-To: <20201104191052.390657-1-ndesaulniers@google.com>
On Wed, Nov 4, 2020 at 11:11 AM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> bpftrace parses the kernel headers and uses Clang under the hood. Remove
> the version check when __BPF_TRACING__ is defined (as bpftrace does) so
> that this tool can continue to parse kernel headers, even with older
> clang sources.
>
> Cc: <stable@vger.kernel.org>
> Fixes: commit 1f7a44f63e6c ("compiler-clang: add build check for clang 10.0.1")
> Reported-by: Chen Yu <yu.chen.surf@gmail.com>
> Reported-by: Jarkko Sakkinen <jarkko@kernel.org>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> include/linux/compiler-clang.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h
> index dd7233c48bf3..98cff1b4b088 100644
> --- a/include/linux/compiler-clang.h
> +++ b/include/linux/compiler-clang.h
> @@ -8,8 +8,10 @@
> + __clang_patchlevel__)
>
> #if CLANG_VERSION < 100001
> +#ifndef __BPF_TRACING__
> # error Sorry, your version of Clang is too old - please use 10.0.1 or newer.
> #endif
> +#endif
I can take it through the bpf tree if no one objects.
next prev parent reply other threads:[~2020-11-06 4:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 19:10 [PATCH] compiler-clang: remove version check for BPF Tracing Nick Desaulniers
2020-11-04 20:33 ` Jarkko Sakkinen
2020-11-05 0:25 ` Song Liu
2020-11-05 0:51 ` Andrew Morton
2020-11-05 0:56 ` Nathan Chancellor
2020-11-05 2:22 ` Miguel Ojeda
2020-11-06 4:16 ` Alexei Starovoitov [this message]
2020-11-06 18:52 ` Nick Desaulniers
2020-11-06 22:32 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADnVQL_mP7HNz1n+=S7Tjk8f7efm3_w5+VQVptD2y7Wts_Mig@mail.gmail.com' \
--to=alexei.starovoitov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel@iogearbox.net \
--cc=elver@google.com \
--cc=jarkko@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=nivedita@alum.mit.edu \
--cc=rdunlap@infradead.org \
--cc=samitolvanen@google.com \
--cc=songliubraving@fb.com \
--cc=stable@vger.kernel.org \
--cc=yhs@fb.com \
--cc=yu.chen.surf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).