From: Zvi Effron <zeffron@riotgames.com>
To: Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
brouer@redhat.com, "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Lorenzo Bianconi" <lorenzo.bianconi@redhat.com>,
"Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Shay Agroskin" <shayagr@amazon.com>,
"john fastabend" <john.fastabend@gmail.com>,
"David Ahern" <dsahern@kernel.org>,
"Eelco Chaudron" <echaudro@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Alexander Duyck" <alexander.duyck@gmail.com>,
"Saeed Mahameed" <saeed@kernel.org>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
tirthendu.sarkar@intel.com
Subject: Re: [PATCH v21 bpf-next 18/23] libbpf: Add SEC name for xdp_mb programs
Date: Fri, 14 Jan 2022 10:55:24 -0800 [thread overview]
Message-ID: <CAC1LvL3M9OaSanES0uzp=vvgK23qPGRPpcAR6Z_Vqcvma3K5Qg@mail.gmail.com> (raw)
In-Reply-To: <e86ccea8-af77-83bf-e90e-dce88b26f07c@redhat.com>
On Fri, Jan 14, 2022 at 8:50 AM Jesper Dangaard Brouer
<jbrouer@redhat.com> wrote:
>
>
>
> On 14/01/2022 03.09, Alexei Starovoitov wrote:
> > On Thu, Jan 13, 2022 at 3:58 PM Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> >>>
> >>> Btw "xdp_cpumap" should be cleaned up.
> >>> xdp_cpumap is an attach type. It's not prog type.
> >>> Probably it should be "xdp/cpumap" to align with "cgroup/bind[46]" ?
> >>
> >> so for xdp "mb" or xdp "frags" it will be xdp/cpumap.mb (xdp/devmap.mb) or
> >> xdp/cpumap.frags (xdp/devmap.frags), right?
> >
> > xdp.frags/cpumap
> > xdp.frags/devmap
> >
> > The current de-facto standard for SEC("") in libbpf:
> > prog_type.prog_flags/attach_place
>
> Ups, did we make a mistake with SEC("xdp_devmap/")
>
> and can we correct without breaking existing programs?
>
We can (at the very least) add the correct sections, even if we leave the
current incorrect ones as well. Ideally we'd mark the incorrect ones deprecated
and either remove them before libbpf 1.0 or as part of 2.0?
--Zvi
> > "attach_place" is either function_name for fentry/, tp/, lsm/, etc.
> > or attach_type/hook/target for cgroup/bind4, cgroup_skb/egress.
> >
> > lsm.s/socket_bind -> prog_type = LSM, flags = SLEEPABLE
> > lsm/socket_bind -> prog_type = LSM, non sleepable.
> >
>
next prev parent reply other threads:[~2022-01-14 18:55 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 11:53 [PATCH v21 bpf-next 00/23] mvneta: introduce XDP multi-buffer support Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 01/23] net: skbuff: add size metadata to skb_shared_info for xdp Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 02/23] xdp: introduce flags field in xdp_buff/xdp_frame Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 03/23] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 04/23] net: mvneta: simplify mvneta_swbm_add_rx_fragment management Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 05/23] net: xdp: add xdp_update_skb_shared_info utility routine Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 06/23] net: marvell: rely on " Lorenzo Bianconi
2022-01-10 16:37 ` Andy Gospodarek
2022-01-11 13:05 ` Lorenzo Bianconi
2022-01-11 14:29 ` Andy Gospodarek
2022-01-08 11:53 ` [PATCH v21 bpf-next 07/23] xdp: add multi-buff support to xdp_return_{buff/frame} Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 08/23] net: mvneta: add multi buffer support to XDP_TX Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 09/23] bpf: introduce BPF_F_XDP_MB flag in prog_flags loading the ebpf program Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 10/23] net: mvneta: enable jumbo frames if the loaded XDP program support mb Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 11/23] bpf: introduce bpf_xdp_get_buff_len helper Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 12/23] bpf: add multi-buff support to the bpf_xdp_adjust_tail() API Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 13/23] bpf: add multi-buffer support to xdp copy helpers Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 14/23] bpf: move user_size out of bpf_test_init Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 15/23] bpf: introduce multibuff support to bpf_prog_test_run_xdp() Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 16/23] bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 17/23] bpf: selftests: update xdp_adjust_tail selftest to include multi-buffer Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 18/23] libbpf: Add SEC name for xdp_mb programs Lorenzo Bianconi
2022-01-10 2:16 ` Andrii Nakryiko
2022-01-12 18:17 ` Lorenzo Bianconi
2022-01-12 18:24 ` Andrii Nakryiko
2022-01-12 18:35 ` Lorenzo Bianconi
2022-01-12 19:16 ` Alexei Starovoitov
2022-01-12 19:20 ` Andrii Nakryiko
2022-01-12 19:47 ` Alexei Starovoitov
2022-01-12 20:04 ` Zvi Effron
2022-01-12 20:12 ` Lorenzo Bianconi
2022-01-12 22:04 ` Toke Høiland-Jørgensen
2022-01-13 9:38 ` Jesper Dangaard Brouer
2022-01-13 10:22 ` Lorenzo Bianconi
2022-01-13 20:19 ` Alexei Starovoitov
2022-01-13 23:58 ` Lorenzo Bianconi
2022-01-14 2:09 ` Alexei Starovoitov
2022-01-14 16:50 ` Jesper Dangaard Brouer
2022-01-14 18:55 ` Zvi Effron [this message]
2022-01-14 19:36 ` Andrii Nakryiko
2022-01-26 16:11 ` Lorenzo Bianconi
2022-01-26 20:12 ` Andrii Nakryiko
2022-01-14 16:35 ` Lorenzo Bianconi
2022-01-14 19:35 ` Andrii Nakryiko
2022-01-08 11:53 ` [PATCH v21 bpf-next 19/23] bpf: generalise tail call map compatibility check Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 20/23] net: xdp: introduce bpf_xdp_pointer utility routine Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 21/23] bpf: selftests: introduce bpf_xdp_{load,store}_bytes selftest Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 22/23] bpf: selftests: add CPUMAP/DEVMAP selftests for xdp multi-buff Lorenzo Bianconi
2022-01-08 11:53 ` [PATCH v21 bpf-next 23/23] xdp: disable XDP_REDIRECT " Lorenzo Bianconi
2022-01-12 18:55 ` [PATCH v21 bpf-next 00/23] mvneta: introduce XDP multi-buffer support Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC1LvL3M9OaSanES0uzp=vvgK23qPGRPpcAR6Z_Vqcvma3K5Qg@mail.gmail.com' \
--to=zeffron@riotgames.com \
--cc=alexander.duyck@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=echaudro@redhat.com \
--cc=jasowang@redhat.com \
--cc=jbrouer@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=shayagr@amazon.com \
--cc=tirthendu.sarkar@intel.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).