From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Edward Cree <ecree@solarflare.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andriin@fb.com>,
Kernel Team <kernel-team@fb.com>, Alexei Starovoitov <ast@fb.com>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH v5 bpf-next 0/4] capture integers in BTF type info for map defs
Date: Tue, 9 Jul 2019 14:39:57 -0700 [thread overview]
Message-ID: <CAEf4BzY5g-2R4ZYT5veH4TydyB=iMTmqMk2fx3gSS2SOi=QaqA@mail.gmail.com> (raw)
In-Reply-To: <0366eaff-b617-b88a-ade4-b9ee8c671e18@solarflare.com>
On Tue, Jul 9, 2019 at 1:27 PM Edward Cree <ecree@solarflare.com> wrote:
>
> On 05/07/2019 22:15, Daniel Borkmann wrote:
> > On 07/05/2019 05:50 PM, Andrii Nakryiko wrote:
> >> This patch set implements an update to how BTF-defined maps are specified. The
> >> change is in how integer attributes, e.g., type, max_entries, map_flags, are
> >> specified: now they are captured as part of map definition struct's BTF type
> >> information (using array dimension), eliminating the need for compile-time
> >> data initialization and keeping all the metadata in one place.
> >>
> >> All existing selftests that were using BTF-defined maps are updated, along
> >> with some other selftests, that were switched to new syntax.
> BTW is this changing the BTF format spec, and if so why isn't it accompanied by
> a patch to Documentation/bpf/btf.rst? It looks like that doc still talks about
> BPF_ANNOTATE_KV_PAIR, which seems to be long gone.
It didn't remove BPF_ANNOTATE_KV_PAIR and you can still use it and
libbpf will continue supporting it for the time being. But I'll update
the doc with new syntax, thanks for reminding!
>
> -Ed
prev parent reply other threads:[~2019-07-09 21:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 15:50 [PATCH v5 bpf-next 0/4] capture integers in BTF type info for map defs Andrii Nakryiko
2019-07-05 15:50 ` [PATCH v5 bpf-next 1/4] libbpf: capture value in BTF type info for BTF-defined " Andrii Nakryiko
2019-07-05 15:50 ` [PATCH v5 bpf-next 2/4] selftests/bpf: add __uint and __type macro for BTF-defined maps Andrii Nakryiko
2019-07-05 15:50 ` [PATCH v5 bpf-next 3/4] selftests/bpf: convert selftests using BTF-defined maps to new syntax Andrii Nakryiko
2019-07-05 15:50 ` [PATCH v5 bpf-next 4/4] selftests/bpf: convert legacy BPF maps to BTF-defined ones Andrii Nakryiko
2019-07-05 21:15 ` [PATCH v5 bpf-next 0/4] capture integers in BTF type info for map defs Daniel Borkmann
2019-07-06 3:49 ` Andrii Nakryiko
2019-07-09 20:27 ` Edward Cree
2019-07-09 21:39 ` Andrii Nakryiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzY5g-2R4ZYT5veH4TydyB=iMTmqMk2fx3gSS2SOi=QaqA@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ecree@solarflare.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).