From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
"Björn Töpel" <bjorn.topel@gmail.com>,
"Yonghong Song" <yhs@fb.com>
Subject: Re: [PATCH bpf v2] libbpf: Remove getsockopt() check for XDP_OPTIONS
Date: Mon, 16 Sep 2019 21:12:23 -0700 [thread overview]
Message-ID: <CAEf4BzaX3OgTofrx2gwHXLXBpRV7ahdCPJUGkaPreJV-D=4dGQ@mail.gmail.com> (raw)
In-Reply-To: <20190916123342.49928-1-toke@redhat.com>
On Mon, Sep 16, 2019 at 6:05 AM Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>
> The xsk_socket__create() function fails and returns an error if it cannot
> get the XDP_OPTIONS through getsockopt(). However, support for XDP_OPTIONS
> was not added until kernel 5.3, so this means that creating XSK sockets
> always fails on older kernels.
>
> Since the option is just used to set the zero-copy flag in the xsk struct,
> and that flag is not really used for anything yet, just remove the
> getsockopt() call until a proper use for it is introduced.
>
> Suggested-by: Yonghong Song <yhs@fb.com>
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
> ---
> v2:
> - Remove the call entirely.
>
> tools/lib/bpf/xsk.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
Who doesn't like removal of code?.. :)
Acked-by: Andrii Nakryiko <andriin@fb.com>
[...]
next prev parent reply other threads:[~2019-09-17 4:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 12:33 [PATCH bpf v2] libbpf: Remove getsockopt() check for XDP_OPTIONS Toke Høiland-Jørgensen
2019-09-17 4:12 ` Andrii Nakryiko [this message]
2019-09-19 12:31 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzaX3OgTofrx2gwHXLXBpRV7ahdCPJUGkaPreJV-D=4dGQ@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).